Comment improvement, restore accidental deletion

This commit is contained in:
Henrik Rydgård 2021-11-21 21:34:05 +01:00
parent f1cd1d535b
commit 29f54befbd
2 changed files with 8 additions and 2 deletions

View File

@ -841,6 +841,9 @@ void VulkanQueueRunner::LogRenderPass(const VKRStep &pass, bool verbose) {
case VKRRenderCommand::REMOVED:
INFO_LOG(G3D, " (Removed)");
break;
case VKRRenderCommand::BIND_PIPELINE:
INFO_LOG(G3D, " BindPipeline(%x)", (int)(intptr_t)cmd.pipeline.pipeline);
break;
case VKRRenderCommand::BIND_GRAPHICS_PIPELINE:
INFO_LOG(G3D, " BindGraphicsPipeline(%x)", (int)(intptr_t)cmd.graphics_pipeline.pipeline);
break;

View File

@ -33,8 +33,10 @@ bool VKRGraphicsPipeline::Create(VulkanContext *vulkan) {
delete desc;
desc = nullptr;
if (result == VK_INCOMPLETE) {
// Bad return value seen on Adreno in Burnout :( Try to ignore?
// Create a placeholder to avoid creating over and over if something is broken.
// Bad (disallowed by spec) return value seen on Adreno in Burnout :( Try to ignore?
// Would really like to log more here, we could probably attach more info to desc.
//
// At least create a null placeholder to avoid creating over and over if something is broken.
pipeline = VK_NULL_HANDLE;
return true;
} else if (result != VK_SUCCESS) {
@ -58,6 +60,7 @@ bool VKRComputePipeline::Create(VulkanContext *vulkan) {
desc = nullptr;
if (result != VK_SUCCESS) {
pipeline = VK_NULL_HANDLE;
ERROR_LOG(G3D, "Failed creating compute pipeline! result='%s'", VulkanResultToString(result));
return false;
}
return true;