Emulator-Archive/ppsspp
1
0
Fork 0
mirror of https://github.com/hrydgard/ppsspp.git synced 2024-11-22 21:09:52 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Stackwalk safety fix. Stackwalk logic fix (although probably not very important)

Browse Source
This commit is contained in:
Henrik Rydgård 2024-11-12 12:13:47 +01:00
parent 5a0d6f7a15
commit 30207aa25c
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Core/MIPS/MIPSStackWalk.cpp
View File

@ -113,6 +113,7 @@ namespace MIPSStackWalk {
stop = start - LONGEST_FUNCTION;
}
for (u32 pc = start; Memory::IsValidAddress(pc) && pc >= stop; pc -= 4) {
_dbg_assert_(Memory::IsValidAddress(pc));
MIPSOpcode op = Memory::Read_Instruction(pc, true);
// Here's where they store the ra address.
@ -162,7 +163,7 @@ namespace MIPSStackWalk {
}
}
std::vector<StackFrame> Walk(u32 pc, u32 ra, u32 sp, u32 threadEntry, u32 threadStackTop) {
std::vector<StackFrame> Walk(const u32 pc, u32 ra, u32 sp, const u32 threadEntry, u32 threadStackTop) {
std::vector<StackFrame> frames;
if (!Memory::IsValidAddress(pc) || !Memory::IsValidAddress(sp) || !Memory::IsValidAddress(ra)) {
@ -176,7 +177,7 @@ namespace MIPSStackWalk {
current.stackSize = -1;
u32 prevEntry = INVALIDTARGET;
while (pc != threadEntry) {
while (current.pc != threadEntry) {
if (!Memory::IsValidAddress(current.pc)) {
break;
}