Move buffer.cpp/h from base to Common

CMakeLists.txt

@@ -442,6 +442,8 @@ add_library(Common STATIC
 	Common/Crypto/sha256.h
 	Common/BitScan.h
 	Common/BitSet.h
+	Common/Buffer.h
+	Common/Buffer.cpp
 	Common/ByteSwap.h
 	Common/CodeBlock.h
 	Common/ColorConv.cpp
@@ -949,8 +951,6 @@ endif()
 
 add_library(native STATIC
 	${nativeExtra}
-	ext/native/base/buffer.cpp
-	ext/native/base/buffer.h
 	ext/native/base/colorutil.cpp
 	ext/native/base/colorutil.h
 	ext/native/base/display.cpp

Common/Buffer.cpp

@@ -1,4 +1,3 @@
-#include "base/buffer.h"
 
 #include <stdarg.h>
 #include <stdlib.h>
@@ -18,9 +17,10 @@
 #define MSG_NOSIGNAL 0x00
 #endif
 
-#include "Common/TimeUtil.h"
 #include "file/fd_util.h"
 
+#include "Common/TimeUtil.h"
+#include "Common/Buffer.h"
 #include "Common/Log.h"
 
 Buffer::Buffer() { }

Common/Common.vcxproj

@@ -354,6 +354,7 @@
     <ClInclude Include="ArmEmitter.h" />
     <ClInclude Include="BitScan.h" />
     <ClInclude Include="BitSet.h" />
+    <ClInclude Include="Buffer.h" />
     <ClInclude Include="ByteSwap.h" />
     <ClInclude Include="FakeEmitter.h" />
     <ClInclude Include="Serialize\SerializeDeque.h" />
@@ -441,6 +442,7 @@
       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release|ARM'">false</ExcludedFromBuild>
     </ClCompile>
     <ClCompile Include="ArmEmitter.cpp" />
+    <ClCompile Include="Buffer.cpp" />
     <ClCompile Include="ColorConvNEON.cpp">
       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'">true</ExcludedFromBuild>
       <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">true</ExcludedFromBuild>

Common/Common.vcxproj.filters

@@ -95,6 +95,7 @@
     <ClInclude Include="TimeUtil.h" />
     <ClInclude Include="FakeEmitter.h" />
     <ClInclude Include="ByteSwap.h" />
+    <ClInclude Include="Buffer.h" />
   </ItemGroup>
   <ItemGroup>
     <ClCompile Include="stdafx.cpp" />
@@ -162,6 +163,7 @@
     </ClCompile>
     <ClCompile Include="TimeUtil.cpp" />
     <ClCompile Include="Log.cpp" />
+    <ClCompile Include="Buffer.cpp" />
   </ItemGroup>
   <ItemGroup>
     <Filter Include="Crypto">

Common/StringUtils.cpp

@@ -41,10 +41,9 @@
 #include <algorithm>
 #include <iomanip>
 
-#include "base/buffer.h"
-
-#include "Common.h"
-#include "StringUtils.h"
+#include "Common/Common.h"
+#include "Common/Buffer.h"
+#include "Common/StringUtils.h"
 
 void truncate_cpy(char *dest, size_t destSize, const char *src) {
 	size_t len = strlen(src);

Core/Reporting.cpp

@@ -48,7 +48,6 @@
 #include "net/resolve.h"
 #include "net/url.h"
 
-#include "base/buffer.h"
 #include "thread/threadutil.h"
 #include "file/zip_read.h"
 

android/jni/Android.mk

@@ -204,6 +204,7 @@ EXEC_AND_LIB_FILES := \
   $(SRC)/ext/udis86/udis86.c \
   $(SRC)/ext/xbrz/xbrz.cpp \
   $(SRC)/ext/xxhash.c \
+  $(SRC)/Common/Buffer.cpp \
   $(SRC)/Common/Crypto/md5.cpp \
   $(SRC)/Common/Crypto/sha1.cpp \
   $(SRC)/Common/Crypto/sha256.cpp \

ext/native/Android.mk

@@ -7,7 +7,6 @@ include $(CLEAR_VARS)
 LOCAL_MODULE    := libnative
 LOCAL_ARM_MODE := arm
 LOCAL_SRC_FILES :=\
-    base/buffer.cpp \
     base/display.cpp \
     base/colorutil.cpp \
     data/base64.cpp \

ext/native/native.vcxproj

@@ -382,7 +382,6 @@
   </ItemGroup>
   <ItemGroup>
     <ClInclude Include="..\..\Qt\QtMain.h" />
-    <ClInclude Include="base\buffer.h" />
     <ClInclude Include="base\colorutil.h" />
     <ClInclude Include="base\display.h" />
     <ClInclude Include="base\NativeApp.h" />
@@ -484,7 +483,6 @@
     <ClInclude Include="util\tiny_set.h" />
   </ItemGroup>
   <ItemGroup>
-    <ClCompile Include="base\buffer.cpp" />
     <ClCompile Include="base\colorutil.cpp" />
     <ClCompile Include="base\display.cpp" />
     <ClCompile Include="..\..\SDL\SDLMain.cpp">

ext/native/native.vcxproj.filters

@@ -104,9 +104,6 @@
     <ClInclude Include="net\http_client.h">
       <Filter>net</Filter>
     </ClInclude>
-    <ClInclude Include="base\buffer.h">
-      <Filter>base</Filter>
-    </ClInclude>
     <ClInclude Include="file\fd_util.h">
       <Filter>file</Filter>
     </ClInclude>
@@ -400,9 +397,6 @@
     <ClCompile Include="net\http_client.cpp">
       <Filter>net</Filter>
     </ClCompile>
-    <ClCompile Include="base\buffer.cpp">
-      <Filter>base</Filter>
-    </ClCompile>
     <ClCompile Include="file\fd_util.cpp">
       <Filter>file</Filter>
     </ClCompile>

ext/native/net/http_client.cpp

@@ -17,16 +17,16 @@
 #endif
 
 #include <cmath>
-#include <stdio.h>
-#include <stdlib.h>
+#include <cstdio>
+#include <cstdlib>
 
-#include "base/buffer.h"
 #include "data/compression.h"
 #include "file/fd_util.h"
 #include "net/resolve.h"
 #include "net/url.h"
 #include "thread/threadutil.h"
 
+#include "Common/Buffer.h"
 #include "Common/Log.h"
 
 namespace net {

ext/native/net/http_client.h

@@ -5,7 +5,6 @@
 #include <thread>
 #include <cstdint>
 
-#include "base/buffer.h"
 #include "net/resolve.h"
 
 #ifdef _WIN32
@@ -21,6 +20,8 @@
 #include <netdb.h>
 #endif
 
+#include "Common/Buffer.h"
+
 namespace net {
 
 class Connection {

ext/native/net/http_headers.h

@@ -1,9 +1,9 @@
-#ifndef _NET_HTTP_HTTP_HEADERS
-#define _NET_HTTP_HTTP_HEADERS
+#pragma once
 
 #include <string>
 #include <unordered_map>
-#include "base/buffer.h"
+
+#include "Common/Buffer.h"
 
 namespace net {
 class InputSink;
@@ -48,5 +48,3 @@ class RequestHeader {
 };
 
 }  // namespace http
-
-#endif

ext/native/net/http_server.cpp

@@ -34,12 +34,12 @@
 #include <stdio.h>
 #include <stdlib.h>
 
-#include "base/buffer.h"
 #include "file/fd_util.h"
 #include "net/http_server.h"
 #include "net/sinks.h"
 #include "thread/executor.h"
 
+#include "Common/Buffer.h"
 #include "Common/Log.h"
 
 namespace http {

ext/native/net/http_server.h

@@ -1,10 +1,8 @@
-#ifndef _HTTP_SERVER_H
-#define _HTTP_SERVER_H
+#pragma once
 
 #include <functional>
 #include <map>
 
-#include "base/buffer.h"
 #include "net/http_headers.h"
 #include "net/resolve.h"
 #include "thread/executor.h"
@@ -114,5 +112,3 @@ private:
 };
 
 }  // namespace http
-
-#endif  // _HTTP_SERVER_H

libretro/Makefile.common

@@ -144,6 +144,7 @@ SOURCES_CXX += \
 
 SOURCES_CXX += \
 	$(COMMONDIR)/Serialize/Serializer.cpp \
+	$(COMMONDIR)/Common/Buffer.cpp \
 	$(COMMONDIR)/ConsoleListener.cpp \
 	$(COMMONDIR)/ExceptionHandlerSetup.cpp \
 	$(COMMONDIR)/FileUtil.cpp \
@@ -214,7 +215,6 @@ SOURCES_CXX += \
 	$(GPUDIR)/GLES/ShaderManagerGLES.cpp \
 	$(GPUDIR)/GLES/StateMappingGLES.cpp \
 	$(GPUDIR)/GLES/StencilBufferGLES.cpp \
-	$(EXTDIR)/native/base/buffer.cpp \
 	$(EXTDIR)/native/base/colorutil.cpp \
 	$(EXTDIR)/native/base/display.cpp \
 	$(EXTDIR)/native/data/compression.cpp \