Remove a function that didn't make a lot of sense.

Core/Debugger/Breakpoints.cpp

@@ -540,7 +540,7 @@ void CBreakPoints::Update(u32 addr)
 		if (addr != 0)
 			MIPSComp::jit->InvalidateCacheAt(addr - 4, 8);
 		else
-			MIPSComp::jit->InvalidateCache();
+			MIPSComp::jit->ClearCache();
 
 		if (resume)
 			Core_EnableStepping(false);

Core/MIPS/ARM/ArmJit.cpp

@@ -154,11 +154,6 @@ void ArmJit::ClearCache()
 	GenerateFixedCode();
 }
 
-void ArmJit::InvalidateCache()
-{
-	blocks.Clear();
-}
-
 void ArmJit::InvalidateCacheAt(u32 em_address, int length)
 {
 	blocks.InvalidateICache(em_address, length);

Core/MIPS/ARM/ArmJit.h

@@ -174,7 +174,6 @@ public:
 	void RestoreSavedEmuHackOps(std::vector<u32> saved) override { blocks.RestoreSavedEmuHackOps(saved); }
 
 	void ClearCache() override;
-	void InvalidateCache() override;
 	void InvalidateCacheAt(u32 em_address, int length = 4) override;
 
 	void EatPrefix() override { js.EatPrefix(); }

Core/MIPS/ARM64/Arm64Jit.cpp

@@ -146,10 +146,6 @@ void Arm64Jit::ClearCache() {
 	GenerateFixedCode(jo);
 }
 
-void Arm64Jit::InvalidateCache() {
-	blocks.Clear();
-}
-
 void Arm64Jit::InvalidateCacheAt(u32 em_address, int length) {
 	blocks.InvalidateICache(em_address, length);
 }
@@ -194,7 +190,7 @@ void Arm64Jit::Compile(u32 em_address) {
 		ClearCache();
 	}
 
-	BeginWrite();
+	BeginWrite(4);
 
 	int block_num = blocks.AllocateBlock(em_address);
 	JitBlock *b = blocks.GetBlock(block_num);
@@ -203,6 +199,9 @@ void Arm64Jit::Compile(u32 em_address) {
 
 	EndWrite();
 
+	// Don't forget to zap the newly written instructions in the instruction cache!
+	FlushIcache();
+
 	bool cleanSlate = false;
 
 	if (js.hasSetRounding && !js.lastSetRounding) {
@@ -336,9 +335,6 @@ const u8 *Arm64Jit::DoJit(u32 em_address, JitBlock *b) {
 	if (dontLogBlocks > 0)
 		dontLogBlocks--;
 
-	// Don't forget to zap the newly written instructions in the instruction cache!
-	FlushIcache();
-
 	if (js.lastContinuedPC == 0) {
 		b->originalSize = js.numInstructions;
 	} else {
@@ -406,7 +402,7 @@ void Arm64Jit::LinkBlock(u8 *exitPoint, const u8 *checkedEntry) {
 	}
 	ARM64XEmitter emit(exitPoint);
 	emit.B(checkedEntry);
-	// TODO: Write stuff after.
+	// TODO: Write stuff after, convering up the now-unused instructions.
 	emit.FlushIcache();
 	if (PlatformIsWXExclusive()) {
 		ProtectMemoryPages(exitPoint, 32, MEM_PROT_READ | MEM_PROT_EXEC);

Core/MIPS/ARM64/Arm64Jit.h

@@ -175,7 +175,6 @@ public:
 	void RestoreSavedEmuHackOps(std::vector<u32> saved) override { blocks.RestoreSavedEmuHackOps(saved); }
 
 	void ClearCache() override;
-	void InvalidateCache() override;
 	void InvalidateCacheAt(u32 em_address, int length = 4) override;
 
 	void EatPrefix() override { js.EatPrefix(); }

Core/MIPS/IR/IRJit.cpp

@@ -69,10 +69,6 @@ void IRJit::ClearCache() {
 	blocks_.Clear();
 }
 
-void IRJit::InvalidateCache() {
-	blocks_.Clear();
-}
-
 void IRJit::InvalidateCacheAt(u32 em_address, int length) {
 	blocks_.InvalidateICache(em_address, length);
 }

Core/MIPS/IR/IRJit.h

@@ -144,7 +144,6 @@ public:
 	void RestoreSavedEmuHackOps(std::vector<u32> saved) override { blocks_.RestoreSavedEmuHackOps(saved); }
 
 	void ClearCache() override;
-	void InvalidateCache() override;
 	void InvalidateCacheAt(u32 em_address, int length = 4) override;
 
 	const u8 *GetDispatcher() const override { return nullptr; }

Core/MIPS/JitCommon/JitBlockCache.cpp

@@ -60,7 +60,7 @@ op_agent_t agent;
 const u32 INVALID_EXIT = 0xFFFFFFFF;
 
 JitBlockCache::JitBlockCache(MIPSState *mips, CodeBlockCommon *codeBlock) :
-	codeBlock_(codeBlock), blocks_(0), num_blocks_(0) {
+	codeBlock_(codeBlock), blocks_(nullptr), num_blocks_(0) {
 }
 
 JitBlockCache::~JitBlockCache() {

Core/MIPS/JitCommon/JitCommon.h

@@ -123,7 +123,6 @@ namespace MIPSComp {
 		virtual bool DescribeCodePtr(const u8 *ptr, std::string &name) = 0;
 		virtual const u8 *GetDispatcher() const = 0;
 		virtual JitBlockCache *GetBlockCache() = 0;
-		virtual void InvalidateCache() = 0;
 		virtual void InvalidateCacheAt(u32 em_address, int length = 4) = 0;
 		virtual void DoState(PointerWrap &p) = 0;
 		virtual void DoDummyState(PointerWrap &p) = 0;

Core/MIPS/MIPS/MipsJit.cpp

@@ -99,11 +99,6 @@ void MipsJit::ClearCache()
 	//GenerateFixedCode();
 }
 
-void MipsJit::InvalidateCache()
-{
-	blocks.Clear();
-}
-
 void MipsJit::InvalidateCacheAt(u32 em_address, int length)
 {
 	blocks.InvalidateICache(em_address, length);

Core/MIPS/MIPS/MipsJit.h

@@ -135,7 +135,6 @@ public:
 	void RestoreSavedEmuHackOps(std::vector<u32> saved) override { blocks.RestoreSavedEmuHackOps(saved); }
 
 	void ClearCache() override;
-	void InvalidateCache() override;
 	void InvalidateCacheAt(u32 em_address, int length = 4) override;
 
 	void EatPrefix() override { js.EatPrefix(); }

Core/MIPS/fake/FakeJit.cpp

@@ -94,11 +94,6 @@ void FakeJit::ClearCache()
 	//GenerateFixedCode();
 }
 
-void FakeJit::InvalidateCache()
-{
-	blocks.Clear();
-}
-
 void FakeJit::InvalidateCacheAt(u32 em_address, int length)
 {
 	blocks.InvalidateICache(em_address, length);

Core/MIPS/fake/FakeJit.h

@@ -128,7 +128,6 @@ public:
 	JitBlockCache *GetBlockCache() { return &blocks; }
 
 	void ClearCache();
-	void InvalidateCache();
 	void InvalidateCacheAt(u32 em_address, int length = 4);
 
 	void EatPrefix() { js.EatPrefix(); }

Core/MIPS/x86/Jit.cpp

@@ -245,11 +245,6 @@ void Jit::ClearCache()
 	GenerateFixedCode(jo);
 }
 
-void Jit::InvalidateCache()
-{
-	blocks.Clear();
-}
-
 void Jit::CompileDelaySlot(int flags, RegCacheState *state)
 {
 	// Need to offset the downcount which was already incremented for the branch + delay slot.

Core/MIPS/x86/Jit.h

@@ -163,7 +163,6 @@ public:
 	void RestoreSavedEmuHackOps(std::vector<u32> saved) override { blocks.RestoreSavedEmuHackOps(saved); }
 
 	void ClearCache() override;
-	void InvalidateCache() override;
 	void InvalidateCacheAt(u32 em_address, int length = 4) override {
 		if (blocks.RangeMayHaveEmuHacks(em_address, em_address + length)) {
 			blocks.InvalidateICache(em_address, length);