Emulator-Archive/ppsspp
1
0
Fork 0
mirror of https://github.com/hrydgard/ppsspp.git synced 2024-11-22 21:09:52 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Some reporting cleanups

Browse Source
This commit is contained in:
Henrik Rydgård 2024-10-28 17:18:08 +01:00
parent e51f7c3a84
commit 6a7435341e
4 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Core/ELF/ElfReader.cpp
View File

@ -164,7 +164,8 @@ bool ElfReader::LoadRelocations(const Elf32_Rel *rels, int numRelocs) {
// It appears the PSP takes any relocation that is not a HI16.
if (t_type != R_MIPS_LO16) {
if (t_type != R_MIPS_16) {
// Let's play it safe for now and skip. We've only seen this type.
// Let's play it safe for now and skip. We've only seen this type.
// These exists in some popular games like Assassin's Creed: Bloodlines and GTA: VCS: (https://report.ppsspp.org/logs/kind/1187)
ERROR_LOG_REPORT(Log::Loader, "ELF relocation HI16/%d pair (instead of LO16) at %08x / %08x", t_type, addr, corrLoAddr);
continue;
} else {

9
Core/MIPS/MIPSInt.cpp
View File

@ -101,7 +101,7 @@ namespace MIPSInt
int func = (op >> 16) & 0x1F;
// Let's only report this once per run to be safe from impacting perf.
static bool reportedAlignment = false;
static bool loggedAlignment = false;
// It appears that a cache line is 0x40 (64) bytes, loops in games
// issue the cache instruction at that interval.
@ -120,9 +120,10 @@ namespace MIPSInt
int size = 0x40 + (addr & 0x3F);
MIPSComp::jit->InvalidateCacheAt(alignedAddr, size);
// Using a bool to avoid locking/etc. in case it's slow.
if (!reportedAlignment && (addr & 0x3F) != 0) {
WARN_LOG_REPORT(Log::JIT, "Unaligned icache invalidation of %08x (%08x + %d) at PC=%08x", addr, R(rs), imm, PC);
reportedAlignment = true;
if (!loggedAlignment && (addr & 0x3F) != 0) {
// These are seen exclusively in Lego games, and are really no big deal. Reporting removed.
WARN_LOG(Log::JIT, "Unaligned icache invalidation of %08x (%08x + %d) at PC=%08x", addr, R(rs), imm, PC);
loggedAlignment = true;
}
if (alignedAddr <= PC + 4 && alignedAddr + size >= PC - 4) {
// This is probably rare so we don't use a static bool.

2
Core/Reporting.cpp
View File

@ -254,7 +254,7 @@ namespace Reporting
// Returns only the hostname part (e.g. "report.ppsspp.org".)
static std::string ServerHostname() {
if (!IsEnabled())
return NULL;
return "";
std::string host = ServerHost();
size_t length = ServerHostnameLength();

3
GPU/GPUCommon.cpp
View File

@ -1349,8 +1349,7 @@ void GPUCommon::FlushImm() {
}
void GPUCommon::Execute_Unknown(u32 op, u32 diff) {
if ((op & 0xFFFFFF) != 0)
WARN_LOG_REPORT_ONCE(unknowncmd, Log::G3D, "Unknown GE command : %08x ", op);
// Do nothing. We used to report here, but we're confident we have them all so no need to report unknown.
}
void GPUCommon::FastLoadBoneMatrix(u32 target) {