Address some feedback

This commit is contained in:
Henrik Rydgård 2020-07-04 23:45:03 +02:00
parent 873c11d7f9
commit 7dcd708fac
4 changed files with 4 additions and 2 deletions

View File

@ -45,7 +45,6 @@
#include "Windows/InputDevice.h"
#endif
// Time until we stop considering the core active without user input.
// Should this be configurable? 2 hours currently.
static const double ACTIVITY_IDLE_TIMEOUT = 2.0 * 3600.0;
@ -385,6 +384,7 @@ const char *ExceptionTypeAsString(ExceptionType type) {
switch (type) {
case ExceptionType::MEMORY: return "Invalid Memory Access";
case ExceptionType::BREAK: return "Break";
case ExceptionType::BAD_EXEC_ADDR: return "Bad Execution Address";
default: return "N/A";
}
}

View File

@ -93,6 +93,7 @@ enum class ExceptionType {
NONE,
MEMORY,
BREAK,
BAD_EXEC_ADDR,
};
struct ExceptionInfo {

View File

@ -151,6 +151,7 @@ namespace MIPSInt
void Int_Break(MIPSOpcode op)
{
Reporting::ReportMessage("BREAK instruction hit");
Core_Break();
PC += 4;
}

View File

@ -97,7 +97,7 @@ bool coreCollectDebugStatsForced = false;
// This can be read and written from ANYWHERE.
volatile CoreState coreState = CORE_STEPPING;
// Note: intentionally not used for CORE_NEXTFRAME. << TODO: This comment is a lie, it is used!
// If true, core state has been changed, but JIT has probably not noticed yet.
volatile bool coreStatePending = false;
static volatile CPUThreadState cpuThreadState = CPU_THREAD_NOT_RUNNING;