Emulator-Archive/ppsspp
1
0
Fork 0
mirror of https://github.com/hrydgard/ppsspp.git synced 2025-03-03 11:37:20 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

softgpu: Correct clear mode dither.

Browse Source 
It does apply, but have to be careful about alpha.
This commit is contained in:
Unknown W. Brackets 2022-01-23 12:39:50 -08:00
parent 5a6bf8b435
commit 818d17183b
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
GPU/Software/Clipper.cpp
View File

@ -243,7 +243,7 @@ void ProcessRect(const VertexData &v0, const VertexData &v1, BinManager &binner)
RotateUVThrough(v0, v1, *topright, *bottomleft);
if (gstate.isModeClear()) {
if (gstate.isModeClear() && !gstate.isDitherEnabled()) {
binner.AddClearRect(v0, v1);
} else {
// Four triangles to do backfaces as well. Two of them will get backface culled.

4
GPU/Software/DrawPixelX86.cpp
View File

@ -1449,9 +1449,9 @@ bool PixelJitCache::Jit_Dither(const PixelFuncID &id) {
regCache_.Release(valueReg, RegCache::GEN_TEMP0);
// Now we want to broadcast RGB in 16-bit, but keep A as 0.
// Luckily, we know that second lane (in 16-bit) is zero from valueReg's high 16 bits.
// Luckily, we know that third lane (in 16-bit) is zero from MOVD clearing it.
// We use 16-bit because we need a signed add, but we also want to saturate.
PSHUFLW(vecValueReg, R(vecValueReg), _MM_SHUFFLE(1, 0, 0, 0));
PSHUFLW(vecValueReg, R(vecValueReg), _MM_SHUFFLE(2, 0, 0, 0));
// With that, now let's convert the color to 16 bit...
X64Reg argColorReg = regCache_.Find(RegCache::VEC_ARG_COLOR);

2
test.py
View File

@ -136,6 +136,7 @@ tests_good = [
"gpu/commands/basic",
"gpu/commands/blocktransfer",
"gpu/commands/material",
"gpu/dither/dither",
"gpu/filtering/linear",
"gpu/filtering/mipmaplinear",
"gpu/filtering/nearest",
@ -379,7 +380,6 @@ tests_next = [
"gpu/depth/precision",
"gpu/displaylist/alignment",
"gpu/displaylist/state",
"gpu/dither/dither",
"gpu/ge/break",
"gpu/ge/get",
"gpu/primitives/bezier",