Assorted paranoid cleanups, inspired by #14082

This commit is contained in:
Henrik Rydgård 2021-02-10 00:20:52 +01:00
parent caa58c6907
commit c76fe9cec4
3 changed files with 7 additions and 7 deletions

View File

@ -302,7 +302,7 @@ public:
// TODO: Optimize by getting the locations first and putting in a custom struct
UniformBufferDesc dynamicUniforms;
GLint samplerLocs_[8];
GLint samplerLocs_[8]{};
std::vector<GLint> dynamicUniformLocs_;
GLRProgram *program_ = nullptr;
@ -1038,7 +1038,7 @@ Pipeline *OpenGLContext::CreateGraphicsPipeline(const PipelineDesc &desc) {
ERROR_LOG(G3D, "Pipeline requires at least one shader");
return nullptr;
}
if ((int)desc.prim >= (int)Primitive::PRIMITIVE_TYPE_COUNT) {
if ((uint32_t)desc.prim >= (uint32_t)Primitive::PRIMITIVE_TYPE_COUNT) {
ERROR_LOG(G3D, "Invalid primitive type");
return nullptr;
}

View File

@ -99,7 +99,7 @@ public:
Bounds TransformBounds(const Bounds &bounds);
private:
Draw::DrawContext *draw_;
Draw::DrawContext *draw_ = nullptr;
Bounds bounds_;
float fontScaleX_ = 1.0f;
@ -107,7 +107,7 @@ private:
UI::FontStyle *fontStyle_ = nullptr;
TextDrawer *textDrawer_ = nullptr;
Draw::SamplerState *sampler_;
Draw::SamplerState *sampler_ = nullptr;
Draw::Pipeline *ui_pipeline_ = nullptr;
Draw::Pipeline *ui_pipeline_notex_ = nullptr;
std::unique_ptr<ManagedTexture> uitexture_;

View File

@ -516,8 +516,8 @@ void LogoScreen::render() {
const Bounds &bounds = dc.GetBounds();
float xres = dc.GetBounds().w;
float yres = dc.GetBounds().h;
float xres = bounds.w;
float yres = bounds.h;
dc.Begin();