Emulator-Archive/ppsspp
1
0
Fork 0
mirror of https://github.com/hrydgard/ppsspp.git synced 2024-11-23 13:30:02 +00:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

GPU: Make Spongebob hack checks more readable.

Browse Source 
Multiline clauses are just a lie programmers tell themselves to make them
think they've written readable code, just because it's better than a
single line.

Also add comments while there, in case this causes problems.
This commit is contained in:
Unknown W. Brackets 2022-08-28 08:50:16 -07:00
parent a8190f3eb4
commit f5efc1aa56
1 changed files with 36 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
GPU/Common/GPUStateUtils.h
View File

@ -202,25 +202,40 @@ void ConvertStencilFuncState(GenericStencilFuncState &stencilFuncState);
// See issue #15898
inline bool SpongebobDepthInverseConditions(const GenericStencilFuncState &stencilState) {
// Check that the depth/stencil state matches the conditions exactly
return gstate.isDepthTestEnabled() && !gstate.isDepthWriteEnabled() &&
gstate.getDepthTestFunction() == GE_COMP_GEQUAL &&
stencilState.zFail == GE_STENCILOP_ZERO && stencilState.sFail == GE_STENCILOP_KEEP && stencilState.zPass == GE_STENCILOP_KEEP &&
stencilState.testFunc == GE_COMP_ALWAYS && stencilState.writeMask == 0xFF &&
// And also verify no color is written. The game does this through simple alpha blending with a constant zero alpha.
// We also check for color mask, since it's more natural, in case another game does it.
((gstate.isAlphaBlendEnabled() &&
!gstate.isTextureMapEnabled() &&
gstate.getBlendFuncA() == GE_SRCBLEND_SRCALPHA &&
gstate.getBlendFuncB() == GE_DSTBLEND_INVSRCALPHA &&
(
( // Spongebob
gstate.getMaterialAmbientA() == 0x0 && // our accessor is kinda misnamed here, but material diffuse A is both used as default color and as ambient alpha
gstate.getMaterialUpdate() == 0
) ||
( // MX vs ATV : Reflex
gstate.getMaterialUpdate() == 1 // Really should also check vertex data, since that's where the zero is :(
)
)
) || gstate.getColorMask() == 0xFFFFFF00); // note that PSP masks are "inverted"
// Check that the depth/stencil state matches the conditions exactly.
// Always with a depth test that's not writing to the depth buffer (only stencil.)
if (!gstate.isDepthTestEnabled() || gstate.isDepthWriteEnabled())
return false;
// Always GREATER_EQUAL, which we flip to LESS.
if (gstate.getDepthTestFunction() != GE_COMP_GEQUAL)
return false;
// The whole purpose here is a depth fail that we need to write to alpha.
if (stencilState.zFail != GE_STENCILOP_ZERO || stencilState.sFail != GE_STENCILOP_KEEP || stencilState.zPass != GE_STENCILOP_KEEP)
return false;
if (stencilState.testFunc != GE_COMP_ALWAYS || stencilState.writeMask != 0xFF)
return false;
// Lastly, verify no color is written. Natural way is a mask, in case another game uses it.
// Note that the PSP masks are reversed compared to typical APIs.
if (gstate.getColorMask() == 0xFFFFFF00)
return true;
// These games specifically use simple alpha blending with a constant zero alpha.
if (!gstate.isAlphaBlendEnabled() || gstate.getBlendFuncA() != GE_SRCBLEND_SRCALPHA || gstate.getBlendFuncB() != GE_DSTBLEND_INVSRCALPHA)
return false;
// Also make sure there's no texture, in case its alpha gets involved.
if (gstate.isTextureMapEnabled())
return false;
// Spongebob uses material alpha.
if (gstate.getMaterialAmbientA() == 0x00 && gstate.getMaterialUpdate() == 0)
return true;
// MX vs ATV : Reflex uses vertex colors, should really check them...
if (gstate.getMaterialUpdate() == 1)
return true;
// Okay, color is most likely being used if we didn't hit the above.
return false;
}