Commit Graph

126 Commits

Author SHA1 Message Date
Unknown W. Brackets
5db79dcf11 Fix some missing semicolons on log statements. 2014-06-29 19:09:37 -07:00
Henrik Rydgard
ae09b521c3 Logging reductions 2014-06-23 20:05:12 +02:00
Henrik Rydgård
98165b599f Merge pull request #5653 from unknownbrackets/armjit-minor
Minor armjit optimizations, fix B/BL encoding
2014-03-22 16:05:59 +01:00
Henrik Rydgard
1a854a5ae6 Improve logging in sceSasSetVoice 2014-03-19 15:34:38 +01:00
Henrik Rydgard
27bcb570c0 Workaround for #5652: Force size to 0 if negative.
Should be fairly safe, and passes tests nicely.
2014-03-19 11:15:01 +01:00
Unknown W. Brackets
05ab192c9c Reduce includes in Core/HLE/.
Especially templates.
2014-03-15 11:22:19 -07:00
Unknown W. Brackets
2432a7d07f Typo. 2014-03-14 19:15:40 -07:00
lioncash
b9886942a7 Fix some vertical alignments in misc Core source files. 2014-03-03 11:16:53 -05:00
Unknown W. Brackets
9cba543a4b sceSasCoreWithMix() returns an error in raw mode.
And does not reschedule, specifically.
2014-02-22 08:48:55 -08:00
Unknown W. Brackets
10bf116399 Don't report sceSasSetADSRMode(..., 5, 5, 5, 5).
It seems common.
2014-02-22 08:39:15 -08:00
Unknown W. Brackets
ff920f6af6 Fix sceSas outputMode = 1 (which is not mono.)
May fix games that played audio only on the left side, or something.
2014-02-22 07:52:18 -08:00
Unknown W. Brackets
ede385bfed Validate output mode, correct dry/wet handling.
Seems like any non-zero parameter sets it, actually.  I previously changed
it to check the lowest bit but I can't reproduce it now...
2014-02-21 09:47:46 -08:00
Unknown W. Brackets
9ceeedba8d Correct some error codes in sceSasSetVoice(). 2014-02-18 23:12:26 -08:00
Unknown W. Brackets
139c91fe19 Return an error for an invalid pitch, per tests. 2014-02-17 21:09:43 -08:00
Unknown W. Brackets
95fc9624b4 Fix PCM looping in SAS.
The parameter specifies where the loop restarts at.
2014-02-17 01:39:58 -08:00
Unknown W. Brackets
a2cf4bde8c Validate the sas noise freq parameter. 2014-02-17 01:39:57 -08:00
Unknown W. Brackets
1a010a37ab Return an error for invalid voice in keyoff.
Can't reproduce no error and Every Extend Extra doesn't even seem to be
reporting it.  Most likely it would be happy with the error code anyway.
2014-02-17 01:39:56 -08:00
Unknown W. Brackets
f02bf1239e Validate the effect volume in __sceSasRevEVOL(). 2014-02-17 01:39:55 -08:00
Unknown W. Brackets
b5ac7b0c5f Dumb typo. 2014-02-08 07:29:02 -08:00
Unknown W. Brackets
fa6f004213 Validate ADSR modes in sceSasSetADSRmode().
Might prevent a game bug from breaking sounds, pretty unlikely.
2014-02-07 23:52:29 -08:00
Unknown W. Brackets
7e4e40b4d8 Reject invalid values in sceSasSetADSR().
Might happen due to a bug in a game, rejected by real firmware.
2014-02-07 22:44:11 -08:00
Unknown W. Brackets
074ef84559 Correct the rates set by sceSasSetSimpleADSR().
They were wrong for a few combinations before.  Could have effected how
accurate sound effects were (they may have been too quite, or dropped off
wrong, etc.)
2014-02-07 22:29:54 -08:00
raven02
0890567240 Small fix :) 2014-02-04 20:12:50 +08:00
raven02
3f20b5ad77 sceSas : should be always delay thread 2014-02-04 20:03:54 +08:00
Unknown W. Brackets
a00d5a2df8 Set a voice as keyed off when its envelope ends. 2014-02-04 01:35:53 -08:00
raven02
f381bfd0b4 Update comment 2014-01-27 17:22:01 +08:00
raven02
75a49129a6 Return without delay if voicesPlayingCount is zero 2014-01-27 10:07:56 +08:00
Henrik Rydgård
5b355c4a64 Improve comment about the sas delay 2014-01-26 14:37:41 +01:00
raven02
7701784608 Not reschelding if voicesPlayingCount == 0 2014-01-26 19:52:31 +08:00
Henrik Rydgard
0de71f27cb Optimize the VAGADPCM decoder. 2014-01-04 01:59:20 +01:00
Henrik Rydgard
2fe898cda8 Add comment with link to important github thread about sceSas threading 2013-11-09 02:05:28 +01:00
Henrik Rydgard
a790c0a723 SasAudio: Add some comments about reverb, and add the reverb type list 2013-10-23 22:59:42 +02:00
Unknown W. Brackets
50e9e45d65 Check version in each DoState() func.
They bail on PointerWrap error or bad version.
2013-09-14 20:23:03 -07:00
Henrik Rydgard
324cde5a79 Let's actually use the log category mechanism. A first step. 2013-09-07 21:19:21 +02:00
Henrik Rydgard
78d3ee3d6a Misc cleanup, mostly logging code 2013-09-07 13:01:19 +02:00
Unknown W. Brackets
fe1f4d53c6 Return an error on bad SAS sample rate.
Also reorder the types to fit the PSP's flag values.
2013-09-01 16:59:37 -07:00
Henrik Rydgard
a530d47fcd Clamp bad audio pitches for safety. 2013-08-27 22:47:45 +02:00
Unknown W. Brackets
a217cefa11 Tone down some less needed reporting. 2013-08-21 08:40:29 -07:00
Henrik Rydgard
806fadb1c0 logging tweak 2013-06-17 22:05:47 +02:00
Unknown W. Brackets
8b4b4a6b8c Use the 1 bit in sceSasRevVON() and cleanup.
Not used yet anyway.
2013-06-12 07:59:54 -07:00
Unknown W. Brackets
8e7c5be2e0 Don't return errors in sceSasSetPause().
-1 is perfectly valid, we just need to not infinite loop in that case by
using a logical shift not an arithmetic one.
2013-06-12 07:56:53 -07:00
Unknown W. Brackets
28729fc116 sceSasInit() ignores maxVoices and always does 32.
Weird, I can't find anything that parameter does except generate errors.
Most games call with 32 anyway...

Affects only sceSasGetEndFlag() and sceSasGetPauseFlag() really.
2013-06-11 00:43:52 -07:00
Unknown W. Brackets
b7d494f34e Delay in sceSasCore per tests.
Not sure if this fixes anything, but scheduling issues can be tricky.
2013-06-09 20:56:09 -07:00
Unknown W. Brackets
ea5996bf02 Don't restart release on double keyoff.
Fixes Kingdom Hearts bug, #2066.
2013-06-09 20:38:54 -07:00
Unknown W. Brackets
1d35cc46a4 Validate parameters in sceSasInit(). 2013-06-09 20:32:01 -07:00
oioitff
c98adee757 Implement __sceSasConcatenateATRAC3.
.
2013-06-09 19:07:02 +08:00
oioitff
3c13b574e3 Partly implement __sceSasSetVoiceATRAC3.
Fix Sol Trigger hang up issue.
2013-06-09 01:34:38 +08:00
Unknown W. Brackets
fa69e5e646 Didn't need any special logic here after all. 2013-05-27 17:05:13 -07:00
Unknown W. Brackets
7b154f9a2e Fix VAG looping. 2013-05-27 16:48:59 -07:00
Unknown W. Brackets
91bdc0617e Return an invalid size error even for VAG = 0. 2013-05-27 12:19:19 -07:00