ppsspp

mirror of https://github.com/hrydgard/ppsspp.git synced 2025-02-25 00:22:10 +00:00

History

Henrik Rydgård 72029b678a Empirical attempt at fixing #15661

Basically, software culling fails in some configuration, like the one we
end up with on Mali.

As noted by unknownbrackets in #15661, the viewport Z scale, offset is -0.0, 0.0.

We end up with CalcCullParams computing minZValue == maxZValue == 1.0f,
and with the vertices ending up with z,w == 1.0, 1.0.
and as a result, the inside/outside calculations will always decide that
it's outside.

Changing the comparisons from >= / <= to > / < fixes the problem, but I
don't know if this might break something else.

Anyhow, here's the simple way to repro on PC:

Change the ending of GPU_Vulkan::CheckFeatures to:

```c
	return GPU_USE_LIGHT_UBERSHADER | GPU_USE_BLEND_MINMAX | GPU_USE_TEXTURE_NPOT | GPU_USE_INSTANCE_RENDERING |
		GPU_USE_VERTEX_TEXTURE_FETCH | GPU_USE_TEXTURE_FLOAT | GPU_USE_16BIT_FORMATS | GPU_USE_TEXTURE_LOD_CONTROL |
		GPU_USE_DEPTH_TEXTURE | GPU_USE_ACCURATE_DEPTH;
```

2022-11-27 23:16:16 +01:00

Common

Empirical attempt at fixing #15661

2022-11-27 23:16:16 +01:00

D3D11

Can't forget the texture in the callback, breaks texture-from-framebuffer-copy.

2022-11-24 11:02:21 +01:00

Debugger

GE Debugger: Correct texture address corruption.

2022-11-19 14:59:52 -08:00

Directx9

Replace the "GetCurrentStepId"-based state invalidation with callbacks