FEX-Emu/FEX
1
0
Fork 0
mirror of https://github.com/FEX-Emu/FEX.git synced 2024-12-16 18:37:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
f27e2246e2
FEX/FEXHeaderUtils/CMakeLists.txt

65 lines
1.5 KiB
CMake
Raw Normal View History

FHU: Convert to a interface target Noticed recently that `FEXServer -w` was broken and couldn't understand why. Turns out that FHU syscall handling was /always/ falling down the `#else` path in the handlers since cmake `add_definitions` follows folder scoping rules. This means it was always returning -1, which was causing FEXServer's pidfd_open usage to always receive -1, which meant the sendmsg with FD was always failing, which meant the `FEXServer -w` would forever wait for a message that was never sent. Converting the utility over to a target not only fixes definition scoping problems, but also makes the other paths actually work. This found some compiling bugs and instead lets us define SYS_pidfd_open if it doesn't exist. Letting the kernel return the ENOSYS if it doesn't exist on that platform. Main thing, fixes FEXServer -w hanging forever.
2022-09-14 21:58:23 +00:00
add_library(FEXHeaderUtils INTERFACE)
Improves compile ability for older libraries Adds a header only include utility folder that can be included from everywhere. Contains syscall helpers for older glibc and defines for older Linux uapi headers missing some defines.
2021-12-24 23:43:25 +00:00
# Check for syscall support here
check_cxx_source_compiles(
FHU: Convert to a interface target Noticed recently that `FEXServer -w` was broken and couldn't understand why. Turns out that FHU syscall handling was /always/ falling down the `#else` path in the handlers since cmake `add_definitions` follows folder scoping rules. This means it was always returning -1, which was causing FEXServer's pidfd_open usage to always receive -1, which meant the sendmsg with FD was always failing, which meant the `FEXServer -w` would forever wait for a message that was never sent. Converting the utility over to a target not only fixes definition scoping problems, but also makes the other paths actually work. This found some compiling bugs and instead lets us define SYS_pidfd_open if it doesn't exist. Letting the kernel return the ENOSYS if it doesn't exist on that platform. Main thing, fixes FEXServer -w hanging forever.
2022-09-14 21:58:23 +00:00
"
#include <sched.h>
int main() {
return ::getcpu(nullptr, nullptr);
}"
FHU: Fixes syscall helper caching check_cxx_source_compiles caches by variable name, so `compiles` was getting cached and breaking future checks.
2023-09-19 00:05:40 +00:00
HAS_SYSCALL_GETCPU)
if (HAS_SYSCALL_GETCPU)
Improves compile ability for older libraries Adds a header only include utility folder that can be included from everywhere. Contains syscall helpers for older glibc and defines for older Linux uapi headers missing some defines.
2021-12-24 23:43:25 +00:00
message(STATUS "Has getcpu helper")
FHU: Convert to a interface target Noticed recently that `FEXServer -w` was broken and couldn't understand why. Turns out that FHU syscall handling was /always/ falling down the `#else` path in the handlers since cmake `add_definitions` follows folder scoping rules. This means it was always returning -1, which was causing FEXServer's pidfd_open usage to always receive -1, which meant the sendmsg with FD was always failing, which meant the `FEXServer -w` would forever wait for a message that was never sent. Converting the utility over to a target not only fixes definition scoping problems, but also makes the other paths actually work. This found some compiling bugs and instead lets us define SYS_pidfd_open if it doesn't exist. Letting the kernel return the ENOSYS if it doesn't exist on that platform. Main thing, fixes FEXServer -w hanging forever.
2022-09-14 21:58:23 +00:00
target_compile_definitions(FEXHeaderUtils INTERFACE HAS_SYSCALL_GETCPU=1)
Improves compile ability for older libraries Adds a header only include utility folder that can be included from everywhere. Contains syscall helpers for older glibc and defines for older Linux uapi headers missing some defines.
2021-12-24 23:43:25 +00:00
endif ()
check_cxx_source_compiles(
FHU: Convert to a interface target Noticed recently that `FEXServer -w` was broken and couldn't understand why. Turns out that FHU syscall handling was /always/ falling down the `#else` path in the handlers since cmake `add_definitions` follows folder scoping rules. This means it was always returning -1, which was causing FEXServer's pidfd_open usage to always receive -1, which meant the sendmsg with FD was always failing, which meant the `FEXServer -w` would forever wait for a message that was never sent. Converting the utility over to a target not only fixes definition scoping problems, but also makes the other paths actually work. This found some compiling bugs and instead lets us define SYS_pidfd_open if it doesn't exist. Letting the kernel return the ENOSYS if it doesn't exist on that platform. Main thing, fixes FEXServer -w hanging forever.
2022-09-14 21:58:23 +00:00
"
#include <unistd.h>
int main() {
return ::gettid();
}"
FHU: Fixes syscall helper caching check_cxx_source_compiles caches by variable name, so `compiles` was getting cached and breaking future checks.
2023-09-19 00:05:40 +00:00
HAS_SYSCALL_GETTID)
if (HAS_SYSCALL_GETTID)
Improves compile ability for older libraries Adds a header only include utility folder that can be included from everywhere. Contains syscall helpers for older glibc and defines for older Linux uapi headers missing some defines.
2021-12-24 23:43:25 +00:00
message(STATUS "Has gettid helper")
FHU: Convert to a interface target Noticed recently that `FEXServer -w` was broken and couldn't understand why. Turns out that FHU syscall handling was /always/ falling down the `#else` path in the handlers since cmake `add_definitions` follows folder scoping rules. This means it was always returning -1, which was causing FEXServer's pidfd_open usage to always receive -1, which meant the sendmsg with FD was always failing, which meant the `FEXServer -w` would forever wait for a message that was never sent. Converting the utility over to a target not only fixes definition scoping problems, but also makes the other paths actually work. This found some compiling bugs and instead lets us define SYS_pidfd_open if it doesn't exist. Letting the kernel return the ENOSYS if it doesn't exist on that platform. Main thing, fixes FEXServer -w hanging forever.
2022-09-14 21:58:23 +00:00
target_compile_definitions(FEXHeaderUtils INTERFACE HAS_SYSCALL_GETTID=1)
Improves compile ability for older libraries Adds a header only include utility folder that can be included from everywhere. Contains syscall helpers for older glibc and defines for older Linux uapi headers missing some defines.
2021-12-24 23:43:25 +00:00
endif ()
check_cxx_source_compiles(
FHU: Convert to a interface target Noticed recently that `FEXServer -w` was broken and couldn't understand why. Turns out that FHU syscall handling was /always/ falling down the `#else` path in the handlers since cmake `add_definitions` follows folder scoping rules. This means it was always returning -1, which was causing FEXServer's pidfd_open usage to always receive -1, which meant the sendmsg with FD was always failing, which meant the `FEXServer -w` would forever wait for a message that was never sent. Converting the utility over to a target not only fixes definition scoping problems, but also makes the other paths actually work. This found some compiling bugs and instead lets us define SYS_pidfd_open if it doesn't exist. Letting the kernel return the ENOSYS if it doesn't exist on that platform. Main thing, fixes FEXServer -w hanging forever.
2022-09-14 21:58:23 +00:00
"
#include <signal.h>
int main() {
return ::tgkill(0, 0, 0);
}"
FHU: Fixes syscall helper caching check_cxx_source_compiles caches by variable name, so `compiles` was getting cached and breaking future checks.
2023-09-19 00:05:40 +00:00
HAS_SYSCALL_TGKILL)
if (HAS_SYSCALL_TGKILL)
Improves compile ability for older libraries Adds a header only include utility folder that can be included from everywhere. Contains syscall helpers for older glibc and defines for older Linux uapi headers missing some defines.
2021-12-24 23:43:25 +00:00
message(STATUS "Has tgkill helper")
FHU: Convert to a interface target Noticed recently that `FEXServer -w` was broken and couldn't understand why. Turns out that FHU syscall handling was /always/ falling down the `#else` path in the handlers since cmake `add_definitions` follows folder scoping rules. This means it was always returning -1, which was causing FEXServer's pidfd_open usage to always receive -1, which meant the sendmsg with FD was always failing, which meant the `FEXServer -w` would forever wait for a message that was never sent. Converting the utility over to a target not only fixes definition scoping problems, but also makes the other paths actually work. This found some compiling bugs and instead lets us define SYS_pidfd_open if it doesn't exist. Letting the kernel return the ENOSYS if it doesn't exist on that platform. Main thing, fixes FEXServer -w hanging forever.
2022-09-14 21:58:23 +00:00
target_compile_definitions(FEXHeaderUtils INTERFACE HAS_SYSCALL_TGKILL=1)
Improves compile ability for older libraries Adds a header only include utility folder that can be included from everywhere. Contains syscall helpers for older glibc and defines for older Linux uapi headers missing some defines.
2021-12-24 23:43:25 +00:00
endif ()
check_cxx_source_compiles(
FHU: Convert to a interface target Noticed recently that `FEXServer -w` was broken and couldn't understand why. Turns out that FHU syscall handling was /always/ falling down the `#else` path in the handlers since cmake `add_definitions` follows folder scoping rules. This means it was always returning -1, which was causing FEXServer's pidfd_open usage to always receive -1, which meant the sendmsg with FD was always failing, which meant the `FEXServer -w` would forever wait for a message that was never sent. Converting the utility over to a target not only fixes definition scoping problems, but also makes the other paths actually work. This found some compiling bugs and instead lets us define SYS_pidfd_open if it doesn't exist. Letting the kernel return the ENOSYS if it doesn't exist on that platform. Main thing, fixes FEXServer -w hanging forever.
2022-09-14 21:58:23 +00:00
"
#include <sys/stat.h>
int main() {
return ::statx(0, nullptr, 0, 0, nullptr);
}"
FHU: Fixes syscall helper caching check_cxx_source_compiles caches by variable name, so `compiles` was getting cached and breaking future checks.
2023-09-19 00:05:40 +00:00
HAS_SYSCALL_STATX)
if (HAS_SYSCALL_STATX)
Improves compile ability for older libraries Adds a header only include utility folder that can be included from everywhere. Contains syscall helpers for older glibc and defines for older Linux uapi headers missing some defines.
2021-12-24 23:43:25 +00:00
message(STATUS "Has statx helper")
FHU: Convert to a interface target Noticed recently that `FEXServer -w` was broken and couldn't understand why. Turns out that FHU syscall handling was /always/ falling down the `#else` path in the handlers since cmake `add_definitions` follows folder scoping rules. This means it was always returning -1, which was causing FEXServer's pidfd_open usage to always receive -1, which meant the sendmsg with FD was always failing, which meant the `FEXServer -w` would forever wait for a message that was never sent. Converting the utility over to a target not only fixes definition scoping problems, but also makes the other paths actually work. This found some compiling bugs and instead lets us define SYS_pidfd_open if it doesn't exist. Letting the kernel return the ENOSYS if it doesn't exist on that platform. Main thing, fixes FEXServer -w hanging forever.
2022-09-14 21:58:23 +00:00
target_compile_definitions(FEXHeaderUtils INTERFACE HAS_SYSCALL_STATX=1)
Improves compile ability for older libraries Adds a header only include utility folder that can be included from everywhere. Contains syscall helpers for older glibc and defines for older Linux uapi headers missing some defines.
2021-12-24 23:43:25 +00:00
endif ()
check_cxx_source_compiles(
FHU: Convert to a interface target Noticed recently that `FEXServer -w` was broken and couldn't understand why. Turns out that FHU syscall handling was /always/ falling down the `#else` path in the handlers since cmake `add_definitions` follows folder scoping rules. This means it was always returning -1, which was causing FEXServer's pidfd_open usage to always receive -1, which meant the sendmsg with FD was always failing, which meant the `FEXServer -w` would forever wait for a message that was never sent. Converting the utility over to a target not only fixes definition scoping problems, but also makes the other paths actually work. This found some compiling bugs and instead lets us define SYS_pidfd_open if it doesn't exist. Letting the kernel return the ENOSYS if it doesn't exist on that platform. Main thing, fixes FEXServer -w hanging forever.
2022-09-14 21:58:23 +00:00
"
#include <stdio.h>
int main() {
return ::renameat2(0, nullptr, 0, nullptr, 0);
}"
FHU: Fixes syscall helper caching check_cxx_source_compiles caches by variable name, so `compiles` was getting cached and breaking future checks.
2023-09-19 00:05:40 +00:00
HAS_SYSCALL_RENAMEAT2)
if (HAS_SYSCALL_RENAMEAT2)
Improves compile ability for older libraries Adds a header only include utility folder that can be included from everywhere. Contains syscall helpers for older glibc and defines for older Linux uapi headers missing some defines.
2021-12-24 23:43:25 +00:00
message(STATUS "Has renameat2 helper")
FHU: Convert to a interface target Noticed recently that `FEXServer -w` was broken and couldn't understand why. Turns out that FHU syscall handling was /always/ falling down the `#else` path in the handlers since cmake `add_definitions` follows folder scoping rules. This means it was always returning -1, which was causing FEXServer's pidfd_open usage to always receive -1, which meant the sendmsg with FD was always failing, which meant the `FEXServer -w` would forever wait for a message that was never sent. Converting the utility over to a target not only fixes definition scoping problems, but also makes the other paths actually work. This found some compiling bugs and instead lets us define SYS_pidfd_open if it doesn't exist. Letting the kernel return the ENOSYS if it doesn't exist on that platform. Main thing, fixes FEXServer -w hanging forever.
2022-09-14 21:58:23 +00:00
target_compile_definitions(FEXHeaderUtils INTERFACE HAS_SYSCALL_RENAMEAT2=1)
Add pidfd_open syscall helpers
2022-07-15 05:44:07 +00:00
endif ()
FHU: Convert to a interface target Noticed recently that `FEXServer -w` was broken and couldn't understand why. Turns out that FHU syscall handling was /always/ falling down the `#else` path in the handlers since cmake `add_definitions` follows folder scoping rules. This means it was always returning -1, which was causing FEXServer's pidfd_open usage to always receive -1, which meant the sendmsg with FD was always failing, which meant the `FEXServer -w` would forever wait for a message that was never sent. Converting the utility over to a target not only fixes definition scoping problems, but also makes the other paths actually work. This found some compiling bugs and instead lets us define SYS_pidfd_open if it doesn't exist. Letting the kernel return the ENOSYS if it doesn't exist on that platform. Main thing, fixes FEXServer -w hanging forever.
2022-09-14 21:58:23 +00:00
target_include_directories(FEXHeaderUtils INTERFACE .)
Reference in New Issue Copy Permalink