FEX-Emu/FEX
1
0
Fork 0
mirror of https://github.com/FEX-Emu/FEX.git synced 2025-02-18 13:59:22 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Remove unnecessary WIN32 file handling TODOs

Browse Source 
With WOW, all allocations from 64-bit code use the full address space
and limiting is handled on the syscall thunk side so theres need to
worry about STL allocations stealing AS.
This commit is contained in:
Billy Laws 2023-08-10 04:07:46 -07:00
parent 5de0714766
commit 00556023c2
2 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
FEXCore/Source/Utils/FileLoading.cpp
View File

@ -56,7 +56,6 @@ ssize_t LoadFileToBuffer(const fextl::string &Filepath, std::span<char> Buffer)
}
#else
// TODO: Should be rewritten using WIN32 specific APIs.
template<typename T>
static bool LoadFileImpl(T &Data, const fextl::string &Filepath, size_t FixedSize) {
std::ifstream f(Filepath, std::ios::binary | std::ios::ate);

3
FEXHeaderUtils/FEXHeaderUtils/Filesystem.h
View File

@ -73,7 +73,6 @@ namespace FHU::Filesystem {
return CreateDirectoryResult::ERROR;
}
#else
// TODO: Should be rewritten using WIN32 specific APIs.
inline CreateDirectoryResult CreateDirectory(const fextl::string &Path) {
std::error_code ec;
if (std::filesystem::exists(Path, ec)) {
@ -226,7 +225,6 @@ namespace FHU::Filesystem {
return false;
}
#else
// TODO: Should be rewritten using WIN32 specific APIs.
inline bool CopyFile(const fextl::string &From, const fextl::string &To, CopyOptions Options = CopyOptions::NONE) {
std::filesystem::copy_options options{};
if (Options == CopyOptions::SKIP_EXISTING) {
@ -359,7 +357,6 @@ namespace FHU::Filesystem {
return realpath(Path, Fill);
}
#else
// TODO: Should be rewritten using WIN32 specific APIs.
inline char *Absolute(const char *Path, char Fill[PATH_MAX]) {
std::error_code ec;
const auto PathAbsolute = std::filesystem::absolute(Path, ec);