FEX-Emu/FEX
1
0
Fork 0
mirror of https://github.com/FEX-Emu/FEX.git synced 2025-02-23 16:23:10 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

OpcodeDispatcher: Cleanup PF select

Browse Source 
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
This commit is contained in:
Alyssa Rosenzweig 2023-11-10 10:46:38 -04:00
parent 482b35c283
commit 61bdf64e15
2 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
FEXCore/Source/Interface/Core/OpcodeDispatcher.cpp
View File

@ -829,10 +829,9 @@ void OpDispatchBuilder::CALLAbsoluteOp(OpcodeArgs) {
_ExitFunction(JMPPCOffset); // If we get here then leave the function now
}
OrderedNode *OpDispatchBuilder::SelectMask(OrderedNode *Cmp, uint64_t Mask, bool TrueIsNonzero, IR::OpSize ResultSize, OrderedNode *TrueValue, OrderedNode *FalseValue) {
OrderedNode *OpDispatchBuilder::SelectBit(OrderedNode *Cmp, bool TrueIsNonzero, IR::OpSize ResultSize, OrderedNode *TrueValue, OrderedNode *FalseValue) {
uint64_t TrueConst, FalseConst;
if (std::has_single_bit(Mask) &&
IsValueConstant(WrapNode(TrueValue), &TrueConst) &&
if (IsValueConstant(WrapNode(TrueValue), &TrueConst) &&
IsValueConstant(WrapNode(FalseValue), &FalseConst) &&
TrueConst == 1 &&
FalseConst == 0) {
@ -840,15 +839,12 @@ OrderedNode *OpDispatchBuilder::SelectMask(OrderedNode *Cmp, uint64_t Mask, bool
if (!TrueIsNonzero)
Cmp = _Not(OpSize::i32Bit, Cmp);
if (Mask == 1)
return _And(ResultSize, Cmp, _Constant(1));
else
return _Bfe(ResultSize, 1, FindFirstSetBit(Mask) - 1, Cmp);
return _And(ResultSize, Cmp, _Constant(1));
}
return _Select(ResultSize, OpSize::i32Bit,
TrueIsNonzero ? CondClassType{COND_ANDNZ} : CondClassType{COND_ANDZ},
Cmp, _Constant(Mask),
Cmp, _Constant(1),
TrueValue, FalseValue);
}
@ -890,10 +886,10 @@ OrderedNode *OpDispatchBuilder::SelectCC(uint8_t OP, IR::OpSize ResultSize, Orde
}
case 0xA: { // JP - Jump if PF == 1
// Raw value contains inverted PF in bottom bit
return SelectMask(LoadPFRaw(), 0x1, false, ResultSize, TrueValue, FalseValue);
return SelectBit(LoadPFRaw(), false, ResultSize, TrueValue, FalseValue);
}
case 0xB: { // JNP - Jump if PF == 0
return SelectMask(LoadPFRaw(), 0x1, true, ResultSize, TrueValue, FalseValue);
return SelectBit(LoadPFRaw(), true, ResultSize, TrueValue, FalseValue);
}
case 0xC: { // SF <> OF
return _NZCVSelect(ResultSize, CondClassType{COND_SLT}, TrueValue, FalseValue);

2
FEXCore/Source/Interface/Core/OpcodeDispatcher.h
View File

@ -1448,7 +1448,7 @@ private:
CachedIndexedNamedVectorConstants.clear();
}
OrderedNode *SelectMask(OrderedNode *Cmp, uint64_t Mask, bool Invert, IR::OpSize ResultSize, OrderedNode *TrueValue, OrderedNode *FalseValue);
OrderedNode *SelectBit(OrderedNode *Cmp, bool Invert, IR::OpSize ResultSize, OrderedNode *TrueValue, OrderedNode *FalseValue);
OrderedNode *SelectCC(uint8_t OP, IR::OpSize ResultSize, OrderedNode *TrueValue, OrderedNode *FalseValue);
/**