General: Resolve -Wignored-qualifiers warnings

Removes const qualifiers that don't do anything to the interface.
This commit is contained in:
Lioncash 2021-06-16 21:48:11 -04:00
parent d2771669e6
commit ef7aff796f
3 changed files with 7 additions and 6 deletions

View File

@ -286,6 +286,7 @@ function(AddObject Name Type)
target_compile_options(${Name} target_compile_options(${Name}
PRIVATE PRIVATE
-Wall -Wall
-Werror=ignored-qualifiers
-Werror=implicit-fallthrough -Werror=implicit-fallthrough
-Wno-trigraphs -Wno-trigraphs

View File

@ -240,7 +240,7 @@ namespace FEXCore::Context {
void DestroyThread(FEXCore::Core::InternalThreadState *Thread); void DestroyThread(FEXCore::Core::InternalThreadState *Thread);
void CleanupAfterFork(FEXCore::Core::InternalThreadState *ExceptForThread); void CleanupAfterFork(FEXCore::Core::InternalThreadState *ExceptForThread);
std::vector<FEXCore::Core::InternalThreadState*> *const GetThreads() { return &Threads; } std::vector<FEXCore::Core::InternalThreadState*>* GetThreads() { return &Threads; }
uint8_t GetGPRSize() const { return Config.Is64BitMode ? 8 : 4; } uint8_t GetGPRSize() const { return Config.Is64BitMode ? 8 : 4; }

View File

@ -69,8 +69,8 @@ class DualIntrusiveAllocator final {
size_t ListSize() const { return ListCurrentOffset; } size_t ListSize() const { return ListCurrentOffset; }
size_t ListBackingSize() const { return MemorySize; } size_t ListBackingSize() const { return MemorySize; }
uintptr_t const DataBegin() const { return Data; } uintptr_t DataBegin() const { return Data; }
uintptr_t const ListBegin() const { return List; } uintptr_t ListBegin() const { return List; }
void Reset() { DataCurrentOffset = 0; ListCurrentOffset = 0; } void Reset() { DataCurrentOffset = 0; ListCurrentOffset = 0; }
@ -159,7 +159,7 @@ public:
stream.write((char*)GetListData(), ListSize); stream.write((char*)GetListData(), ListSize);
} }
size_t GetInlineSize() { size_t GetInlineSize() const {
static_assert(sizeof(*this) == 40); static_assert(sizeof(*this) == 40);
return sizeof(*this) + DataSize + ListSize; return sizeof(*this) + DataSize + ListSize;
} }
@ -317,11 +317,11 @@ public:
return iterator(reinterpret_cast<uintptr_t>(GetListData()), reinterpret_cast<uintptr_t>(GetData()), Wrapped); return iterator(reinterpret_cast<uintptr_t>(GetListData()), reinterpret_cast<uintptr_t>(GetData()), Wrapped);
} }
uintptr_t const GetData() const { uintptr_t GetData() const {
return reinterpret_cast<uintptr_t>(IRDataInternal ? IRDataInternal : InlineData); return reinterpret_cast<uintptr_t>(IRDataInternal ? IRDataInternal : InlineData);
} }
uintptr_t const GetListData() const { uintptr_t GetListData() const {
return reinterpret_cast<uintptr_t>(ListDataInternal ? ListDataInternal : &InlineData[DataSize]); return reinterpret_cast<uintptr_t>(ListDataInternal ? ListDataInternal : &InlineData[DataSize]);
} }