FEX-Emu/linux
1
0
Fork 0
mirror of https://github.com/FEX-Emu/linux.git synced 2025-01-26 04:35:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

checkpatch: improve UNSPECIFIED_INT test for bare signed/unsigned uses

Browse Source 
Improve the test to allow casts to (unsigned) or (signed) to be found
and fixed if desired.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Joe Perches 2016-03-15 14:58:06 -07:00 committed by Linus Torvalds
parent a1ce18e4f9
commit 207a8e8465
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
scripts/checkpatch.pl
View File

@ -3240,10 +3240,11 @@ sub process {
next if ($line =~ /^[^\+]/); next if ($line =~ /^[^\+]/);
# check for declarations of signed or unsigned without int # check for declarations of signed or unsigned without int
while ($line =~ m{($Declare++)\s*($Ident)\s*[=,;\[\)]}g) { while ($line =~ m{($Declare)\s*(?!char\b|short\b|int\b|long\b)\s*($Ident)?\s*[=,;\[\)\(]}g) {
my $type = $1; my $type = $1;
my $var = $2; my $var = $2;
if ($type =~ /^((?:un)?signed)((?:\s*\*)*)\s*$/) { $var = "" if (!defined $var);
if ($type =~ /^(?:(?:$Storage|$Inline|$Attribute)\s+)*((?:un)?signed)((?:\s*\*)*)\s*$/) {
my $sign = $1; my $sign = $1;
my $pointer = $2; my $pointer = $2;
@ -3253,8 +3254,11 @@ sub process {
"Prefer '" . trim($sign) . " int" . rtrim($pointer) . "' to bare use of '$sign" . rtrim($pointer) . "'\n" . $herecurr) && "Prefer '" . trim($sign) . " int" . rtrim($pointer) . "' to bare use of '$sign" . rtrim($pointer) . "'\n" . $herecurr) &&
$fix) { $fix) {
my $decl = trim($sign) . " int "; my $decl = trim($sign) . " int ";
$decl .= trim($pointer) if (rtrim($pointer) ne ""); my $comp_pointer = $pointer;
$fixed[$fixlinenr] =~ s@\b\Q$type\E\s*$var\b@$decl$var@; $comp_pointer =~ s/\s//g;
$decl .= $comp_pointer;
$decl = rtrim($decl) if ($var eq "");
$fixed[$fixlinenr] =~ s@\b$sign\s*\Q$pointer\E\s*$var\b@$decl$var@;
} }
} }
} }