FEX-Emu/linux
1
0
Fork 0
mirror of https://github.com/FEX-Emu/linux.git synced 2025-01-13 12:53:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

usb: gadget: fix error return code

Browse Source 
Convert a zero return value on error to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Felipe Balbi <balbi@ti.com>
This commit is contained in:
Julia Lawall 2014-08-07 22:57:47 +02:00 committed by Felipe Balbi
parent bbc66e140b
commit 20e7d4653d
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/usb/gadget/udc/fusb300_udc.c
View File

@ -1398,13 +1398,17 @@ static int fusb300_probe(struct platform_device *pdev)
/* initialize udc */ /* initialize udc */
fusb300 = kzalloc(sizeof(struct fusb300), GFP_KERNEL); fusb300 = kzalloc(sizeof(struct fusb300), GFP_KERNEL);
if (fusb300 == NULL) if (fusb300 == NULL) {
ret = -ENOMEM;
goto clean_up; goto clean_up;
}
for (i = 0; i < FUSB300_MAX_NUM_EP; i++) { for (i = 0; i < FUSB300_MAX_NUM_EP; i++) {
_ep[i] = kzalloc(sizeof(struct fusb300_ep), GFP_KERNEL); _ep[i] = kzalloc(sizeof(struct fusb300_ep), GFP_KERNEL);
if (_ep[i] == NULL) if (_ep[i] == NULL) {
ret = -ENOMEM;
goto clean_up; goto clean_up;
}
fusb300->ep[i] = _ep[i]; fusb300->ep[i] = _ep[i];
} }