FEX-Emu/linux
1
0
Fork 0
mirror of https://github.com/FEX-Emu/linux.git synced 2025-01-14 13:39:10 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

V4L/DVB (10791): videodev: not possible to register NULL video_device

Browse Source 
video_register_device_index() checks if it was passed a NULL video_device
pointer (which isn't allowed) _after_ it has already dereferenced it with
video_get_drvdata(vdev).  The checks are clearly pointless and can be
removed, as the function would have crashed before reaching them if vdev
ever was NULL.

Signed-off-by: Trent Piepho <xyzzy@speakeasy.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Trent Piepho 2009-03-03 18:51:52 -03:00 committed by Mauro Carvalho Chehab
parent f985c70067
commit 428c8d1916
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/media/video/v4l2-dev.c
View File

@ -366,12 +366,11 @@ int video_register_device_index(struct video_device *vdev, int type, int nr,
/* A minor value of -1 marks this video device as never /* A minor value of -1 marks this video device as never
having been registered */ having been registered */
if (vdev) vdev->minor = -1;
vdev->minor = -1;
/* the release callback MUST be present */ /* the release callback MUST be present */
WARN_ON(!vdev || !vdev->release); WARN_ON(!vdev->release);
if (!vdev || !vdev->release) if (!vdev->release)
return -EINVAL; return -EINVAL;
/* Part 1: check device type */ /* Part 1: check device type */