FEX-Emu/linux
1
0
Fork 0
mirror of https://github.com/FEX-Emu/linux.git synced 2025-01-24 03:25:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

x86/mce: Convert threshold_bank.cpus from atomic_t to refcount_t

Browse Source 
The refcount_t type and corresponding API should be used instead
of atomic_t when the variable is used as a reference counter. This
allows to avoid accidental refcounter overflows that might lead to
use-after-free situations.

Suggested-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Hans Liljestrand <ishkamiel@gmail.com>
Reviewed-by: David Windsor <dwindsor@gmail.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Yazen Ghannam <Yazen.Ghannam@amd.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/1492695536-5947-1-git-send-email-elena.reshetova@intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
This commit is contained in:
Elena Reshetova 2017-05-19 11:39:13 +02:00 committed by Thomas Gleixner
parent 5f0744e50d
commit 473e90b2e8
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
arch/x86/include/asm/amd_nb.h
View File

@ -3,6 +3,7 @@
#include <linux/ioport.h> #include <linux/ioport.h>
#include <linux/pci.h> #include <linux/pci.h>
#include <linux/refcount.h>
struct amd_nb_bus_dev_range { struct amd_nb_bus_dev_range {
u8 bus; u8 bus;
@ -55,7 +56,7 @@ struct threshold_bank {
struct threshold_block *blocks; struct threshold_block *blocks;
/* initialized to the number of CPUs on the node sharing this bank */ /* initialized to the number of CPUs on the node sharing this bank */
atomic_t cpus; refcount_t cpus;
}; };
struct amd_northbridge { struct amd_northbridge {

6
arch/x86/kernel/cpu/mcheck/mce_amd.c
View File

@ -1202,7 +1202,7 @@ static int threshold_create_bank(unsigned int cpu, unsigned int bank)
goto out; goto out;
per_cpu(threshold_banks, cpu)[bank] = b; per_cpu(threshold_banks, cpu)[bank] = b;
atomic_inc(&b->cpus); refcount_inc(&b->cpus);
err = __threshold_add_blocks(b); err = __threshold_add_blocks(b);
@ -1225,7 +1225,7 @@ static int threshold_create_bank(unsigned int cpu, unsigned int bank)
per_cpu(threshold_banks, cpu)[bank] = b; per_cpu(threshold_banks, cpu)[bank] = b;
if (is_shared_bank(bank)) { if (is_shared_bank(bank)) {
atomic_set(&b->cpus, 1); refcount_set(&b->cpus, 1);
/* nb is already initialized, see above */ /* nb is already initialized, see above */
if (nb) { if (nb) {
@ -1289,7 +1289,7 @@ static void threshold_remove_bank(unsigned int cpu, int bank)
goto free_out; goto free_out;
if (is_shared_bank(bank)) { if (is_shared_bank(bank)) {
if (!atomic_dec_and_test(&b->cpus)) { if (!refcount_dec_and_test(&b->cpus)) {
__threshold_remove_blocks(b); __threshold_remove_blocks(b);
per_cpu(threshold_banks, cpu)[bank] = NULL; per_cpu(threshold_banks, cpu)[bank] = NULL;
return; return;