FEX-Emu/linux
1
0
Fork 0
mirror of https://github.com/FEX-Emu/linux.git synced 2025-01-13 21:02:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

staging: rtl8723au: Fix resource leak

Browse Source 
Firmware was not released properly if kmemdup fails.

Addresses-Coverity-Id: 1269118
Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Mateusz Kulikowski 2015-09-27 21:48:19 +02:00 committed by Greg Kroah-Hartman
parent 9da4aa48d0
commit 7d76173d40
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
View File

@ -249,13 +249,13 @@ int rtl8723a_FirmwareDownload(struct rtw_adapter *padapter)
goto Exit; goto Exit;
} }
firmware_buf = kmemdup(fw->data, fw->size, GFP_KERNEL); firmware_buf = kmemdup(fw->data, fw->size, GFP_KERNEL);
fw_size = fw->size;
release_firmware(fw);
if (!firmware_buf) { if (!firmware_buf) {
rtStatus = _FAIL; rtStatus = _FAIL;
goto Exit; goto Exit;
} }
buf = firmware_buf; buf = firmware_buf;
fw_size = fw->size;
release_firmware(fw);
/* To Check Fw header. Added by tynli. 2009.12.04. */ /* To Check Fw header. Added by tynli. 2009.12.04. */
pFwHdr = (struct rt_8723a_firmware_hdr *)firmware_buf; pFwHdr = (struct rt_8723a_firmware_hdr *)firmware_buf;