V4L/DVB (7903): gp8psk_power_ctrl should return negative errors

Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
This commit is contained in:
Marcin Slusarz 2008-05-11 19:53:39 -03:00 committed by Mauro Carvalho Chehab
parent 4277106b4f
commit 7fa7b8583f

View File

@ -146,24 +146,24 @@ static int gp8psk_power_ctrl(struct dvb_usb_device *d, int onoff)
if (gp_product_id == USB_PID_GENPIX_8PSK_REV_1_WARM) if (gp_product_id == USB_PID_GENPIX_8PSK_REV_1_WARM)
if (! (status & bm8pskFW_Loaded)) /* BCM4500 firmware loaded */ if (! (status & bm8pskFW_Loaded)) /* BCM4500 firmware loaded */
if(gp8psk_load_bcm4500fw(d)) if(gp8psk_load_bcm4500fw(d))
return EINVAL; return -EINVAL;
if (! (status & bmIntersilOn)) /* LNB Power */ if (! (status & bmIntersilOn)) /* LNB Power */
if (gp8psk_usb_in_op(d, START_INTERSIL, 1, 0, if (gp8psk_usb_in_op(d, START_INTERSIL, 1, 0,
&buf, 1)) &buf, 1))
return EINVAL; return -EINVAL;
/* Set DVB mode to 1 */ /* Set DVB mode to 1 */
if (gp_product_id == USB_PID_GENPIX_8PSK_REV_1_WARM) if (gp_product_id == USB_PID_GENPIX_8PSK_REV_1_WARM)
if (gp8psk_usb_out_op(d, SET_DVB_MODE, 1, 0, NULL, 0)) if (gp8psk_usb_out_op(d, SET_DVB_MODE, 1, 0, NULL, 0))
return EINVAL; return -EINVAL;
/* Abort possible TS (if previous tune crashed) */ /* Abort possible TS (if previous tune crashed) */
if (gp8psk_usb_out_op(d, ARM_TRANSFER, 0, 0, NULL, 0)) if (gp8psk_usb_out_op(d, ARM_TRANSFER, 0, 0, NULL, 0))
return EINVAL; return -EINVAL;
} else { } else {
/* Turn off LNB power */ /* Turn off LNB power */
if (gp8psk_usb_in_op(d, START_INTERSIL, 0, 0, &buf, 1)) if (gp8psk_usb_in_op(d, START_INTERSIL, 0, 0, &buf, 1))
return EINVAL; return -EINVAL;
/* Turn off 8psk power */ /* Turn off 8psk power */
if (gp8psk_usb_in_op(d, BOOT_8PSK, 0, 0, &buf, 1)) if (gp8psk_usb_in_op(d, BOOT_8PSK, 0, 0, &buf, 1))
return -EINVAL; return -EINVAL;