mirror of
https://github.com/FEX-Emu/linux.git
synced 2025-01-09 19:10:45 +00:00
s390/qeth: apply takeover changes when mode is toggled
Just as for an explicit enable/disable, toggling the takeover mode also requires that the IP addresses get updated. Otherwise all IPs that were added to the table before the mode-toggle, get registered with the old settings. Signed-off-by: Julian Wiedmann <jwi@linux.vnet.ibm.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
0f546ffcd0
commit
7fbd9493f0
@ -565,7 +565,7 @@ enum qeth_cq {
|
||||
};
|
||||
|
||||
struct qeth_ipato {
|
||||
int enabled;
|
||||
bool enabled;
|
||||
int invert4;
|
||||
int invert6;
|
||||
struct list_head entries;
|
||||
|
@ -1480,7 +1480,7 @@ static int qeth_setup_card(struct qeth_card *card)
|
||||
qeth_set_intial_options(card);
|
||||
/* IP address takeover */
|
||||
INIT_LIST_HEAD(&card->ipato.entries);
|
||||
card->ipato.enabled = 0;
|
||||
card->ipato.enabled = false;
|
||||
card->ipato.invert4 = 0;
|
||||
card->ipato.invert6 = 0;
|
||||
/* init QDIO stuff */
|
||||
|
@ -372,6 +372,7 @@ static ssize_t qeth_l3_dev_ipato_enable_store(struct device *dev,
|
||||
struct qeth_card *card = dev_get_drvdata(dev);
|
||||
struct qeth_ipaddr *addr;
|
||||
int i, rc = 0;
|
||||
bool enable;
|
||||
|
||||
if (!card)
|
||||
return -EINVAL;
|
||||
@ -384,25 +385,23 @@ static ssize_t qeth_l3_dev_ipato_enable_store(struct device *dev,
|
||||
}
|
||||
|
||||
if (sysfs_streq(buf, "toggle")) {
|
||||
card->ipato.enabled = (card->ipato.enabled)? 0 : 1;
|
||||
} else if (sysfs_streq(buf, "1")) {
|
||||
card->ipato.enabled = 1;
|
||||
hash_for_each(card->ip_htable, i, addr, hnode) {
|
||||
if ((addr->type == QETH_IP_TYPE_NORMAL) &&
|
||||
qeth_l3_is_addr_covered_by_ipato(card, addr))
|
||||
addr->set_flags |=
|
||||
QETH_IPA_SETIP_TAKEOVER_FLAG;
|
||||
}
|
||||
} else if (sysfs_streq(buf, "0")) {
|
||||
card->ipato.enabled = 0;
|
||||
hash_for_each(card->ip_htable, i, addr, hnode) {
|
||||
if (addr->set_flags &
|
||||
QETH_IPA_SETIP_TAKEOVER_FLAG)
|
||||
addr->set_flags &=
|
||||
~QETH_IPA_SETIP_TAKEOVER_FLAG;
|
||||
}
|
||||
} else
|
||||
enable = !card->ipato.enabled;
|
||||
} else if (kstrtobool(buf, &enable)) {
|
||||
rc = -EINVAL;
|
||||
goto out;
|
||||
}
|
||||
|
||||
if (card->ipato.enabled == enable)
|
||||
goto out;
|
||||
card->ipato.enabled = enable;
|
||||
|
||||
hash_for_each(card->ip_htable, i, addr, hnode) {
|
||||
if (!enable)
|
||||
addr->set_flags &= ~QETH_IPA_SETIP_TAKEOVER_FLAG;
|
||||
else if (addr->type == QETH_IP_TYPE_NORMAL &&
|
||||
qeth_l3_is_addr_covered_by_ipato(card, addr))
|
||||
addr->set_flags |= QETH_IPA_SETIP_TAKEOVER_FLAG;
|
||||
}
|
||||
out:
|
||||
mutex_unlock(&card->conf_mutex);
|
||||
return rc ? rc : count;
|
||||
|
Loading…
Reference in New Issue
Block a user