mirror of
https://github.com/FEX-Emu/linux.git
synced 2024-12-17 14:30:00 +00:00
flow_offload: fix block stats
With the introduction of flow_stats_update(), drivers now update the stats
fields of the passed tc_cls_flower_offload struct, rather than call
tcf_exts_stats_update() directly to update the stats of offloaded TC
flower rules. However, if multiple qdiscs are registered to a TC shared
block and a flower rule is applied, then, when getting stats for the rule,
multiple callbacks may be made.
Take this into consideration by modifying flow_stats_update to gather the
stats from all callbacks. Currently, the values in tc_cls_flower_offload
only account for the last stats callback in the list.
Fixes: 3b1903ef97
("flow_offload: add statistics retrieval infrastructure and use it")
Signed-off-by: John Hurley <john.hurley@netronome.com>
Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
1f15bb4f39
commit
9f9dc493f7
@ -195,9 +195,9 @@ struct flow_stats {
|
||||
static inline void flow_stats_update(struct flow_stats *flow_stats,
|
||||
u64 bytes, u64 pkts, u64 lastused)
|
||||
{
|
||||
flow_stats->pkts = pkts;
|
||||
flow_stats->bytes = bytes;
|
||||
flow_stats->lastused = lastused;
|
||||
flow_stats->pkts += pkts;
|
||||
flow_stats->bytes += bytes;
|
||||
flow_stats->lastused = max_t(u64, flow_stats->lastused, lastused);
|
||||
}
|
||||
|
||||
#endif /* _NET_FLOW_OFFLOAD_H */
|
||||
|
Loading…
Reference in New Issue
Block a user