FEX-Emu/linux
1
0
Fork 0
mirror of https://github.com/FEX-Emu/linux.git synced 2025-01-10 11:30:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

staging: lustre: fix framework.c issues found by Klocwork Insight tool

Browse Source 
The functions sfw_test_buffers() and sfw_unload_test() from LNet
selftest both assume sfw_test_instance_t being passed in is never
null. This is corrected here.

Signed-off-by: Dmitry Eremin <dmitry.eremin@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629
Reviewed-on: http://review.whamcloud.com/9386
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: Isaac Huang <he.huang@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dmitry Eremin 2016-03-02 17:01:58 -05:00 committed by Greg Kroah-Hartman
parent 95193044c9
commit add69d2248
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/staging/lustre/lnet/selftest/framework.c
View File

@ -541,10 +541,16 @@ sfw_test_rpc_fini(srpc_client_rpc_t *rpc)
static inline int
sfw_test_buffers(sfw_test_instance_t *tsi)
{
struct sfw_test_case *tsc = sfw_find_test_case(tsi->tsi_service);
struct srpc_service *svc = tsc->tsc_srv_service;
struct sfw_test_case *tsc;
struct srpc_service *svc;
int nbuf;
LASSERT(tsi);
tsc = sfw_find_test_case(tsi->tsi_service);
LASSERT(tsc);
svc = tsc->tsc_srv_service;
LASSERT(svc);
nbuf = min(svc->sv_wi_total, tsi->tsi_loop) / svc->sv_ncpts;
return max(SFW_TEST_WI_MIN, nbuf + SFW_TEST_WI_EXTRA);
}
@ -591,8 +597,10 @@ sfw_load_test(struct sfw_test_instance *tsi)
static void
sfw_unload_test(struct sfw_test_instance *tsi)
{
struct sfw_test_case *tsc = sfw_find_test_case(tsi->tsi_service);
struct sfw_test_case *tsc;
LASSERT(tsi);
tsc = sfw_find_test_case(tsi->tsi_service);
LASSERT(tsc);
if (tsi->tsi_is_client)