FEX-Emu/linux
1
0
Fork 0
mirror of https://github.com/FEX-Emu/linux.git synced 2024-12-28 12:25:31 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

can: c_can_pci: fix null-pointer-deref in c_can_start() - set device pointer

Browse Source 
The priv->device pointer for c_can_pci is never set, but it is used
without a NULL check in c_can_start(). Setting it in c_can_pci_probe()
like c_can_plat_probe() prevents c_can_pci.ko from crashing, with and
without CONFIG_PM.

This might also cause the pm_runtime_*() functions in c_can.c to
actually be executed for c_can_pci devices - they are the only other
place where priv->device is used, but they all contain a null check.

Signed-off-by: Einar Jón <tolvupostur@gmail.com>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
This commit is contained in:
Einar Jón 2016-08-12 13:50:41 +02:00 committed by Marc Kleine-Budde
parent 93b43fd137
commit c97c52be78
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/net/can/c_can/c_can_pci.c
View File

@ -161,6 +161,7 @@ static int c_can_pci_probe(struct pci_dev *pdev,
dev->irq = pdev->irq; dev->irq = pdev->irq;
priv->base = addr; priv->base = addr;
priv->device = &pdev->dev;
if (!c_can_pci_data->freq) { if (!c_can_pci_data->freq) {
dev_err(&pdev->dev, "no clock frequency defined\n"); dev_err(&pdev->dev, "no clock frequency defined\n");