FEX-Emu/linux
1
0
Fork 0
mirror of https://github.com/FEX-Emu/linux.git synced 2024-12-21 08:53:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ALSA: mpu401: Adjust four checks for null pointers

Browse Source 
The script “checkpatch.pl” pointed information out like the following.

Comparison to NULL could be written !…

Thus fix the affected source code places.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Markus Elfring 2017-08-12 20:50:16 +02:00 committed by Takashi Iwai
parent ec1f43c83b
commit f1a77dc171
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sound/drivers/mpu401/mpu401_uart.c
View File

@ -136,7 +136,7 @@ irqreturn_t snd_mpu401_uart_interrupt(int irq, void *dev_id)
{ {
struct snd_mpu401 *mpu = dev_id; struct snd_mpu401 *mpu = dev_id;
if (mpu == NULL) if (!mpu)
return IRQ_NONE; return IRQ_NONE;
_snd_mpu401_uart_interrupt(mpu); _snd_mpu401_uart_interrupt(mpu);
return IRQ_HANDLED; return IRQ_HANDLED;
@ -157,7 +157,7 @@ irqreturn_t snd_mpu401_uart_interrupt_tx(int irq, void *dev_id)
{ {
struct snd_mpu401 *mpu = dev_id; struct snd_mpu401 *mpu = dev_id;
if (mpu == NULL) if (!mpu)
return IRQ_NONE; return IRQ_NONE;
uart_interrupt_tx(mpu); uart_interrupt_tx(mpu);
return IRQ_HANDLED; return IRQ_HANDLED;
@ -544,7 +544,7 @@ int snd_mpu401_uart_new(struct snd_card *card, int device,
out_enable, in_enable, &rmidi)) < 0) out_enable, in_enable, &rmidi)) < 0)
return err; return err;
mpu = kzalloc(sizeof(*mpu), GFP_KERNEL); mpu = kzalloc(sizeof(*mpu), GFP_KERNEL);
if (mpu == NULL) { if (!mpu) {
err = -ENOMEM; err = -ENOMEM;
goto free_device; goto free_device;
} }
@ -558,7 +558,7 @@ int snd_mpu401_uart_new(struct snd_card *card, int device,
if (! (info_flags & MPU401_INFO_INTEGRATED)) { if (! (info_flags & MPU401_INFO_INTEGRATED)) {
int res_size = hardware == MPU401_HW_PC98II ? 4 : 2; int res_size = hardware == MPU401_HW_PC98II ? 4 : 2;
mpu->res = request_region(port, res_size, "MPU401 UART"); mpu->res = request_region(port, res_size, "MPU401 UART");
if (mpu->res == NULL) { if (!mpu->res) {
snd_printk(KERN_ERR "mpu401_uart: " snd_printk(KERN_ERR "mpu401_uart: "
"unable to grab port 0x%lx size %d\n", "unable to grab port 0x%lx size %d\n",
port, res_size); port, res_size);