staging:iio:accel:adis16203 move to irqchip based trigger handling.

Untested.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Jonathan Cameron 2011-05-18 14:41:33 +01:00 committed by Greg Kroah-Hartman
parent 05c2858d2f
commit f3dadc1dd2
3 changed files with 42 additions and 65 deletions

View File

@ -59,9 +59,6 @@
/**
* struct adis16203_state - device instance specific data
* @us: actual spi_device
* @work_trigger_to_ring: bh for triggered event handling
* @inter: used to check if new interrupt has been triggered
* @last_timestamp: passing timestamp from th to bh of interrupt handler
* @indio_dev: industrial I/O device structure
* @trig: data ready trigger registered with iio
* @tx: transmit buffer
@ -70,8 +67,6 @@
**/
struct adis16203_state {
struct spi_device *us;
struct work_struct work_trigger_to_ring;
s64 last_timestamp;
struct iio_dev *indio_dev;
struct iio_trigger *trig;
u8 *tx;

View File

@ -57,17 +57,6 @@ static struct attribute_group adis16203_scan_el_group = {
.name = "scan_elements",
};
/**
* adis16203_poll_func_th() top half interrupt handler called by trigger
* @private_data: iio_dev
**/
static void adis16203_poll_func_th(struct iio_dev *indio_dev, s64 timestamp)
{
struct adis16203_state *st = iio_dev_get_devdata(indio_dev);
st->last_timestamp = timestamp;
schedule_work(&st->work_trigger_to_ring);
}
/**
* adis16203_read_ring_data() read data registers which will be placed into ring
* @dev: device associated with child of actual device (iio_dev or iio_trig)
@ -115,12 +104,12 @@ static int adis16203_read_ring_data(struct device *dev, u8 *rx)
/* Whilst this makes a lot of calls to iio_sw_ring functions - it is to device
* specific to be rolled into the core.
*/
static void adis16203_trigger_bh_to_ring(struct work_struct *work_s)
static irqreturn_t adis16203_trigger_handler(int irq, void *p)
{
struct adis16203_state *st
= container_of(work_s, struct adis16203_state,
work_trigger_to_ring);
struct iio_ring_buffer *ring = st->indio_dev->ring;
struct iio_poll_func *pf = p;
struct iio_dev *indio_dev = pf->private_data;
struct adis16203_state *st = iio_dev_get_devdata(indio_dev);
struct iio_ring_buffer *ring = indio_dev->ring;
int i = 0;
s16 *data;
@ -129,7 +118,7 @@ static void adis16203_trigger_bh_to_ring(struct work_struct *work_s)
data = kmalloc(datasize, GFP_KERNEL);
if (data == NULL) {
dev_err(&st->us->dev, "memory alloc failed in ring bh");
return;
return -ENOMEM;
}
if (ring->scan_count)
@ -140,20 +129,21 @@ static void adis16203_trigger_bh_to_ring(struct work_struct *work_s)
/* Guaranteed to be aligned with 8 byte boundary */
if (ring->scan_timestamp)
*((s64 *)(data + ((i + 3)/4)*4)) = st->last_timestamp;
*((s64 *)(data + ((i + 3)/4)*4)) = pf->timestamp;
ring->access.store_to(ring,
(u8 *)data,
st->last_timestamp);
pf->timestamp);
iio_trigger_notify_done(st->indio_dev->trig);
kfree(data);
return;
return IRQ_HANDLED;
}
void adis16203_unconfigure_ring(struct iio_dev *indio_dev)
{
kfree(indio_dev->pollfunc->name);
kfree(indio_dev->pollfunc);
iio_sw_rb_free(indio_dev->ring);
}
@ -161,9 +151,7 @@ void adis16203_unconfigure_ring(struct iio_dev *indio_dev)
int adis16203_configure_ring(struct iio_dev *indio_dev)
{
int ret = 0;
struct adis16203_state *st = indio_dev->dev_data;
struct iio_ring_buffer *ring;
INIT_WORK(&st->work_trigger_to_ring, adis16203_trigger_bh_to_ring);
ring = iio_sw_rb_allocate(indio_dev);
if (!ring) {
@ -188,13 +176,26 @@ int adis16203_configure_ring(struct iio_dev *indio_dev)
iio_scan_mask_set(ring, iio_scan_el_incli_x.number);
iio_scan_mask_set(ring, iio_scan_el_incli_y.number);
ret = iio_alloc_pollfunc(indio_dev, NULL, &adis16203_poll_func_th);
if (ret)
indio_dev->pollfunc = kzalloc(sizeof(*indio_dev->pollfunc), GFP_KERNEL);
if (indio_dev->pollfunc == NULL) {
ret = -ENOMEM;
goto error_iio_sw_rb_free;
}
indio_dev->pollfunc->private_data = indio_dev;
indio_dev->pollfunc->h = &iio_pollfunc_store_time;
indio_dev->pollfunc->thread = &adis16203_trigger_handler;
indio_dev->pollfunc->type = IRQF_ONESHOT;
indio_dev->pollfunc->name =
kasprintf(GFP_KERNEL, "adis16203_consumer%d", indio_dev->id);
if (indio_dev->pollfunc->name == NULL) {
ret = -ENOMEM;
goto error_free_poll_func;
}
indio_dev->modes |= INDIO_RING_TRIGGERED;
return 0;
error_free_poll_func:
kfree(indio_dev->pollfunc);
error_iio_sw_rb_free:
iio_sw_rb_free(indio_dev->ring);
return ret;

View File

@ -12,16 +12,6 @@
#include "../trigger.h"
#include "adis16203.h"
/**
* adis16203_data_rdy_trig_poll() the event handler for the data rdy trig
**/
static irqreturn_t adis16203_data_rdy_trig_poll(int irq, void *private)
{
disable_irq_nosync(irq);
iio_trigger_poll(private, iio_get_time_ns());
return IRQ_HANDLED;
}
static DEVICE_ATTR(name, S_IRUGO, iio_trigger_read_name, NULL);
static struct attribute *adis16203_trigger_attrs[] = {
@ -46,63 +36,54 @@ static int adis16203_data_rdy_trigger_set_state(struct iio_trigger *trig,
return adis16203_set_irq(&st->indio_dev->dev, state);
}
/**
* adis16203_trig_try_reen() try renabling irq for data rdy trigger
* @trig: the datardy trigger
**/
static int adis16203_trig_try_reen(struct iio_trigger *trig)
{
struct adis16203_state *st = trig->private_data;
enable_irq(st->us->irq);
return 0;
}
int adis16203_probe_trigger(struct iio_dev *indio_dev)
{
int ret;
struct adis16203_state *st = indio_dev->dev_data;
char *name;
st->trig = iio_allocate_trigger();
if (st->trig == NULL) {
name = kasprintf(GFP_KERNEL,
"adis16203-dev%d",
indio_dev->id);
if (name == NULL) {
ret = -ENOMEM;
goto error_ret;
}
st->trig = iio_allocate_trigger_named(name);
if (st->trig == NULL) {
ret = -ENOMEM;
goto error_free_name;
}
ret = request_irq(st->us->irq,
adis16203_data_rdy_trig_poll,
&iio_trigger_generic_data_rdy_poll,
IRQF_TRIGGER_RISING,
"adis16203",
st->trig);
if (ret)
goto error_free_trig;
st->trig->name = kasprintf(GFP_KERNEL,
"adis16203-dev%d",
indio_dev->id);
if (!st->trig->name) {
ret = -ENOMEM;
goto error_free_irq;
}
st->trig->dev.parent = &st->us->dev;
st->trig->owner = THIS_MODULE;
st->trig->private_data = st;
st->trig->set_trigger_state = &adis16203_data_rdy_trigger_set_state;
st->trig->try_reenable = &adis16203_trig_try_reen;
st->trig->control_attrs = &adis16203_trigger_attr_group;
ret = iio_trigger_register(st->trig);
/* select default trigger */
indio_dev->trig = st->trig;
if (ret)
goto error_free_trig_name;
goto error_free_irq;
return 0;
error_free_trig_name:
kfree(st->trig->name);
error_free_irq:
free_irq(st->us->irq, st->trig);
error_free_trig:
iio_free_trigger(st->trig);
error_free_name:
kfree(name);
error_ret:
return ret;
}