Nick Piggin 54566b2c15 fs: symlink write_begin allocation context fix ... With the write_begin/write_end aops, page_symlink was broken because it could no longer pass a GFP_NOFS type mask into the point where the allocations happened. They are done in write_begin, which would always assume that the filesystem can be entered from reclaim. This bug could cause filesystem deadlocks. The funny thing with having a gfp_t mask there is that it doesn't really allow the caller to arbitrarily tinker with the context in which it can be called. It couldn't ever be GFP_ATOMIC, for example, because it needs to take the page lock. The only thing any callers care about is __GFP_FS anyway, so turn that into a single flag. Add a new flag for write_begin, AOP_FLAG_NOFS. Filesystems can now act on this flag in their write_begin function. Change __grab_cache_page to accept a nofs argument as well, to honour that flag (while we're there, change the name to grab_cache_page_write_begin which is more instructive and does away with random leading underscores). This is really a more flexible way to go in the end anyway -- if a filesystem happens to want any extra allocations aside from the pagecache ones in ints write_begin function, it may now use GFP_KERNEL (rather than GFP_NOFS) for common case allocations (eg. ocfs2_alloc_write_ctxt, for a random example). [kosaki.motohiro@jp.fujitsu.com: fix ubifs] [kosaki.motohiro@jp.fujitsu.com: fix fuse] Signed-off-by: Nick Piggin <npiggin@suse.de> Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Cc: <stable@kernel.org> [2.6.28.x] Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> [ Cleaned up the calling convention: just pass in the AOP flags untouched to the grab_cache_page_write_begin() function. That just simplifies everybody, and may even allow future expansion of the logic. - Linus ] Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2009-01-04 13:33:20 -08:00
..
afs_cm.h
afs_fs.h
afs_vl.h
afs.h
cache.c
cache.h
callback.c
cell.c
cmservice.c
dir.c	[PATCH] fix ->llseek for more directories	2008-10-23 05:13:21 -04:00
file.c	afs: convert to new aops	2008-10-16 11:21:48 -07:00
flock.c
fsclient.c
inode.c
internal.h	afs: convert to new aops	2008-10-16 11:21:48 -07:00
main.c
Makefile
misc.c
mntpt.c
netdevices.c
proc.c	fs: replace NIPQUAD()	2008-10-31 00:56:28 -07:00
rxrpc.c
security.c
server.c	fs: replace NIPQUAD()	2008-10-31 00:56:28 -07:00
super.c	vfs: Use const for kernel parser table	2008-10-13 10:10:37 -07:00
vlclient.c
vlocation.c
vnode.c
volume.c
write.c	fs: symlink write_begin allocation context fix	2009-01-04 13:33:20 -08:00