linux/net/ieee80211
John W. Linville 04045f98e0 [IEEE80211]: avoid integer underflow for runt rx frames
Reported by Chris Evans <scarybeasts@gmail.com>:

> The summary is that an evil 80211 frame can crash out a victim's
> machine. It only applies to drivers using the 80211 wireless code, and
> only then to certain drivers (and even then depends on a card's
> firmware not dropping a dubious packet). I must confess I'm not
> keeping track of Linux wireless support, and the different protocol
> stacks etc.
>
> Details are as follows:
>
> ieee80211_rx() does not explicitly check that "skb->len >= hdrlen".
> There are other skb->len checks, but not enough to prevent a subtle
> off-by-two error if the frame has the IEEE80211_STYPE_QOS_DATA flag
> set.
>
> This leads to integer underflow and crash here:
>
> if (frag != 0)
>    flen -= hdrlen;
>
> (flen is subsequently used as a memcpy length parameter).

How about this?

Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2007-10-01 21:03:54 -07:00
..
softmac [PATCH] softmac: Fix inability to associate with WEP networks 2007-09-21 11:26:33 -04:00
ieee80211_crypt_ccmp.c [PATCH] ieee80211-crypt: Make some TKIP and CCMP error logging conditional 2007-04-28 11:01:04 -04:00
ieee80211_crypt_tkip.c [PATCH] ieee80211-crypt: Make some TKIP and CCMP error logging conditional 2007-04-28 11:01:04 -04:00
ieee80211_crypt_wep.c [PATCH] Update my email address from jkmaline@cc.hut.fi to j@w1.fi 2007-04-28 11:01:01 -04:00
ieee80211_crypt.c [PATCH] Update my email address from jkmaline@cc.hut.fi to j@w1.fi 2007-04-28 11:01:01 -04:00
ieee80211_geo.c [PATCH] ieee80211: add ieee80211_channel_to_freq 2007-05-08 11:51:59 -04:00
ieee80211_module.c [PATCH] ieee80211: fix incomplete error message 2007-05-29 11:16:34 -04:00
ieee80211_rx.c [IEEE80211]: avoid integer underflow for runt rx frames 2007-10-01 21:03:54 -07:00
ieee80211_tx.c [SK_BUFF]: Introduce skb_copy_from_linear_data{_offset} 2007-04-25 22:28:23 -07:00
ieee80211_wx.c [PATCH] softmac: Channel is listed twice in scan output 2007-07-17 21:56:17 -04:00
Kconfig [WIRELESS]: Refactor wireless Kconfig. 2007-04-25 22:29:40 -07:00
Makefile [PATCH] softmac: fix Makefiles 2006-03-22 22:16:51 -05:00