linux/sound/firewire
Takashi Sakamoto e4f34cf6d5 Revert "ALSA: firewire-lib: change structure member with proper type"
This reverts commit 6b7e95d133. This commit
is based on a concern about value of the given parameter. It's expected
to be ORed value with some enumeration-constants, thus often it can not be
one of the enumeration-constants. I understood that this is out of
specification and causes implementation-dependent issues.

In C language specification, enumerated type can be interpreted as an
integer type, in which all of enumeration-constants in corresponding
enumerator-list can be stored. Implementations can select one of char,
signed int and unsigned int as its type, and this selection is
implementation-dependent.

In GCC, a signed integer is selected when at least one of
enumeration-constants has negative value, else an unsigned integer is
selected. This behaviour can be switched by -fshort-enums to short type.
Anyway, the type can be decided after scanning all of
enumeration-constants.

Totally, there's no rules to constrain the value of enumerated type to
be one of enumeration-constants. In short, in enumerated type, decision
of actual type for the type is the most important and
enumeration-constants are just used for the decision, thus it's permitted
to have an integer value in a range of enumeration-constants. In our case,
actual type for the type is currently deterministic to be either char or
unsigned int. Under GCC, it's unsigned int.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2017-01-05 08:39:47 +01:00
..
bebob ALSA: bebob: compare whole string for model name so that readers are not confused 2016-11-18 09:22:47 +01:00
dice ALSA: firewire: constify snd_pcm_ops structures 2016-09-02 11:50:11 +02:00
digi00x ALSA: firewire: constify snd_pcm_ops structures 2016-09-02 11:50:11 +02:00
fireworks ALSA: fireworks: fix asymmetric API call at unit removal 2017-01-03 11:36:13 +01:00
oxfw ALSA: firewire: constify snd_pcm_ops structures 2016-09-02 11:50:11 +02:00
tascam ALSA: firewire-tascam: Fix to handle error from initialization of stream data 2017-01-03 11:36:34 +01:00
amdtp-am824.c ALSA: firewire-lib: process_rx_data_blocks() can be static 2015-09-29 16:52:52 +02:00
amdtp-am824.h ALSA: firewire-lib: complete AM824 data block processing layer 2015-09-29 12:51:20 +02:00
amdtp-stream-trace.h ALSA: firewire-lib: change a member of event structure to suppress sparse wanings to bool type 2016-05-18 16:32:09 +02:00
amdtp-stream.c Revert "ALSA: firewire-lib: change structure member with proper type" 2017-01-05 08:39:47 +01:00
amdtp-stream.h Revert "ALSA: firewire-lib: change structure member with proper type" 2017-01-05 08:39:47 +01:00
cmp.c
cmp.h
fcp.c ALSA: firewire-lib: rename 'amdtp' to 'amdtp-stream' to prepare for functional separation 2015-09-29 12:47:11 +02:00
fcp.h
isight.c
iso-resources.c ALSA: firewire-lib: leave unit reference counting completely 2015-03-10 15:27:19 +01:00
iso-resources.h
Kconfig ALSA: firewire-tascam: add Kconfig entry for TASCAM FW-1804 2016-03-28 09:39:41 +02:00
lib.c ktime: Cleanup ktime_set() usage 2016-12-25 17:21:22 +01:00
lib.h ALSA: firewire-lib: add new function to schedule a work for sound card registration 2016-03-31 15:36:18 +02:00
Makefile ALSA: firewire-lib: add tracepoints to dump a part of isochronous packet data 2016-05-09 15:18:25 +02:00
packets-buffer.c
packets-buffer.h