mirror of
https://github.com/FEX-Emu/linux.git
synced 2024-12-23 09:56:00 +00:00
3f94009816
v2: gracefully handle the case where some dentry pointers end up NULL
and be more dilligent about zeroing out dentry pointers
We currently have a problem that SELinux policy is being enforced when
creating debugfs files. If a debugfs file is created as a side effect of
doing some syscall, then that creation can fail if the SELinux policy
for that process prevents it.
This seems wrong. We don't do that for files under /proc, for instance,
so Bruce has proposed a patch to fix that.
While discussing that patch however, Greg K.H. stated:
"No kernel code should care / fail if a debugfs function fails, so
please fix up the sunrpc code first."
This patch converts all of the sunrpc debugfs setup code to be void
return functins, and the callers to not look for errors from those
functions.
This should allow rpc_clnt and rpc_xprt creation to work, even if the
kernel fails to create debugfs files for some reason.
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: "J. Bruce Fields" <bfields@fieldses.org>
Signed-off-by: Jeff Layton <jeff.layton@primarydata.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
137 lines
2.6 KiB
C
137 lines
2.6 KiB
C
/*
|
|
* linux/net/sunrpc/sunrpc_syms.c
|
|
*
|
|
* Symbols exported by the sunrpc module.
|
|
*
|
|
* Copyright (C) 1997 Olaf Kirch <okir@monad.swb.de>
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/uio.h>
|
|
#include <linux/unistd.h>
|
|
#include <linux/init.h>
|
|
|
|
#include <linux/sunrpc/sched.h>
|
|
#include <linux/sunrpc/clnt.h>
|
|
#include <linux/sunrpc/svc.h>
|
|
#include <linux/sunrpc/svcsock.h>
|
|
#include <linux/sunrpc/auth.h>
|
|
#include <linux/workqueue.h>
|
|
#include <linux/sunrpc/rpc_pipe_fs.h>
|
|
#include <linux/sunrpc/xprtsock.h>
|
|
|
|
#include "netns.h"
|
|
|
|
int sunrpc_net_id;
|
|
EXPORT_SYMBOL_GPL(sunrpc_net_id);
|
|
|
|
static __net_init int sunrpc_init_net(struct net *net)
|
|
{
|
|
int err;
|
|
struct sunrpc_net *sn = net_generic(net, sunrpc_net_id);
|
|
|
|
err = rpc_proc_init(net);
|
|
if (err)
|
|
goto err_proc;
|
|
|
|
err = ip_map_cache_create(net);
|
|
if (err)
|
|
goto err_ipmap;
|
|
|
|
err = unix_gid_cache_create(net);
|
|
if (err)
|
|
goto err_unixgid;
|
|
|
|
err = rpc_pipefs_init_net(net);
|
|
if (err)
|
|
goto err_pipefs;
|
|
|
|
INIT_LIST_HEAD(&sn->all_clients);
|
|
spin_lock_init(&sn->rpc_client_lock);
|
|
spin_lock_init(&sn->rpcb_clnt_lock);
|
|
return 0;
|
|
|
|
err_pipefs:
|
|
unix_gid_cache_destroy(net);
|
|
err_unixgid:
|
|
ip_map_cache_destroy(net);
|
|
err_ipmap:
|
|
rpc_proc_exit(net);
|
|
err_proc:
|
|
return err;
|
|
}
|
|
|
|
static __net_exit void sunrpc_exit_net(struct net *net)
|
|
{
|
|
rpc_pipefs_exit_net(net);
|
|
unix_gid_cache_destroy(net);
|
|
ip_map_cache_destroy(net);
|
|
rpc_proc_exit(net);
|
|
}
|
|
|
|
static struct pernet_operations sunrpc_net_ops = {
|
|
.init = sunrpc_init_net,
|
|
.exit = sunrpc_exit_net,
|
|
.id = &sunrpc_net_id,
|
|
.size = sizeof(struct sunrpc_net),
|
|
};
|
|
|
|
static int __init
|
|
init_sunrpc(void)
|
|
{
|
|
int err = rpc_init_mempool();
|
|
if (err)
|
|
goto out;
|
|
err = rpcauth_init_module();
|
|
if (err)
|
|
goto out2;
|
|
|
|
cache_initialize();
|
|
|
|
err = register_pernet_subsys(&sunrpc_net_ops);
|
|
if (err)
|
|
goto out3;
|
|
|
|
err = register_rpc_pipefs();
|
|
if (err)
|
|
goto out4;
|
|
|
|
sunrpc_debugfs_init();
|
|
#if IS_ENABLED(CONFIG_SUNRPC_DEBUG)
|
|
rpc_register_sysctl();
|
|
#endif
|
|
svc_init_xprt_sock(); /* svc sock transport */
|
|
init_socket_xprt(); /* clnt sock transport */
|
|
return 0;
|
|
|
|
out4:
|
|
unregister_pernet_subsys(&sunrpc_net_ops);
|
|
out3:
|
|
rpcauth_remove_module();
|
|
out2:
|
|
rpc_destroy_mempool();
|
|
out:
|
|
return err;
|
|
}
|
|
|
|
static void __exit
|
|
cleanup_sunrpc(void)
|
|
{
|
|
rpcauth_remove_module();
|
|
cleanup_socket_xprt();
|
|
svc_cleanup_xprt_sock();
|
|
sunrpc_debugfs_exit();
|
|
unregister_rpc_pipefs();
|
|
rpc_destroy_mempool();
|
|
unregister_pernet_subsys(&sunrpc_net_ops);
|
|
#if IS_ENABLED(CONFIG_SUNRPC_DEBUG)
|
|
rpc_unregister_sysctl();
|
|
#endif
|
|
rcu_barrier(); /* Wait for completion of call_rcu()'s */
|
|
}
|
|
MODULE_LICENSE("GPL");
|
|
fs_initcall(init_sunrpc); /* Ensure we're initialised before nfs */
|
|
module_exit(cleanup_sunrpc);
|