Sasha Levin
105d1b4253
fsnotify: don't put user context if it was never assigned
...
On some failure paths we may attempt to free user context even if it
wasn't assigned yet. This will cause a NULL ptr deref and a kernel BUG.
The path I was looking at is in inotify_new_group():
oevent = kmalloc(sizeof(struct inotify_event_info), GFP_KERNEL);
if (unlikely(!oevent)) {
fsnotify_destroy_group(group);
return ERR_PTR(-ENOMEM);
}
fsnotify_destroy_group() would get called here, but
group->inotify_data.user is only getting assigned later:
group->inotify_data.user = get_current_user();
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: John McCutchan <john@johnmccutchan.com>
Cc: Robert Love <rlove@rlove.org>
Cc: Eric Paris <eparis@parisplace.org>
Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-10-09 22:25:45 -04:00
..
2014-06-12 10:30:18 -07:00
2014-08-08 15:57:24 -07:00
2014-06-12 10:30:18 -07:00
2014-07-29 10:14:36 -07:00
2014-08-08 15:57:19 -07:00
2014-08-08 15:57:20 -07:00
2014-08-08 15:57:24 -07:00
2014-10-07 21:16:26 -04:00
2014-09-26 08:10:35 -07:00
2014-08-13 17:43:29 -06:00
2014-10-02 14:17:41 -05:00
2014-08-08 15:57:20 -07:00
2014-06-04 16:53:53 -07:00
2014-08-08 15:57:25 -07:00
2014-07-09 16:58:21 -07:00
2014-06-06 16:08:14 -07:00
2014-08-08 15:57:27 -07:00
2014-05-06 17:38:00 -04:00
2014-06-04 16:54:14 -07:00
2014-08-08 15:57:18 -07:00
2014-08-08 15:57:24 -07:00
2014-06-04 16:54:14 -07:00
2014-07-15 22:40:22 +02:00
2014-08-19 23:16:51 +02:00
2014-09-03 09:37:30 -04:00
2014-10-07 11:54:41 -07:00
2014-06-12 10:30:18 -07:00
2014-04-04 15:39:39 -07:00
2014-09-17 22:41:40 +01:00
2014-09-26 21:16:51 -04:00
2014-09-12 20:58:55 +01:00
2014-05-06 17:38:00 -04:00
2014-06-12 10:30:18 -07:00
2014-08-07 14:40:09 -04:00
2014-08-08 15:57:22 -07:00
2014-06-04 16:54:11 -07:00
2014-08-19 18:29:30 +02:00
2014-05-21 10:26:13 +02:00
2014-08-28 22:22:29 -04:00
2014-08-08 18:13:21 -07:00
2014-06-12 10:30:18 -07:00
2014-07-21 10:07:25 -07:00
2014-10-08 12:51:44 -04:00
2014-08-06 18:01:12 -07:00
2014-08-08 15:57:20 -07:00
2014-06-04 16:54:21 -07:00
2014-10-08 12:51:44 -04:00
2014-09-17 16:33:11 -04:00
2014-10-08 12:51:44 -04:00
2014-09-26 08:10:34 -07:00
2014-10-09 22:25:45 -04:00
2014-08-06 18:01:12 -07:00
2014-10-02 16:28:44 -07:00
2014-08-08 15:57:25 -07:00
2014-03-13 10:14:33 -04:00
2014-09-26 08:10:35 -07:00
2014-08-08 15:57:25 -07:00
2014-03-13 10:14:33 -04:00
2014-08-08 15:57:26 -07:00
2014-07-15 22:40:23 +02:00
2014-08-08 15:57:18 -07:00
2014-08-13 17:45:40 -06:00
2014-08-08 15:57:25 -07:00
2014-08-06 18:01:13 -07:00
2014-06-03 08:11:18 -07:00
2014-05-06 17:38:00 -04:00
2014-07-31 15:52:51 +03:00
2014-09-04 21:37:41 +02:00
2014-09-26 21:17:52 -04:00
2014-09-02 12:12:53 +10:00
2014-09-04 16:54:47 -04:00
2014-03-27 09:52:54 -07:00
2014-06-10 13:57:22 -07:00
2014-08-07 14:40:09 -04:00
2014-06-05 08:05:29 -07:00
2014-06-04 16:54:21 -07:00
2014-04-03 16:21:16 -07:00
2014-06-12 10:30:18 -07:00
2014-09-22 08:41:16 -07:00
2014-03-04 08:05:21 +00:00
2014-07-11 13:53:04 +03:00
2014-04-22 08:23:58 -04:00
2014-07-23 15:10:54 -07:00
2014-09-27 15:59:39 -04:00
2014-09-26 21:16:51 -04:00
2014-06-06 16:08:16 -07:00
2014-09-10 15:42:12 -07:00
2014-08-08 15:57:23 -07:00
2014-08-08 15:57:31 -07:00
2014-06-12 10:30:18 -07:00
2014-05-06 17:31:10 -04:00
2014-04-03 16:21:05 -07:00
2014-08-07 14:40:09 -04:00
2014-07-16 15:10:39 +02:00
2014-08-08 15:57:31 -07:00
2014-08-07 14:40:09 -04:00
2014-09-17 16:33:11 -04:00
2014-06-04 16:53:55 -07:00
2014-08-22 09:58:22 -04:00
2014-08-07 14:40:08 -04:00
2014-06-25 22:08:29 -04:00
2014-08-07 14:40:09 -04:00
2014-06-04 16:54:02 -07:00
2014-09-16 07:44:54 -07:00
2014-08-30 18:32:05 -04:00
2014-08-01 02:36:04 -04:00
2014-05-06 17:39:42 -04:00
2014-08-30 18:31:41 -04:00
2014-04-01 23:19:08 -04:00
2014-05-06 13:58:42 -04:00
2014-07-29 18:08:50 -07:00
2014-05-06 17:37:55 -04:00
2014-06-04 16:53:52 -07:00
2014-07-03 09:21:54 -07:00
2014-06-12 00:28:09 -04:00
2014-08-26 09:35:56 +02:00
2014-08-13 17:45:40 -06:00
2014-09-05 08:16:21 -07:00
2014-08-27 11:17:48 +02:00
2014-07-23 15:10:55 -07:00