Jayachandran C 12fc1d7b4b [PATCH] IPMI: fix issues reported by Coverity in ipmi_msghandler.c
While looking to the report by Coverity in ipmi, I came across the
following issue:

The IPMI message handler relies on two defines which are the same -one in
include/linux/ipmi.h
#define IPMI_NUM_CHANNELS 0x10
and one in drivers/char/ipmi/ipmi_msghandler.
#define IPMI_MAX_CHANNELS       16
These are used interchangeably in ipmi_msghandler.c, but since the array
addr->channels[] is of size IPMI_MAX_CHANNELS, I have made a patch that
uses IPMI_MAX_CHANNELS for all the checks for the array index.

NOTE: You could probably remove the line that defines IPMI_NUM_CHANNELS
from ipmi.h, or move IPMI_MAX_CHANNELS to ipmi.h

Signed-off-by: Jayachandran C. <c.jayachandran@gmail.com>
Cc: Corey Minyard <minyard@acm.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2006-02-03 08:32:11 -08:00
..
2006-01-19 16:19:35 -08:00
2006-02-03 08:32:10 -08:00
2006-01-10 08:01:59 -08:00
2006-02-03 08:32:04 -08:00
2006-01-01 22:21:50 +01:00
2006-01-10 08:01:59 -08:00
2006-02-03 08:32:09 -08:00
2005-12-10 00:20:25 -05:00
2006-01-10 08:01:59 -08:00
2006-02-03 08:32:10 -08:00
2006-01-10 08:01:59 -08:00
2006-02-01 08:53:24 -08:00
2005-10-29 19:30:42 +01:00
2005-10-29 19:30:42 +01:00
2006-01-06 15:22:28 -08:00
2006-01-10 08:01:59 -08:00
2006-01-10 08:01:59 -08:00
2006-01-10 08:01:59 -08:00
2006-01-10 08:01:59 -08:00
2005-10-29 19:30:55 +01:00
2006-01-14 10:41:42 -08:00
2006-02-03 08:31:59 -08:00
2006-01-12 09:09:00 -08:00
2006-01-10 08:01:59 -08:00
2006-01-10 08:01:59 -08:00
2006-02-03 08:32:03 -08:00
2006-01-14 10:41:42 -08:00
2006-01-10 13:39:07 +00:00
2006-01-18 19:25:49 -08:00
2006-02-03 08:32:09 -08:00
2006-01-10 08:01:59 -08:00