Steven Rostedt (VMware) 170a1fb9c0 netfilter: Force fake conntrack entry to be at least 8 bytes aligned ... Since the nfct and nfctinfo have been combined, the nf_conn structure must be at least 8 bytes aligned, as the 3 LSB bits are used for the nfctinfo. But there's a fake nf_conn structure to denote untracked connections, which is created by a PER_CPU construct. This does not guarantee that it will be 8 bytes aligned and can break the logic in determining the correct nfctinfo. I triggered this on a 32bit machine with the following error: BUG: unable to handle kernel NULL pointer dereference at 00000af4 IP: nf_ct_deliver_cached_events+0x1b/0xfb *pdpt = 0000000031962001 *pde = 0000000000000000 Oops: 0000 [#1] SMP [Modules linked in: ip6t_REJECT nf_reject_ipv6 nf_conntrack_ipv6 nf_defrag_ipv6 ip6table_filter ip6_tables ipv6 crc_ccitt ppdev r8169 parport_pc parport OK ] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.10.0-test+ #75 Hardware name: MSI MS-7823/CSM-H87M-G43 (MS-7823), BIOS V1.6 02/22/2014 task: c126ec00 task.stack: c1258000 EIP: nf_ct_deliver_cached_events+0x1b/0xfb EFLAGS: 00010202 CPU: 0 EAX: 0021cd01 EBX: 00000000 ECX: 27b0c767 EDX: 32bcb17a ESI: f34135c0 EDI: f34135c0 EBP: f2debd60 ESP: f2debd3c DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068 CR0: 80050033 CR2: 00000af4 CR3: 309a0440 CR4: 001406f0 Call Trace: <SOFTIRQ> ? ipv6_skip_exthdr+0xac/0xcb ipv6_confirm+0x10c/0x119 [nf_conntrack_ipv6] nf_hook_slow+0x22/0xc7 nf_hook+0x9a/0xad [ipv6] ? ip6t_do_table+0x356/0x379 [ip6_tables] ? ip6_fragment+0x9e9/0x9e9 [ipv6] ip6_output+0xee/0x107 [ipv6] ? ip6_fragment+0x9e9/0x9e9 [ipv6] dst_output+0x36/0x4d [ipv6] NF_HOOK.constprop.37+0xb2/0xba [ipv6] ? icmp6_dst_alloc+0x2c/0xfd [ipv6] ? local_bh_enable+0x14/0x14 [ipv6] mld_sendpack+0x1c5/0x281 [ipv6] ? mark_held_locks+0x40/0x5c mld_ifc_timer_expire+0x1f6/0x21e [ipv6] call_timer_fn+0x135/0x283 ? detach_if_pending+0x55/0x55 ? mld_dad_timer_expire+0x3e/0x3e [ipv6] __run_timers+0x111/0x14b ? mld_dad_timer_expire+0x3e/0x3e [ipv6] run_timer_softirq+0x1c/0x36 __do_softirq+0x185/0x37c ? test_ti_thread_flag.constprop.19+0xd/0xd do_softirq_own_stack+0x22/0x28 </SOFTIRQ> irq_exit+0x5a/0xa4 smp_apic_timer_interrupt+0x2a/0x34 apic_timer_interrupt+0x37/0x3c By using DEFINE/DECLARE_PER_CPU_ALIGNED we can enforce at least 8 byte alignment as all cache line sizes are at least 8 bytes or more. Fixes: a9e419dc7b ("netfilter: merge ctinfo into nfct pointer storage area") Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org> Acked-by: Florian Westphal <fw@strlen.de> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>		2017-03-13 13:33:58 +01:00
..
ipset	netfilter: ipset: Null pointer exception in ipset list:set	2017-02-19 19:08:47 +01:00
ipvs	lib/vsprintf.c: remove %Z support	2017-02-27 18:43:47 -08:00
core.c	netfilter: merge ctinfo into nfct pointer storage area	2017-02-02 14:31:56 +01:00
Kconfig	netfilter: nft_exthdr: add TCP option matching	2017-02-08 14:17:09 +01:00
Makefile	netfilter: nf_tables: add bitmap set type	2017-02-08 14:16:21 +01:00
nf_conntrack_acct.c
nf_conntrack_amanda.c
nf_conntrack_broadcast.c
nf_conntrack_core.c	netfilter: Force fake conntrack entry to be at least 8 bytes aligned	2017-03-13 13:33:58 +01:00
nf_conntrack_ecache.c
nf_conntrack_expect.c	netfilter: nf_ct_expect: Change __nf_ct_expect_check() return value.	2017-02-26 17:06:59 +01:00
nf_conntrack_extend.c
nf_conntrack_ftp.c	lib/vsprintf.c: remove %Z support	2017-02-27 18:43:47 -08:00
nf_conntrack_h323_asn1.c
nf_conntrack_h323_main.c
nf_conntrack_h323_types.c
nf_conntrack_helper.c	netfilter: nf_ct_helper: warn when not applying default helper assignment	2017-02-06 12:03:35 +01:00
nf_conntrack_irc.c
nf_conntrack_l3proto_generic.c
nf_conntrack_labels.c
nf_conntrack_netbios_ns.c
nf_conntrack_netlink.c	netfilter: ctnetlink: Fix regression in CTA_HELP processing	2017-02-06 12:49:05 +01:00
nf_conntrack_pptp.c
nf_conntrack_proto_dccp.c	netfilter: conntrack: no need to pass ctinfo to error handler	2017-02-02 14:31:51 +01:00
nf_conntrack_proto_generic.c
nf_conntrack_proto_gre.c	netns: make struct pernet_operations::id unsigned int	2016-11-18 10:59:15 -05:00
nf_conntrack_proto_sctp.c	netfilter: conntrack: no need to pass ctinfo to error handler	2017-02-02 14:31:51 +01:00
nf_conntrack_proto_tcp.c	netfilter: conntrack: no need to pass ctinfo to error handler	2017-02-02 14:31:51 +01:00
nf_conntrack_proto_udp.c	netfilter: conntrack: no need to pass ctinfo to error handler	2017-02-02 14:31:51 +01:00
nf_conntrack_proto.c	netfilter: conntrack: add nf_conntrack_default_on sysctl	2016-12-04 21:17:25 +01:00
nf_conntrack_sane.c
nf_conntrack_seqadj.c
nf_conntrack_sip.c	netfilter: nf_conntrack_sip: fix wrong memory initialisation	2017-03-03 13:48:31 +01:00
nf_conntrack_snmp.c
nf_conntrack_standalone.c	netfilter: merge ctinfo into nfct pointer storage area	2017-02-02 14:31:56 +01:00
nf_conntrack_tftp.c
nf_conntrack_timeout.c
nf_conntrack_timestamp.c
nf_dup_netdev.c	netfilter: add and use nf_fwd_netdev_egress	2016-12-06 21:48:22 +01:00
nf_internals.h	netfilter: merge nf_iterate() into nf_hook_slow()	2016-11-03 11:52:59 +01:00
nf_log_common.c	netfilter: nf_log: do not assume ethernet header in netdev family	2016-12-04 20:45:33 +01:00
nf_log_netdev.c	netfilter: nf_log: do not assume ethernet header in netdev family	2016-12-04 20:45:33 +01:00
nf_log.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next	2017-02-03 16:58:20 -05:00
nf_nat_amanda.c
nf_nat_core.c	netfilter: built-in NAT support for UDPlite	2016-12-04 20:45:32 +01:00
nf_nat_ftp.c
nf_nat_helper.c	skbuff: add and use skb_nfct helper	2017-02-02 14:31:53 +01:00
nf_nat_irc.c
nf_nat_proto_common.c
nf_nat_proto_dccp.c	netfilter: built-in NAT support for DCCP	2016-12-04 20:45:30 +01:00
nf_nat_proto_sctp.c	netfilter: nf_nat_sctp: fix ICMP packet to be dropped accidently	2017-03-08 18:04:06 +01:00
nf_nat_proto_tcp.c
nf_nat_proto_udp.c	netfilter: nat: merge udp and udplite helpers	2017-01-03 14:33:25 +01:00
nf_nat_proto_unknown.c
nf_nat_redirect.c
nf_nat_sip.c
nf_nat_tftp.c
nf_queue.c	netfilter: introduce accessor functions for hook entries	2016-12-06 21:42:15 +01:00
nf_sockopt.c
nf_synproxy_core.c	netns: make struct pernet_operations::id unsigned int	2016-11-18 10:59:15 -05:00
nf_tables_api.c	netfilter: nf_tables: don't call nfnetlink_set_err() if nfnetlink_send() fails	2017-03-03 13:48:34 +01:00
nf_tables_core.c	netfilter: nf_tables: simplify the basic expressions' init routine	2016-11-09 23:42:23 +01:00
nf_tables_inet.c
nf_tables_netdev.c
nf_tables_trace.c	netfilter: nf_tables: use hook state from xt_action_param structure	2016-11-03 11:52:34 +01:00
nfnetlink_acct.c
nfnetlink_cthelper.c	scripts/spelling.txt: add "an user" pattern and fix typo instances	2017-02-27 18:43:46 -08:00
nfnetlink_cttimeout.c
nfnetlink_log.c	ktime: Get rid of the union	2016-12-25 17:21:22 +01:00
nfnetlink_queue.c	ktime: Get rid of the union	2016-12-25 17:21:22 +01:00
nfnetlink.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf	2017-02-23 10:59:15 -05:00
nft_bitwise.c	netfilter: nf_tables: simplify the basic expressions' init routine	2016-11-09 23:42:23 +01:00
nft_byteorder.c	netfilter: nf_tables: simplify the basic expressions' init routine	2016-11-09 23:42:23 +01:00
nft_cmp.c	netfilter: nf_tables: simplify the basic expressions' init routine	2016-11-09 23:42:23 +01:00
nft_compat.c
nft_counter.c	netfilter: nft_counter: rework atomic dump and reset	2016-12-11 10:01:05 -05:00
nft_ct.c	netfilter: nf_tables: fix mismatch in big-endian system	2017-03-13 13:30:28 +01:00
nft_dup_netdev.c
nft_dynset.c	netfilter: nf_tables: validate the name size when possible	2017-01-23 23:36:50 +01:00
nft_exthdr.c	netfilter: nft_exthdr: add TCP option matching	2017-02-08 14:17:09 +01:00
nft_fib_inet.c	netfilter: nf_tables: use hook state from xt_action_param structure	2016-11-03 11:52:34 +01:00
nft_fib.c	netfilter: nft_fib: convert htonl to ntohl properly	2016-12-06 21:42:20 +01:00
nft_fwd_netdev.c	netfilter: add and use nf_fwd_netdev_egress	2016-12-06 21:48:22 +01:00
nft_hash.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2016-12-03 12:29:53 -05:00
nft_immediate.c	netfilter: nf_tables: simplify the basic expressions' init routine	2016-11-09 23:42:23 +01:00
nft_limit.c
nft_log.c	netfilter: nft_log: restrict the log prefix length to 127	2017-01-24 21:46:29 +01:00
nft_lookup.c	netfilter: nf_tables: validate the name size when possible	2017-01-23 23:36:50 +01:00
nft_masq.c	netfilter: nf_tables: add conntrack dependencies for nat/masq/redir expressions	2016-12-04 21:17:16 +01:00
nft_meta.c	netfilter: nf_tables: fix mismatch in big-endian system	2017-03-13 13:30:28 +01:00
nft_nat.c	netfilter: nf_tables: fix mismatch in big-endian system	2017-03-13 13:30:28 +01:00
nft_numgen.c	netfilter: nft_numgen: start round robin from zero	2016-10-26 16:35:16 +02:00
nft_objref.c	netfilter: nf_tables: validate the name size when possible	2017-01-23 23:36:50 +01:00
nft_payload.c	netfilter: nft_payload: mangle ckecksum if NFT_PAYLOAD_L4CSUM_PSEUDOHDR is set	2016-12-14 23:39:11 +01:00
nft_queue.c	netfilter: nft_queue: use raw_smp_processor_id()	2016-12-14 23:39:01 +01:00
nft_quota.c	netfilter: nft_quota: reset quota after dump	2016-12-14 23:38:51 +01:00
nft_range.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2016-12-03 12:29:53 -05:00
nft_redir.c	netfilter: nf_tables: add conntrack dependencies for nat/masq/redir expressions	2016-12-04 21:17:16 +01:00
nft_reject_inet.c	netfilter: nf_tables: use hook state from xt_action_param structure	2016-11-03 11:52:34 +01:00
nft_reject.c
nft_rt.c	netfilter: nf_tables: use hook state from xt_action_param structure	2016-11-03 11:52:34 +01:00
nft_set_bitmap.c	netfilter: nft_set_bitmap: fetch the element key based on the set->klen	2017-03-13 13:16:42 +01:00
nft_set_hash.c	netfilter: nf_tables: honor NFT_SET_OBJECT in set backend selection	2017-02-12 14:45:14 +01:00
nft_set_rbtree.c	netfilter: nft_set_rbtree: incorrect assumption on lower interval lookups	2017-03-03 13:48:32 +01:00
x_tables.c	scripts/spelling.txt: add "aligment" pattern and fix typo instances	2017-02-27 18:43:46 -08:00
xt_addrtype.c	netfilter: x_tables: move hook state into xt_action_param structure	2016-11-03 10:56:21 +01:00
xt_AUDIT.c	netfilter: x_tables: move hook state into xt_action_param structure	2016-11-03 10:56:21 +01:00
xt_bpf.c	xtables: extend matches and targets with .usersize	2017-01-09 17:24:55 +01:00
xt_cgroup.c	xtables: extend matches and targets with .usersize	2017-01-09 17:24:55 +01:00
xt_CHECKSUM.c
xt_CLASSIFY.c
xt_cluster.c	netfilter: x_tables: move hook state into xt_action_param structure	2016-11-03 10:56:21 +01:00
xt_comment.c
xt_connbytes.c	netfilter: add and use nf_ct_netns_get/put	2016-12-04 21:16:50 +01:00
xt_connlabel.c	netfilter: add and use nf_ct_netns_get/put	2016-12-04 21:16:50 +01:00
xt_connlimit.c	xtables: extend matches and targets with .usersize	2017-01-09 17:24:55 +01:00
xt_connmark.c	netfilter: add and use nf_ct_netns_get/put	2016-12-04 21:16:50 +01:00
xt_CONNSECMARK.c	netfilter: add and use nf_ct_netns_get/put	2016-12-04 21:16:50 +01:00
xt_conntrack.c	netfilter: add and use nf_ct_netns_get/put	2016-12-04 21:16:50 +01:00
xt_cpu.c
xt_CT.c	netfilter: merge ctinfo into nfct pointer storage area	2017-02-02 14:31:56 +01:00
xt_dccp.c
xt_devgroup.c	netfilter: x_tables: move hook state into xt_action_param structure	2016-11-03 10:56:21 +01:00
xt_dscp.c	netfilter: x_tables: move hook state into xt_action_param structure	2016-11-03 10:56:21 +01:00
xt_DSCP.c
xt_ecn.c
xt_esp.c
xt_hashlimit.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf	2017-02-23 10:59:15 -05:00
xt_helper.c	netfilter: add and use nf_ct_netns_get/put	2016-12-04 21:16:50 +01:00
xt_hl.c
xt_HL.c
xt_HMARK.c
xt_IDLETIMER.c
xt_ipcomp.c	netfilter: xt_ipcomp: add "ip[6]t_ipcomp" module alias name	2016-10-17 17:38:19 +02:00
xt_iprange.c
xt_ipvs.c	netfilter: x_tables: move hook state into xt_action_param structure	2016-11-03 10:56:21 +01:00
xt_l2tp.c
xt_LED.c
xt_length.c
xt_limit.c	xtables: extend matches and targets with .usersize	2017-01-09 17:24:55 +01:00
xt_LOG.c	netfilter: x_tables: move hook state into xt_action_param structure	2016-11-03 10:56:21 +01:00
xt_mac.c
xt_mark.c
xt_multiport.c	netfilter: xt_multiport: Fix wrong unmatch result with multiple ports	2016-12-06 21:48:20 +01:00
xt_nat.c	netfilter: nat: add dependencies on conntrack module	2016-12-04 21:16:51 +01:00
xt_NETMAP.c	netfilter: nat: add dependencies on conntrack module	2016-12-04 21:16:51 +01:00
xt_nfacct.c	netfilter: x_tables: move hook state into xt_action_param structure	2016-11-03 10:56:21 +01:00
xt_NFLOG.c	netfilter: x_tables: move hook state into xt_action_param structure	2016-11-03 10:56:21 +01:00
xt_NFQUEUE.c	netfilter: x_tables: move hook state into xt_action_param structure	2016-11-03 10:56:21 +01:00
xt_osf.c	netfilter: x_tables: move hook state into xt_action_param structure	2016-11-03 10:56:21 +01:00
xt_owner.c	sched/headers: Prepare to remove <linux/cred.h> inclusion from <linux/sched.h>	2017-03-02 08:42:31 +01:00
xt_physdev.c
xt_pkttype.c	netfilter: pkttype: unnecessary to check ipv6 multicast address	2017-01-18 20:32:43 +01:00
xt_policy.c	netfilter: x_tables: move hook state into xt_action_param structure	2016-11-03 10:56:21 +01:00
xt_quota.c	xtables: extend matches and targets with .usersize	2017-01-09 17:24:55 +01:00
xt_rateest.c	xtables: extend matches and targets with .usersize	2017-01-09 17:24:55 +01:00
xt_RATEEST.c	xtables: extend matches and targets with .usersize	2017-01-09 17:24:55 +01:00
xt_realm.c
xt_recent.c	netns: make struct pernet_operations::id unsigned int	2016-11-18 10:59:15 -05:00
xt_REDIRECT.c	netfilter: nat: add dependencies on conntrack module	2016-12-04 21:16:51 +01:00
xt_repldata.h
xt_sctp.c
xt_SECMARK.c
xt_set.c	netfilter: ipset: Improve skbinfo get/init helpers	2016-11-10 13:28:42 +01:00
xt_socket.c	netfilter: defrag: only register defrag functionality if needed	2016-12-06 21:42:00 +01:00
xt_state.c	netfilter: add and use nf_ct_netns_get/put	2016-12-04 21:16:50 +01:00
xt_statistic.c
xt_string.c	xtables: extend matches and targets with .usersize	2017-01-09 17:24:55 +01:00
xt_tcpmss.c
xt_TCPMSS.c	netfilter: x_tables: move hook state into xt_action_param structure	2016-11-03 10:56:21 +01:00
xt_TCPOPTSTRIP.c
xt_tcpudp.c
xt_TEE.c	xtables: extend matches and targets with .usersize	2017-01-09 17:24:55 +01:00
xt_time.c	ktime: Get rid of the union	2016-12-25 17:21:22 +01:00
xt_TPROXY.c	netfilter: defrag: only register defrag functionality if needed	2016-12-06 21:42:00 +01:00
xt_TRACE.c
xt_u32.c