Jesper Dangaard Brouer 1ba3aab303 net: codel: Avoid undefined behavior from signed overflow
As described in commit 5a581b367 (jiffies: Avoid undefined
behavior from signed overflow), according to the C standard
3.4.3p3, overflow of a signed integer results in undefined
behavior.

To fix this, do as the above commit, and do an unsigned
subtraction, and interpreting the result as a signed
two's-complement number.  This is based on the theory from
RFC 1982 and is nicely described in wikipedia here:
 https://en.wikipedia.org/wiki/Serial_number_arithmetic#General_Solution

A side-note, I have seen practical issues with the previous logic
when dealing with 16-bit, on a 64-bit machine (gcc version
4.4.5). This were 32-bit, which I have not observed issues with.

Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Jesper Dangaard Brouer <netoptimizer@brouer.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2013-11-04 20:01:29 -05:00
..
2012-07-19 10:43:03 -07:00
2013-10-19 19:36:18 -04:00
2013-01-27 22:46:33 -05:00
2013-10-28 20:07:50 -04:00
2013-10-08 23:19:24 -04:00
2013-10-09 00:01:25 -04:00
2013-10-17 16:11:04 -04:00
2012-08-06 13:40:47 -07:00
2013-06-04 16:43:42 -07:00
2013-10-08 16:27:33 -04:00
2012-05-16 15:17:08 -04:00