Ian Campbell 31a14400e8 xen/blkfront: fix warning when deleting gendisk on unplug/shutdown ... Currently blkfront gives a warning when hot unplugging due to calling del_gendisk() with interrupts disabled (due to blkif_io_lock). WARNING: at kernel/softirq.c:124 local_bh_enable+0x36/0x84() Modules linked in: xenfs xen_netfront ext3 jbd mbcache xen_blkfront Pid: 13, comm: xenwatch Not tainted 2.6.29-xs5.5.0.13 #3 Call Trace: [<c012611c>] warn_slowpath+0x80/0xb6 [<c0104cf1>] xen_sched_clock+0x16/0x63 [<c0104710>] xen_force_evtchn_callback+0xc/0x10 [<c0104e32>] check_events+0x8/0xe [<c0104d9b>] xen_restore_fl_direct_end+0x0/0x1 [<c0103749>] xen_mc_flush+0x10a/0x13f [<c0105bd2>] __switch_to+0x114/0x14e [<c011d92b>] dequeue_task+0x62/0x70 [<c0123b6f>] finish_task_switch+0x2b/0x84 [<c0299877>] schedule+0x66d/0x6e7 [<c0104710>] xen_force_evtchn_callback+0xc/0x10 [<c0104710>] xen_force_evtchn_callback+0xc/0x10 [<c012a642>] local_bh_enable+0x36/0x84 [<c022f9a7>] sk_filter+0x57/0x5c [<c0233dae>] netlink_broadcast+0x1d5/0x315 [<c01c6371>] kobject_uevent_env+0x28d/0x331 [<c01e7ead>] device_del+0x10f/0x120 [<c01e7ec6>] device_unregister+0x8/0x10 [<c015f86d>] bdi_unregister+0x2d/0x39 [<c01bf6f4>] unlink_gendisk+0x23/0x3e [<c01ac946>] del_gendisk+0x7b/0xe7 [<d0828c19>] blkfront_closing+0x28/0x6e [xen_blkfront] [<d082900c>] backend_changed+0x3ad/0x41d [xen_blkfront] We can fix this by calling del_gendisk() later in blkfront_closing, after releasing blkif_io_lock. Since the queue is stopped during the interrupts disabled phase I don't think there is any danger of an event occuring between releasing the blkif_io_lock and deleting the disk. Signed-off-by: Ian Campbell <ian.campbell@citrix.com> Cc: Jeremy Fitzhardinge <jeremy@goop.org> Signed-off-by: Jens Axboe <jens.axboe@oracle.com>		2009-05-19 08:27:42 +02:00
..
aoe	aoe: WIN_* -> ATA_CMD_*	2009-04-01 21:42:24 +02:00
paride
amiflop.c
ataflop.c
brd.c	brd: fix cacheflushing	2009-04-15 12:10:13 +02:00
cciss_cmd.h	cciss: kernel scan thread for MSA2012	2009-04-07 08:12:38 +02:00
cciss_scsi.c
cciss_scsi.h
cciss.c	Replace all DMA_nBIT_MASK macro with DMA_BIT_MASK(n)	2009-04-13 15:04:33 -07:00
cciss.h	cciss: kernel scan thread for MSA2012	2009-04-07 08:12:38 +02:00
cpqarray.c
cpqarray.h
cryptoloop.c
DAC960.c	dma-mapping: replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32)	2009-04-07 08:31:11 -07:00
DAC960.h
floppy.c	floppy: provide a PNP device table in the module.	2009-04-02 19:04:49 -07:00
hd.c	hd: fix locking	2009-04-28 20:24:20 +02:00
ida_cmd.h
ida_ioctl.h
Kconfig	mflash: initial support	2009-04-07 08:12:38 +02:00
loop.c	loop: mutex already unlocked in loop_clr_fd()	2009-04-07 13:48:21 +02:00
Makefile	mflash: initial support	2009-04-07 08:12:38 +02:00
mg_disk.c	mg_disk: fix CONFIG_LBD=y warning	2009-04-28 20:24:20 +02:00
nbd.c	nbd: trivial cleanups	2009-04-02 19:05:02 -07:00
pktcdvd.c
ps3disk.c
ps3vram.c	proc 2/2: remove struct proc_dir_entry::owner	2009-03-31 01:14:44 +04:00
smart1,2.h
sunvdc.c
swim3.c
swim_asm.S
swim.c
sx8.c	dma-mapping: replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32)	2009-04-07 08:31:11 -07:00
ub.c	USB: add reset endpoint operations	2009-04-17 10:50:27 -07:00
umem.c	umem: fix request_queue lock warning	2009-04-24 08:54:21 +02:00
umem.h
viodasd.c
virtio_blk.c
xd.c
xd.h
xen-blkfront.c	xen/blkfront: fix warning when deleting gendisk on unplug/shutdown	2009-05-19 08:27:42 +02:00
xsysace.c	xsysace: Fix dereferencing of cf_id after hd_driveid removal	2009-04-08 14:13:04 +02:00
z2ram.c