Andres Salomon
bca5c2c550
ov7670: clean up ov7670_read semantics
...
Cortland Setlow pointed out a bug in ov7670.c where the result from
ov7670_read() was just being checked for !0 , rather than <0. This made me
realize that ov7670_read's semantics were rather confusing; it both fills
in 'value' with the result, and returns it. This is goes against general
kernel convention; so rather than fixing callers, let's fix the function.
This makes ov7670_read return <0 in the case of an error, and 0 upon
success. Thus, code like:
res = ov7670_read(...);
if (!res)
goto error;
..will work properly.
Signed-off-by: Cortland Setlow <csetlow@tower-research.com>
Signed-off-by: Andres Salomon <dilinger@debian.org>
Acked-by: Jonathan Corbet <corbet@lwn.net>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-12 14:33:41 -07:00
..
2008-06-26 15:58:52 -03:00
2008-06-05 06:35:52 -03:00
2008-04-24 14:07:59 -03:00
2008-06-26 15:58:55 -03:00
2008-06-26 15:58:47 -03:00
2008-06-05 06:35:51 -03:00
2008-06-26 15:58:42 -03:00
2008-06-26 15:58:47 -03:00
2008-05-16 12:01:45 -07:00
2008-06-05 06:35:49 -03:00
2008-04-24 14:07:59 -03:00
2008-05-14 02:56:47 -03:00
2008-04-24 14:08:48 -03:00
2008-06-26 15:58:59 -03:00
2008-05-16 12:01:45 -07:00
2008-06-05 06:35:52 -03:00
2008-05-14 02:54:07 -03:00
2008-07-02 08:58:15 -03:00
2008-05-16 12:01:45 -07:00
2008-04-24 13:42:20 -03:00
2008-04-24 13:42:20 -03:00
2008-04-24 14:07:53 -03:00
2008-04-24 13:42:20 -03:00
2008-04-24 13:42:20 -03:00
2008-06-05 06:35:51 -03:00
2008-06-05 06:35:51 -03:00
2008-04-24 14:07:53 -03:00
2008-04-24 14:09:40 -03:00
2008-04-24 13:42:20 -03:00
2008-04-24 14:07:59 -03:00
2008-04-24 14:07:53 -03:00
2008-04-24 14:07:59 -03:00
2008-05-18 20:49:40 +02:00
2008-05-18 20:49:40 +02:00
2008-01-25 19:04:04 -02:00
2008-04-24 14:07:44 -03:00
2008-04-24 14:07:46 -03:00
2008-04-24 13:42:20 -03:00
2008-04-24 13:42:20 -03:00
2008-04-24 13:42:20 -03:00
2008-02-03 17:18:59 +02:00
2008-04-26 09:29:58 -03:00
2008-06-30 17:31:13 -03:00
2008-01-27 18:14:48 +01:00
2008-05-18 20:49:40 +02:00
2008-06-30 17:31:13 -03:00
2008-04-24 14:09:45 -03:00
2008-05-18 20:49:40 +02:00
2008-04-24 14:07:49 -03:00
2008-05-14 02:54:10 -03:00
2008-05-14 02:54:11 -03:00
2008-04-24 13:42:20 -03:00
2008-04-24 14:09:44 -03:00
2008-04-24 14:07:59 -03:00
2008-07-12 14:33:41 -07:00
2008-04-24 14:07:53 -03:00
2008-06-26 15:58:50 -03:00
2008-04-24 13:42:20 -03:00
2008-05-18 20:49:40 +02:00
2008-04-24 14:07:53 -03:00
2008-04-24 13:42:20 -03:00
2008-04-24 13:42:20 -03:00
2008-04-24 13:42:20 -03:00
2008-04-24 13:42:20 -03:00
2008-05-18 20:49:40 +02:00
2008-05-18 20:49:40 +02:00
2008-04-24 13:42:20 -03:00
2008-04-24 14:07:59 -03:00
2008-06-26 15:58:50 -03:00
2008-02-18 11:15:08 -03:00
2008-05-14 02:54:00 -03:00
2008-02-18 11:15:08 -03:00
2008-04-24 14:07:53 -03:00
2008-04-24 14:07:59 -03:00
2008-05-11 20:37:06 +02:00
2008-04-24 14:07:59 -03:00
2008-04-24 14:07:59 -03:00
2008-04-24 14:07:59 -03:00
2008-05-11 20:37:06 +02:00
2008-06-05 06:35:41 -03:00
2008-05-11 20:37:06 +02:00
2008-05-14 02:56:46 -03:00
2008-04-24 13:42:20 -03:00
2008-05-18 20:49:40 +02:00
2008-05-18 20:49:40 +02:00
2008-04-24 14:07:50 -03:00
2008-04-29 23:11:39 +02:00
2008-04-01 19:35:47 -03:00
2008-05-20 10:12:26 -07:00
2008-04-24 14:09:39 -03:00
2008-04-24 14:09:39 -03:00
2008-04-24 14:09:39 -03:00
2008-04-24 14:09:40 -03:00
2008-06-26 15:58:57 -03:00
2008-04-28 08:58:18 -07:00
2008-06-26 15:58:58 -03:00
2008-05-18 20:49:40 +02:00
2008-04-24 13:42:20 -03:00
2008-04-24 14:07:59 -03:00
2008-04-24 14:07:53 -03:00
2008-04-24 14:07:59 -03:00
2008-05-18 20:49:40 +02:00
2008-05-18 20:49:40 +02:00
2008-04-24 13:42:20 -03:00
2008-04-24 14:07:57 -03:00
2008-06-05 06:35:52 -03:00
2008-06-05 06:35:52 -03:00
2008-04-29 08:06:22 -07:00
2008-06-05 06:35:52 -03:00
2008-04-24 13:42:20 -03:00
2008-04-24 13:42:20 -03:00
2008-04-24 13:42:20 -03:00
2008-04-24 13:42:20 -03:00