Theodore Ts'o 26a4c0c6cc ext4: refactor punch hole code
Move common code in ext4_ind_punch_hole() and ext4_ext_punch_hole()
into ext4_punch_hole().  This saves over 150 lines of code.

This also fixes a potential bug when the punch_hole() code is racing
against indirect-to-extents or extents-to-indirect migation.  We are
currently using i_mutex to protect against changes to the inode flag;
specifically, the append-only, immutable, and extents inode flags.  So
we need to take i_mutex before deciding whether to use the
extents-specific or indirect-specific punch_hole code.

Also, there was a missing call to ext4_inode_block_unlocked_dio() in
the indirect punch codepath.  This was added in commit 02d262dffcf4c
to block DIO readers racing against the punch operation in the
codepath for extent-mapped inodes, but it was missing for
indirect-block mapped inodes.  One of the advantages of refactoring
the code is that it makes such oversights much less likely.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2013-04-03 12:45:17 -04:00
..
2013-03-11 22:05:56 +01:00
2013-04-03 12:45:17 -04:00
2013-03-12 18:55:21 -07:00
2013-03-12 18:55:21 -07:00
2013-03-26 14:23:45 -07:00
2013-03-22 16:55:15 -04:00
2013-03-28 15:52:14 -07:00
2013-03-12 18:55:21 -07:00
2013-02-22 23:31:31 -05:00
2013-02-22 23:31:31 -05:00
2013-02-22 23:31:31 -05:00
2013-03-26 18:25:57 -04:00
2013-02-22 23:31:31 -05:00
2013-02-28 13:21:44 -08:00
2013-02-22 23:31:31 -05:00
2012-12-20 18:46:29 -05:00
2013-02-22 23:31:31 -05:00
2013-03-12 08:29:17 -07:00
2013-02-22 23:31:31 -05:00
2012-12-17 17:15:27 -08:00
2013-02-26 02:46:08 -05:00
2013-02-22 23:31:31 -05:00