Andrea Righi 27ac792ca0 PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures
On 32-bit architectures PAGE_ALIGN() truncates 64-bit values to the 32-bit
boundary. For example:

	u64 val = PAGE_ALIGN(size);

always returns a value < 4GB even if size is greater than 4GB.

The problem resides in PAGE_MASK definition (from include/asm-x86/page.h for
example):

#define PAGE_SHIFT      12
#define PAGE_SIZE       (_AC(1,UL) << PAGE_SHIFT)
#define PAGE_MASK       (~(PAGE_SIZE-1))
...
#define PAGE_ALIGN(addr)       (((addr)+PAGE_SIZE-1)&PAGE_MASK)

The "~" is performed on a 32-bit value, so everything in "and" with
PAGE_MASK greater than 4GB will be truncated to the 32-bit boundary.
Using the ALIGN() macro seems to be the right way, because it uses
typeof(addr) for the mask.

Also move the PAGE_ALIGN() definitions out of include/asm-*/page.h in
include/linux/mm.h.

See also lkml discussion: http://lkml.org/lkml/2008/6/11/237

[akpm@linux-foundation.org: fix drivers/media/video/uvc/uvc_queue.c]
[akpm@linux-foundation.org: fix v850]
[akpm@linux-foundation.org: fix powerpc]
[akpm@linux-foundation.org: fix arm]
[akpm@linux-foundation.org: fix mips]
[akpm@linux-foundation.org: fix drivers/media/video/pvrusb2/pvrusb2-dvb.c]
[akpm@linux-foundation.org: fix drivers/mtd/maps/uclinux.c]
[akpm@linux-foundation.org: fix powerpc]
Signed-off-by: Andrea Righi <righi.andrea@gmail.com>
Cc: <linux-arch@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-24 10:47:21 -07:00
..
2008-07-15 14:14:42 +02:00
2008-07-10 16:41:50 +01:00
2008-07-03 16:39:56 +01:00
2008-07-15 14:14:46 +02:00
2008-02-03 14:59:11 +02:00
2008-07-13 12:05:49 +01:00
2005-09-07 16:57:21 -07:00
2008-01-28 23:58:27 -05:00
2006-01-08 20:13:39 -08:00
2008-04-18 22:43:07 +01:00
2006-12-13 14:34:43 +00:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-05-01 08:03:58 -07:00
2007-10-23 12:37:59 +02:00
2005-04-16 15:20:36 -07:00
2007-07-17 10:23:11 -07:00
2005-04-16 15:20:36 -07:00
2007-10-17 08:42:55 -07:00
2006-01-08 20:13:39 -08:00
2008-04-18 22:43:07 +01:00
2007-02-12 09:48:34 -08:00
2005-04-16 15:20:36 -07:00
2008-04-18 00:46:34 +02:00
2007-10-14 12:41:52 -07:00
2006-01-10 08:01:34 -08:00
2005-04-16 15:20:36 -07:00
2006-09-20 14:58:35 +01:00
2008-07-23 11:30:15 -05:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-10-18 07:51:34 +01:00
2005-04-16 15:20:36 -07:00
2008-04-19 11:36:48 +01:00
2006-02-15 15:32:22 -08:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-07-07 16:50:16 +02:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2006-03-21 22:05:45 +00:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-04-28 08:58:23 -07:00
2007-05-11 08:29:34 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-04-17 10:42:34 -04:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2007-05-30 13:15:06 +01:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2005-04-16 15:20:36 -07:00
2008-02-05 09:44:18 -08:00
2008-06-22 22:45:04 +02:00
2005-04-16 15:20:36 -07:00
2008-07-23 11:30:15 -05:00
2008-02-07 08:42:30 -08:00
2008-01-26 14:41:28 +00:00
2005-04-16 15:20:36 -07:00