mirror of
https://github.com/FEX-Emu/linux.git
synced 2024-12-13 11:51:32 +00:00
27ac792ca0
On 32-bit architectures PAGE_ALIGN() truncates 64-bit values to the 32-bit boundary. For example: u64 val = PAGE_ALIGN(size); always returns a value < 4GB even if size is greater than 4GB. The problem resides in PAGE_MASK definition (from include/asm-x86/page.h for example): #define PAGE_SHIFT 12 #define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT) #define PAGE_MASK (~(PAGE_SIZE-1)) ... #define PAGE_ALIGN(addr) (((addr)+PAGE_SIZE-1)&PAGE_MASK) The "~" is performed on a 32-bit value, so everything in "and" with PAGE_MASK greater than 4GB will be truncated to the 32-bit boundary. Using the ALIGN() macro seems to be the right way, because it uses typeof(addr) for the mask. Also move the PAGE_ALIGN() definitions out of include/asm-*/page.h in include/linux/mm.h. See also lkml discussion: http://lkml.org/lkml/2008/6/11/237 [akpm@linux-foundation.org: fix drivers/media/video/uvc/uvc_queue.c] [akpm@linux-foundation.org: fix v850] [akpm@linux-foundation.org: fix powerpc] [akpm@linux-foundation.org: fix arm] [akpm@linux-foundation.org: fix mips] [akpm@linux-foundation.org: fix drivers/media/video/pvrusb2/pvrusb2-dvb.c] [akpm@linux-foundation.org: fix drivers/mtd/maps/uclinux.c] [akpm@linux-foundation.org: fix powerpc] Signed-off-by: Andrea Righi <righi.andrea@gmail.com> Cc: <linux-arch@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
||
|---|---|---|
| .. | ||
| mach-bigsmp | ||
| mach-default | ||
| mach-es7000 | ||
| mach-generic | ||
| mach-numaq | ||
| mach-rdc321x | ||
| mach-summit | ||
| mach-voyager | ||
| uv | ||
| visws | ||
| xen | ||
| a.out-core.h | ||
| a.out.h | ||
| acpi.h | ||
| agp.h | ||
| alternative-asm.h | ||
| alternative.h | ||
| amd_iommu_types.h | ||
| amd_iommu.h | ||
| apic.h | ||
| apicdef.h | ||
| arch_hooks.h | ||
| asm.h | ||
| atomic_32.h | ||
| atomic_64.h | ||
| atomic.h | ||
| auxvec.h | ||
| bios_ebda.h | ||
| bitops.h | ||
| boot.h | ||
| bootparam.h | ||
| bug.h | ||
| bugs.h | ||
| byteorder.h | ||
| cache.h | ||
| cacheflush.h | ||
| calgary.h | ||
| calling.h | ||
| checksum_32.h | ||
| checksum_64.h | ||
| checksum.h | ||
| cmpxchg_32.h | ||
| cmpxchg_64.h | ||
| cmpxchg.h | ||
| compat.h | ||
| cpu.h | ||
| cpufeature.h | ||
| cputime.h | ||
| current.h | ||
| debugreg.h | ||
| delay.h | ||
| desc_defs.h | ||
| desc.h | ||
| device.h | ||
| div64.h | ||
| dma-mapping.h | ||
| dma.h | ||
| dmi.h | ||
| ds.h | ||
| dwarf2.h | ||
| e820.h | ||
| edac.h | ||
| efi.h | ||
| elf.h | ||
| emergency-restart.h | ||
| errno.h | ||
| fb.h | ||
| fcntl.h | ||
| fixmap_32.h | ||
| fixmap_64.h | ||
| fixmap.h | ||
| floppy.h | ||
| frame.h | ||
| ftrace.h | ||
| futex.h | ||
| gart.h | ||
| genapic_32.h | ||
| genapic_64.h | ||
| genapic.h | ||
| geode.h | ||
| gpio.h | ||
| hardirq_32.h | ||
| hardirq_64.h | ||
| hardirq.h | ||
| highmem.h | ||
| hpet.h | ||
| hugetlb.h | ||
| hw_irq.h | ||
| hypertransport.h | ||
| i387.h | ||
| i8253.h | ||
| i8259.h | ||
| ia32_unistd.h | ||
| ia32.h | ||
| ide.h | ||
| idle.h | ||
| intel_arch_perfmon.h | ||
| io_32.h | ||
| io_64.h | ||
| io_apic.h | ||
| io.h | ||
| ioctl.h | ||
| ioctls.h | ||
| iommu.h | ||
| ipcbuf.h | ||
| ipi.h | ||
| irq_regs_32.h | ||
| irq_regs_64.h | ||
| irq_regs.h | ||
| irq_vectors.h | ||
| irq.h | ||
| irqflags.h | ||
| ist.h | ||
| k8.h | ||
| Kbuild | ||
| kdebug.h | ||
| kexec.h | ||
| kgdb.h | ||
| kmap_types.h | ||
| kprobes.h | ||
| kvm_host.h | ||
| kvm_para.h | ||
| kvm_x86_emulate.h | ||
| kvm.h | ||
| ldt.h | ||
| lguest_hcall.h | ||
| lguest.h | ||
| linkage.h | ||
| local.h | ||
| math_emu.h | ||
| mc146818rtc.h | ||
| mca_dma.h | ||
| mca.h | ||
| mce.h | ||
| mman.h | ||
| mmconfig.h | ||
| mmu_context_32.h | ||
| mmu_context_64.h | ||
| mmu_context.h | ||
| mmu.h | ||
| mmx.h | ||
| mmzone_32.h | ||
| mmzone_64.h | ||
| mmzone.h | ||
| module.h | ||
| mpspec_def.h | ||
| mpspec.h | ||
| msgbuf.h | ||
| msidef.h | ||
| msr-index.h | ||
| msr.h | ||
| mtrr.h | ||
| mutex_32.h | ||
| mutex_64.h | ||
| mutex.h | ||
| namei.h | ||
| nmi.h | ||
| nops.h | ||
| numa_32.h | ||
| numa_64.h | ||
| numa.h | ||
| numaq.h | ||
| olpc.h | ||
| page_32.h | ||
| page_64.h | ||
| page.h | ||
| param.h | ||
| paravirt.h | ||
| parport.h | ||
| pat.h | ||
| pci_32.h | ||
| pci_64.h | ||
| pci-direct.h | ||
| pci.h | ||
| pda.h | ||
| percpu.h | ||
| pgalloc.h | ||
| pgtable_32.h | ||
| pgtable_64.h | ||
| pgtable-2level-defs.h | ||
| pgtable-2level.h | ||
| pgtable-3level-defs.h | ||
| pgtable-3level.h | ||
| pgtable.h | ||
| poll.h | ||
| posix_types_32.h | ||
| posix_types_64.h | ||
| posix_types.h | ||
| prctl.h | ||
| processor-cyrix.h | ||
| processor-flags.h | ||
| processor.h | ||
| proto.h | ||
| ptrace-abi.h | ||
| ptrace.h | ||
| pvclock-abi.h | ||
| pvclock.h | ||
| reboot_fixups.h | ||
| reboot.h | ||
| required-features.h | ||
| resource.h | ||
| resume-trace.h | ||
| rio.h | ||
| rtc.h | ||
| rwlock.h | ||
| rwsem.h | ||
| scatterlist.h | ||
| seccomp_32.h | ||
| seccomp_64.h | ||
| seccomp.h | ||
| sections.h | ||
| segment.h | ||
| semaphore.h | ||
| sembuf.h | ||
| serial.h | ||
| setup.h | ||
| shmbuf.h | ||
| shmparam.h | ||
| sigcontext32.h | ||
| sigcontext.h | ||
| siginfo.h | ||
| signal.h | ||
| smp.h | ||
| socket.h | ||
| sockios.h | ||
| sparsemem.h | ||
| spinlock_types.h | ||
| spinlock.h | ||
| srat.h | ||
| stacktrace.h | ||
| stat.h | ||
| statfs.h | ||
| string_32.h | ||
| string_64.h | ||
| string.h | ||
| suspend_32.h | ||
| suspend_64.h | ||
| suspend.h | ||
| swiotlb.h | ||
| sync_bitops.h | ||
| system_64.h | ||
| system.h | ||
| tce.h | ||
| termbits.h | ||
| termios.h | ||
| therm_throt.h | ||
| thread_info.h | ||
| time.h | ||
| timer.h | ||
| timex.h | ||
| tlb.h | ||
| tlbflush.h | ||
| topology.h | ||
| trampoline.h | ||
| traps.h | ||
| tsc.h | ||
| types.h | ||
| uaccess_32.h | ||
| uaccess_64.h | ||
| uaccess.h | ||
| ucontext.h | ||
| unaligned.h | ||
| unistd_32.h | ||
| unistd_64.h | ||
| unistd.h | ||
| unwind.h | ||
| user32.h | ||
| user_32.h | ||
| user_64.h | ||
| user.h | ||
| vdso.h | ||
| vga.h | ||
| vgtod.h | ||
| vic.h | ||
| vm86.h | ||
| vmi_time.h | ||
| vmi.h | ||
| voyager.h | ||
| vsyscall.h | ||
| xor_32.h | ||
| xor_64.h | ||
| xor.h | ||