mirror of
https://github.com/FEX-Emu/linux.git
synced 2024-12-26 11:28:28 +00:00
7b6982ce4b
There's a bug in LLVM that it can generate unneeded relocation information. See [1] and [2]. Libbpf should check the target section of a relocation symbol. This patch adds a testcase which references a global variable (BPF doesn't support global variables). Before fixing libbpf, the new test case can be loaded into kernel, the global variable acts like the first map. It is incorrect. Result: # ~/perf test BPF 37: Test BPF filter : 37.1: Test basic BPF filtering : Ok 37.2: Test BPF prologue generation : Ok 37.3: Test BPF relocation checker : FAILED! # ~/perf test -v BPF ... libbpf: loading object '[bpf_relocation_test]' from buffer libbpf: section .strtab, size 126, link 0, flags 0, type=3 libbpf: section .text, size 0, link 0, flags 6, type=1 libbpf: section .data, size 0, link 0, flags 3, type=1 libbpf: section .bss, size 0, link 0, flags 3, type=8 libbpf: section func=sys_write, size 104, link 0, flags 6, type=1 libbpf: found program func=sys_write libbpf: section .relfunc=sys_write, size 16, link 10, flags 0, type=9 libbpf: section maps, size 16, link 0, flags 3, type=1 libbpf: maps in [bpf_relocation_test]: 16 bytes libbpf: section license, size 4, link 0, flags 3, type=1 libbpf: license of [bpf_relocation_test] is GPL libbpf: section version, size 4, link 0, flags 3, type=1 libbpf: kernel version of [bpf_relocation_test] is 40400 libbpf: section .symtab, size 144, link 1, flags 0, type=2 libbpf: map 0 is "my_table" libbpf: collecting relocating info for: 'func=sys_write' libbpf: relocation: insn_idx=7 Success unexpectedly: libbpf error when dealing with relocation test child finished with -1 ---- end ---- Test BPF filter subtest 2: FAILED! [1] https://llvm.org/bugs/show_bug.cgi?id=26243 [2] https://patchwork.ozlabs.org/patch/571385/ Signed-off-by: Wang Nan <wangnan0@huawei.com> Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Brendan Gregg <brendan.d.gregg@gmail.com> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: He Kuang <hekuang@huawei.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Li Zefan <lizefan@huawei.com> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Will Deacon <will.deacon@arm.com> Cc: pi3orama@163.com Link: http://lkml.kernel.org/r/1453715801-7732-2-git-send-email-wangnan0@huawei.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
76 lines
2.5 KiB
Plaintext
76 lines
2.5 KiB
Plaintext
perf-y += builtin-test.o
|
|
perf-y += parse-events.o
|
|
perf-y += dso-data.o
|
|
perf-y += attr.o
|
|
perf-y += vmlinux-kallsyms.o
|
|
perf-y += openat-syscall.o
|
|
perf-y += openat-syscall-all-cpus.o
|
|
perf-y += openat-syscall-tp-fields.o
|
|
perf-y += mmap-basic.o
|
|
perf-y += perf-record.o
|
|
perf-y += evsel-roundtrip-name.o
|
|
perf-y += evsel-tp-sched.o
|
|
perf-y += fdarray.o
|
|
perf-y += pmu.o
|
|
perf-y += hists_common.o
|
|
perf-y += hists_link.o
|
|
perf-y += hists_filter.o
|
|
perf-y += hists_output.o
|
|
perf-y += hists_cumulate.o
|
|
perf-y += python-use.o
|
|
perf-y += bp_signal.o
|
|
perf-y += bp_signal_overflow.o
|
|
perf-y += task-exit.o
|
|
perf-y += sw-clock.o
|
|
perf-y += mmap-thread-lookup.o
|
|
perf-y += thread-mg-share.o
|
|
perf-y += switch-tracking.o
|
|
perf-y += keep-tracking.o
|
|
perf-y += code-reading.o
|
|
perf-y += sample-parsing.o
|
|
perf-y += parse-no-sample-id-all.o
|
|
perf-y += kmod-path.o
|
|
perf-y += thread-map.o
|
|
perf-y += llvm.o llvm-src-base.o llvm-src-kbuild.o llvm-src-prologue.o llvm-src-relocation.o
|
|
perf-y += bpf.o
|
|
perf-y += topology.o
|
|
perf-y += cpumap.o
|
|
perf-y += stat.o
|
|
perf-y += event_update.o
|
|
|
|
$(OUTPUT)tests/llvm-src-base.c: tests/bpf-script-example.c tests/Build
|
|
$(call rule_mkdir)
|
|
$(Q)echo '#include <tests/llvm.h>' > $@
|
|
$(Q)echo 'const char test_llvm__bpf_base_prog[] =' >> $@
|
|
$(Q)sed -e 's/"/\\"/g' -e 's/\(.*\)/"\1\\n"/g' $< >> $@
|
|
$(Q)echo ';' >> $@
|
|
|
|
$(OUTPUT)tests/llvm-src-kbuild.c: tests/bpf-script-test-kbuild.c tests/Build
|
|
$(call rule_mkdir)
|
|
$(Q)echo '#include <tests/llvm.h>' > $@
|
|
$(Q)echo 'const char test_llvm__bpf_test_kbuild_prog[] =' >> $@
|
|
$(Q)sed -e 's/"/\\"/g' -e 's/\(.*\)/"\1\\n"/g' $< >> $@
|
|
$(Q)echo ';' >> $@
|
|
|
|
$(OUTPUT)tests/llvm-src-prologue.c: tests/bpf-script-test-prologue.c tests/Build
|
|
$(call rule_mkdir)
|
|
$(Q)echo '#include <tests/llvm.h>' > $@
|
|
$(Q)echo 'const char test_llvm__bpf_test_prologue_prog[] =' >> $@
|
|
$(Q)sed -e 's/"/\\"/g' -e 's/\(.*\)/"\1\\n"/g' $< >> $@
|
|
$(Q)echo ';' >> $@
|
|
|
|
$(OUTPUT)tests/llvm-src-relocation.c: tests/bpf-script-test-relocation.c tests/Build
|
|
$(call rule_mkdir)
|
|
$(Q)echo '#include <tests/llvm.h>' > $@
|
|
$(Q)echo 'const char test_llvm__bpf_test_relocation[] =' >> $@
|
|
$(Q)sed -e 's/"/\\"/g' -e 's/\(.*\)/"\1\\n"/g' $< >> $@
|
|
$(Q)echo ';' >> $@
|
|
|
|
ifeq ($(ARCH),$(filter $(ARCH),x86 arm arm64))
|
|
perf-$(CONFIG_DWARF_UNWIND) += dwarf-unwind.o
|
|
endif
|
|
|
|
CFLAGS_attr.o += -DBINDIR="BUILD_STR($(bindir_SQ))" -DPYTHON="BUILD_STR($(PYTHON_WORD))"
|
|
CFLAGS_python-use.o += -DPYTHONPATH="BUILD_STR($(OUTPUT)python)" -DPYTHON="BUILD_STR($(PYTHON_WORD))"
|
|
CFLAGS_dwarf-unwind.o += -fno-optimize-sibling-calls
|