Jeff Mahoney 2b79bc4f7e dup2: Fix return value with oldfd == newfd and invalid fd ...

The return value of dup2 when oldfd == newfd and the fd isn't valid is
not getting properly sign extended.  We end up with 4294967287 instead
of -EBADF.

I've reproduced this on SLE11 (2.6.27.21), openSUSE Factory
(2.6.29-rc5), and Ubuntu 9.04 (2.6.28).

This patch uses a signed int for the error value so it is properly
extended.

Commit 6c5d0512a091480c9f981162227fdb1c9d70e555 introduced this
regression.

Reported-by: Jiri Dluhos <jdluhos@novell.com>
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

2009-05-11 12:18:06 -07:00

..

9p

Fix a leak in failure exit in 9p ->get_sb()

2009-05-09 10:49:40 -04:00

adfs

fs/adfs: return f_fsid for statfs(2)

2009-04-02 19:05:08 -07:00

affs

Fix races around the access to ->s_options

2009-05-09 10:51:34 -04:00

afs

Fix races around the access to ->s_options

2009-05-09 10:51:34 -04:00

autofs

Fix autofs_expire()

2009-04-20 23:01:15 -04:00

autofs4

autofs4: fix incorrect return in autofs4_mount_busy()

2009-05-02 15:36:09 -07:00

befs

befs: fix build on parisc

2009-04-08 10:21:43 -07:00

bfs

…

btrfs

Convert obvious places to deactivate_locked_super()

2009-05-09 10:49:40 -04:00

cachefiles

CacheFiles: A cache that backs onto a mounted filesystem

2009-04-03 16:42:41 +01:00

cifs

Convert obvious places to deactivate_locked_super()

2009-05-09 10:49:40 -04:00

coda

constify dentry_operations: misc filesystems

2009-03-27 14:44:00 -04:00

configfs

configfs: Fix Trivial Warning in fs/configfs/symlink.c

2009-04-21 12:59:21 -07:00

cramfs

fs/cramfs: return f_fsid for statfs(2)

2009-04-02 19:05:08 -07:00

debugfs

debugfs: function to know if debugfs is initialized

2009-03-23 16:25:46 +01:00

devpts

Convert obvious places to deactivate_locked_super()

2009-05-09 10:49:40 -04:00

dlm

dlm: fix length calculation in compat code

2009-03-11 12:23:59 -05:00

ecryptfs

Convert obvious places to deactivate_locked_super()

2009-05-09 10:49:40 -04:00

efs

fs/efs: return f_fsid for statfs(2)

2009-04-02 19:05:09 -07:00

exofs

exofs: Documentation

2009-03-31 19:44:38 +03:00

exportfs

…

ext2

ext2: missing unlock in ext2_quota_write()

2009-04-27 16:49:52 +02:00

ext3

ext3: Try to avoid starting a transaction in writepage for data=writepage

2009-04-08 13:15:10 -04:00

ext4

ext4: Do not try to validate extents on special files

2009-04-24 18:45:35 -04:00

fat

vfat: Note the NLS requirement

2009-04-17 09:32:11 -07:00

freevxfs

fs/Kconfig: move vxfs out

2009-01-22 13:15:58 +03:00

fscache

FS-Cache: Implement data I/O part of netfs API

2009-04-03 16:42:39 +01:00

fuse

vfs: umount_begin BKL pushdown

2009-05-09 10:49:38 -04:00

gfs2

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6

2009-05-10 10:49:08 -07:00

hfs

hfs: fix memory leak when unmounting

2009-04-13 15:04:29 -07:00

hfsplus

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6

2009-04-02 21:09:10 -07:00

hostfs

constify dentry_operations: misc filesystems

2009-03-27 14:44:00 -04:00

hpfs

Fix races around the access to ->s_options

2009-05-09 10:51:34 -04:00

hppfs

hppfs: hppfs_read_file() may return -ERROR

2009-04-02 19:04:53 -07:00

hugetlbfs

hugetlbfs: return negative error code for bad mount option

2009-04-21 13:41:48 -07:00

isofs

fs/isofs: return f_fsid for statfs(2)

2009-04-02 19:05:09 -07:00

jbd

Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4

2009-04-24 08:37:40 -07:00

jbd2

jbd2: use SWRITE_SYNC_PLUG when writing synchronous revoke records

2009-04-14 07:50:56 -04:00

jffs2

Merge git://git.infradead.org/mtd-2.6

2009-04-06 14:56:26 -07:00

jfs

New helper - current_umask()

2009-03-31 23:00:26 -04:00

lockd

Merge branch 'for-2.6.30' of git://linux-nfs.org/~bfields/linux

2009-04-06 13:25:56 -07:00

minix

fs/minix: return f_fsid for statfs(2)

2009-04-02 19:05:09 -07:00

ncpfs

ncpfs: use memdup_user()

2009-04-20 23:02:51 -04:00

nfs

Convert obvious places to deactivate_locked_super()

2009-05-09 10:49:40 -04:00

nfs_common

…

nfsd

Fix i_mutex vs. readdir handling in nfsd

2009-04-20 23:01:16 -04:00

nilfs2

nilfs2: fix possible mismatch of sufile counters on recovery

2009-04-13 09:53:52 +09:00

nls

…

notify

inotify: use GFP_NOFS in kernel_event() to work around a lockdep false-positive

2009-05-06 16:36:09 -07:00

ntfs

ntfs: remove private wrapper of endian helpers

2009-04-01 08:59:18 -07:00

ocfs2

ocfs2: Use nd_set_link().

2009-05-09 10:49:40 -04:00

omfs

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6

2009-04-02 21:09:10 -07:00

openpromfs

…

partitions

Merge branch 'tracing/core-v2' into tracing-for-linus

2009-04-02 00:49:02 +02:00

proc

Convert obvious places to deactivate_locked_super()

2009-05-09 10:49:40 -04:00

qnx4

fs/qnx4: return f_fsid for statfs(2)

2009-04-02 19:05:10 -07:00

quota

quota: remove obsolete comments in fs/quota/Makefile

2009-04-27 16:49:52 +02:00

ramfs

ramfs: fix double freeing s_fs_info on failed mount

2009-04-07 07:39:59 -07:00

reiserfs

Fix races around the access to ->s_options

2009-05-09 10:51:34 -04:00

romfs

ROMFS: romfs_dev_read() error ignored

2009-05-09 10:49:41 -04:00

smbfs

constify dentry_operations: misc filesystems

2009-03-27 14:44:00 -04:00

squashfs

Merge branch 'kmemtrace-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip

2009-04-06 13:30:00 -07:00

sysfs

sysfs: use memdup_user()

2009-04-20 23:02:50 -04:00

sysv

fs/sysv: return f_fsid for statfs(2)

2009-04-02 19:05:10 -07:00

ubifs

Convert obvious places to deactivate_locked_super()

2009-05-09 10:49:40 -04:00

udf

udf: Don't write integrity descriptor too often

2009-04-02 13:36:28 +02:00

ufs

switch ufs directories to ufs_sync_file()

2009-05-09 10:49:42 -04:00

xfs

Merge branch 'for-linus' of git://oss.sgi.com/xfs/xfs

2009-05-02 16:52:50 -07:00

aio.c

aio: lookup_ioctx can return the wrong value when looking up a bogus context

2009-03-19 15:57:18 -07:00

anon_inodes.c

constify dentry_operations: rest

2009-03-27 14:44:03 -04:00

attr.c

vfs: Use lowercase names of quota functions

2009-03-26 02:18:35 +01:00

bad_inode.c

…

binfmt_aout.c

…

binfmt_elf_fdpic.c

ptrace: s/parent/real_parent/ in binfmt_elf_fdpic.c

2009-05-02 15:36:10 -07:00

binfmt_elf.c

Trim includes in binfmt_elf

2009-03-31 23:00:27 -04:00

binfmt_em86.c

…

binfmt_flat.c

…

binfmt_misc.c

…

binfmt_script.c

…

binfmt_som.c

Don't crap into descriptor table in binfmt_som

2009-03-31 23:00:28 -04:00

bio-integrity.c

block: add private bio_set for bio integrity allocations

2009-03-24 12:35:17 +01:00

bio.c

bio: fix memcpy corruption in bio_copy_user_iov()

2009-04-28 20:24:29 +02:00

block_dev.c

Cleanup after commit 585d3bc06f4ca57f975a5a1f698f65a45ea66225

2009-04-01 07:07:16 -04:00

buffer.c

mm: close page_mkwrite races

2009-05-02 15:36:09 -07:00

char_dev.c

…

compat_binfmt_elf.c

…

compat_ioctl.c

fs/compat_ioctl: fix build when !BLOCK

2009-04-20 23:01:16 -04:00

compat.c

do_execve() must not clear fs->in_exec if it was set by another thread

2009-04-24 07:39:45 -07:00

dcache.c

fs: dcache fix LRU ordering

2009-05-09 10:49:40 -04:00

dcookies.c

…

direct-io.c

dio: Remove code handling bio_alloc failure with __GFP_WAIT

2009-04-15 12:10:13 +02:00

drop_caches.c

vfs: skip I_CLEAR state inodes

2009-04-02 19:04:48 -07:00

eventfd.c

epoll keyed wakeups: make eventfd use keyed wakeups

2009-04-01 08:59:20 -07:00

eventpoll.c

epoll keyed wakeups: teach epoll about hints coming with the wakeup key

2009-04-01 08:59:20 -07:00

exec.c

Switch open_exec() and sys_uselib() to do_open_filp()

2009-05-09 10:49:42 -04:00

fcntl.c

dup2: Fix return value with oldfd == newfd and invalid fd

2009-05-11 12:18:06 -07:00

fifo.c

…

file_table.c

trivial: remove unused variable 'path' in alloc_file()

2009-03-30 15:22:03 +02:00

file.c

…

filesystems.c

fs: Mark get_filesystem_list() as __init function.

2009-04-20 23:02:52 -04:00

fs_struct.c

Get rid of indirect include of fs_struct.h

2009-03-31 23:00:27 -04:00

fs-writeback.c

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial

2009-04-03 15:24:35 -07:00

generic_acl.c

New helper - current_umask()

2009-03-31 23:00:26 -04:00

inode.c

Make checkpatch.pl shut up on fs/inode.c

2009-05-09 10:49:41 -04:00

internal.h

New locking/refcounting for fs_struct

2009-03-31 23:00:26 -04:00

ioctl.c

fiemap: fix problem with setting FIEMAP_EXTENT_LAST

2009-05-06 16:36:09 -07:00

ioprio.c

…

Kconfig

nilfs2: update makefile and Kconfig

2009-04-07 08:31:16 -07:00

Kconfig.binfmt

…

libfs.c

Convert obvious places to deactivate_locked_super()

2009-05-09 10:49:40 -04:00

locks.c

…

Makefile

nilfs2: update makefile and Kconfig

2009-04-07 08:31:16 -07:00

mbcache.c

…

mpage.c

Remove two unneeded exports and make two symbols static in fs/mpage.c

2009-04-01 07:38:54 -04:00

namei.c

Switch open_exec() and sys_uselib() to do_open_filp()

2009-05-09 10:49:42 -04:00

namespace.c

Fix races around the access to ->s_options

2009-05-09 10:51:34 -04:00

nfsctl.c

…

no-block.c

…

open.c

Switch open_exec() and sys_uselib() to do_open_filp()

2009-05-09 10:49:42 -04:00

pipe.c

splice: add helpers for locking pipe inode

2009-04-15 12:10:12 +02:00

pnode.c

…

pnode.h

…

posix_acl.c

…

read_write.c

Make non-compat preadv/pwritev use native register size

2009-04-04 14:20:34 -07:00

read_write.h

…

readdir.c

…

select.c

…

seq_file.c

cpumask: fix seq_bitmap_*() functions.

2009-03-30 22:05:11 +10:30

signalfd.c

…

splice.c

splice: fix new kernel-doc warnings

2009-04-17 07:38:07 -07:00

stack.c

…

stat.c

kill vfs_stat_fd / vfs_lstat_fd

2009-04-20 23:02:52 -04:00

super.c

NULL noise in fs/super.c:kill_bdev_super()

2009-05-09 10:49:41 -04:00

sync.c

Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-quota-2.6

2009-03-27 14:48:34 -07:00

timerfd.c

timerfd: add flags check

2009-02-18 15:37:53 -08:00

utimes.c

…

xattr_acl.c

…

xattr.c

xattr: use memdup_user()

2009-04-20 23:02:50 -04:00