Vasu Dev c826a31457 [SCSI] fcoe: Out of order tx frames was causing several check condition SCSI status ... frames followed by these errors in log. [sdp] Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE,SUGGEST_OK [sdp] Sense Key : Aborted Command [current] [sdp] Add. Sense: Data phase error This was causing some test apps to exit due to write failure under heavy load. This was due to a race around adding and removing tx frame skb in fcoe_pending_queue, Chris Leech helped me to find that brief unlocking period when pulling skb from fcoe_pending_queue in various contexts (fcoe_watchdog and fcoe_xmit) and then adding skb back into fcoe_pending_queue up on a failed fcoe_start_io could change skb/tx frame order in fcoe_pending_queue. Thanks Chris. This patch allows only single context to pull skb from fcoe_pending_queue at any time to prevent above described ordering issue/race by use of fcoe_pending_queue_active flag. This patch simplified fcoe_watchdog with modified fcoe_check_wait_queue by use of FCOE_LOW_QUEUE_DEPTH instead previously used several conditionals to clear and set lp->qfull. I think FCOE_MAX_QUEUE_DEPTH with FCOE_LOW_QUEUE_DEPTH will work better in re/setting lp->qfull and these could be fine tuned for performance. Signed-off-by: Vasu Dev <vasu.dev@intel.com> Signed-off-by: Robert Love <robert.w.love@intel.com> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>		2009-03-10 09:09:21 -05:00
..
fc	[SCSI] fcoe: ETH_P_8021Q is already in if_ether and fcoe is not using it anyway	2009-03-10 09:07:09 -05:00
fc_encode.h	[SCSI] libfc: A modular Fibre Channel library	2008-12-29 11:24:33 -06:00
fc_frame.h	[SCSI] libfc: A modular Fibre Channel library	2008-12-29 11:24:33 -06:00
fc_transport_fcoe.h	[SCSI] fcoe: Fibre Channel over Ethernet	2008-12-29 11:24:33 -06:00
iscsi_if.h
iscsi_proto.h
libfc.h	[SCSI] libfc, fcoe: Fix kerneldoc comments	2009-03-10 09:04:40 -05:00
libfcoe.h	[SCSI] fcoe: Out of order tx frames was causing several check condition SCSI status	2009-03-10 09:09:21 -05:00
libiscsi_tcp.h	[SCSI] iscsi_tcp: make padbuf non-static	2009-01-13 10:41:34 -06:00
libiscsi.h
libsas.h
libsrp.h
sas_ata.h
sas.h
scsi_cmnd.h
scsi_dbg.h
scsi_device.h	[SCSI] add residual argument to scsi_execute and scsi_execute_req	2008-12-29 11:24:24 -06:00
scsi_devinfo.h
scsi_dh.h
scsi_driver.h
scsi_eh.h
scsi_host.h
scsi_ioctl.h
scsi_netlink_fc.h
scsi_netlink.h
scsi_tcq.h
scsi_tgt_if.h
scsi_tgt.h
scsi_transport_fc.h	[SCSI] fc transport: restore missing dev_loss_tmo callback to LLDD	2009-01-06 09:43:33 -06:00
scsi_transport_iscsi.h
scsi_transport_sas.h
scsi_transport_spi.h
scsi_transport_srp.h
scsi_transport.h
scsi.h
scsicam.h
sg.h
srp.h