Daniel Borkmann 3c2ce60bdd bpf: adjust verifier heuristics ... Current limits with regards to processing program paths do not really reflect today's needs anymore due to programs becoming more complex and verifier smarter, keeping track of more data such as const ALU operations, alignment tracking, spilling of PTR_TO_MAP_VALUE_ADJ registers, and other features allowing for smarter matching of what LLVM generates. This also comes with the side-effect that we result in fewer opportunities to prune search states and thus often need to do more work to prove safety than in the past due to different register states and stack layout where we mismatch. Generally, it's quite hard to determine what caused a sudden increase in complexity, it could be caused by something as trivial as a single branch somewhere at the beginning of the program where LLVM assigned a stack slot that is marked differently throughout other branches and thus causing a mismatch, where verifier then needs to prove safety for the whole rest of the program. Subsequently, programs with even less than half the insn size limit can get rejected. We noticed that while some programs load fine under pre 4.11, they get rejected due to hitting limits on more recent kernels. We saw that in the vast majority of cases (90+%) pruning failed due to register mismatches. In case of stack mismatches, majority of cases failed due to different stack slot types (invalid, spill, misc) rather than differences in spilled registers. This patch makes pruning more aggressive by also adding markers that sit at conditional jumps as well. Currently, we only mark jump targets for pruning. For example in direct packet access, these are usually error paths where we bail out. We found that adding these markers, it can reduce number of processed insns by up to 30%. Another option is to ignore reg->id in probing PTR_TO_MAP_VALUE_OR_NULL registers, which can help pruning slightly as well by up to 7% observed complexity reduction as stand-alone. Meaning, if a previous path with register type PTR_TO_MAP_VALUE_OR_NULL for map X was found to be safe, then in the current state a PTR_TO_MAP_VALUE_OR_NULL register for the same map X must be safe as well. Last but not least the patch also adds a scheduling point and bumps the current limit for instructions to be processed to a more adequate value. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Acked-by: Alexei Starovoitov <ast@kernel.org> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-05-17 22:55:27 -04:00
..
arraymap.c	bpf: map_get_next_key to return first key on NULL	2017-04-25 11:57:45 -04:00
bpf_lru_list.c	bpf: lru: Lower the PERCPU_NR_SCANS from 16 to 4	2017-04-17 13:55:52 -04:00
bpf_lru_list.h
cgroup.c	bpf: pass sk to helper functions	2017-04-11 14:54:19 -04:00
core.c	mm, vmalloc: use __GFP_HIGHMEM implicitly	2017-05-08 17:15:13 -07:00
hashtab.c	bpf: map_get_next_key to return first key on NULL	2017-04-25 11:57:45 -04:00
helpers.c	bpf: rename ARG_PTR_TO_STACK	2017-01-09 16:56:27 -05:00
inode.c	fs: constify tree_descr arrays passed to simple_fill_super()	2017-04-26 23:54:06 -04:00
lpm_trie.c	bpf: remove struct bpf_map_type_list	2017-04-11 14:38:43 -04:00
Makefile	bpf: Add array of maps support	2017-03-22 15:45:45 -07:00
map_in_map.c	bpf: Add array of maps support	2017-03-22 15:45:45 -07:00
map_in_map.h	bpf: Add array of maps support	2017-03-22 15:45:45 -07:00
percpu_freelist.c
percpu_freelist.h
stackmap.c	bpf: remove struct bpf_map_type_list	2017-04-11 14:38:43 -04:00
syscall.c	bpf: Add strict alignment flag for BPF_PROG_LOAD.	2017-05-11 14:19:00 -04:00
verifier.c	bpf: adjust verifier heuristics	2017-05-17 22:55:27 -04:00