Oleg Nesterov
4b105cbbaf
ptrace: do not use task_lock() for attach
...
Remove the "Nasty, nasty" lock dance in ptrace_attach()/ptrace_traceme() -
from now task_lock() has nothing to do with ptrace at all.
With the recent changes nobody uses task_lock() to serialize with ptrace,
but in fact it was never needed and it was never used consistently.
However ptrace_attach() calls __ptrace_may_access() and needs task_lock()
to pin task->mm for get_dumpable(). But we can call __ptrace_may_access()
before we take tasklist_lock, ->cred_exec_mutex protects us against
do_execve() path which can change creds and MMF_DUMP* flags.
(ugly, but we can't use ptrace_may_access() because it hides the error
code, so we have to take task_lock() and use __ptrace_may_access()).
NOTE: this change assumes that LSM hooks, security_ptrace_may_access() and
security_ptrace_traceme(), can be called without task_lock() held.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Chris Wright <chrisw@sous-sol.org>
Acked-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-06-18 13:03:51 -07:00
..
2009-06-12 13:50:23 +03:00
2009-06-16 19:47:40 -07:00
2009-06-15 10:06:19 -07:00
2009-06-16 13:09:51 -07:00
2009-01-14 14:15:19 +01:00
2009-06-08 12:31:53 -07:00
2009-06-11 21:36:01 -04:00
2009-04-05 13:49:04 -04:00
2009-01-04 15:14:41 -05:00
2009-05-06 16:36:09 -07:00
2009-04-05 13:49:04 -04:00
2009-01-14 14:15:19 +01:00
2009-04-02 19:04:54 -07:00
2008-11-12 17:17:16 -08:00
2009-06-18 13:03:46 -07:00
2009-04-30 19:24:24 +02:00
2008-10-20 08:52:34 -07:00
2009-03-30 22:05:12 +10:30
2009-06-16 19:47:31 -07:00
2008-11-14 10:39:23 +11:00
2009-05-11 08:15:36 +10:00
2008-12-18 13:54:01 +01:00
2009-01-21 18:51:53 +09:00
2008-10-16 11:21:30 -07:00
2009-03-31 23:00:27 -04:00
2009-06-18 13:03:51 -07:00
2009-04-05 11:04:19 -07:00
2009-06-15 12:40:03 +02:00
2008-10-30 11:38:45 -07:00
2008-11-14 10:39:19 +11:00
2009-05-20 10:34:32 +02:00
2009-06-16 19:47:48 -07:00
2009-06-17 09:46:33 -07:00
2009-02-11 11:04:16 +01:00
2009-02-05 13:04:33 +01:00
2009-06-09 22:37:52 +02:00
2008-10-20 08:52:34 -07:00
2008-07-28 14:37:38 +02:00
2008-12-25 09:31:28 +01:00
2009-06-12 21:32:31 +02:00
2009-06-16 19:47:47 -07:00
2009-05-15 07:56:24 -05:00
2009-05-26 12:11:19 -07:00
2009-05-08 16:23:48 -07:00
2009-01-06 10:44:31 -08:00
2009-06-16 19:47:31 -07:00
2009-02-11 10:18:04 +01:00
2009-05-12 19:59:52 +02:00
2009-02-14 23:28:28 +01:00
2009-02-14 23:27:59 +01:00
2009-05-07 11:17:34 +02:00
2009-06-16 19:47:48 -07:00
2008-11-16 09:52:03 +01:00
2009-06-16 11:07:14 -07:00
2009-01-14 18:09:02 +01:00
2009-01-14 18:09:02 +01:00
2009-06-11 17:55:42 +02:00
2009-01-14 18:09:02 +01:00
2008-11-26 08:22:50 +01:00
2009-04-02 19:04:53 -07:00
2008-11-24 18:57:41 -05:00
2009-05-16 13:41:28 -07:00
2009-06-12 21:46:58 +09:30
2009-06-12 14:28:52 +02:00
2009-04-02 19:04:58 -07:00
2009-04-02 19:05:02 -07:00
2008-09-02 19:21:40 -07:00
2009-04-30 08:08:31 +02:00
2009-01-14 14:15:20 +01:00
2009-06-16 11:02:28 -07:00
2009-06-16 19:47:32 -07:00
2009-06-18 13:03:51 -07:00
2009-04-03 12:23:02 +02:00
2009-04-15 13:55:14 -07:00
2008-12-18 21:56:04 +01:00
2009-05-05 20:28:05 +02:00
2009-03-30 22:05:16 +10:30
2009-04-14 11:33:43 +02:00
2009-04-14 11:33:43 +02:00
2009-04-03 12:23:03 +02:00
2009-04-05 11:04:19 -07:00
2009-06-18 13:03:48 -07:00
2009-04-18 21:44:24 -07:00
2009-04-06 11:14:02 +02:00
2008-07-21 21:55:02 -07:00
2009-06-12 18:01:50 +02:00
2009-05-09 10:08:19 +02:00
2009-06-11 19:27:12 +03:00
2009-03-30 22:05:17 +10:30
2009-03-24 23:16:51 +01:00
2009-04-09 08:19:08 +02:00
2009-03-30 17:17:35 -07:00
2009-05-15 15:32:45 +02:00
2009-06-09 22:30:27 +09:30
2009-03-24 23:16:51 +01:00
2009-06-15 10:06:19 -07:00
2009-03-02 15:41:30 -08:00
2008-08-05 14:33:47 -07:00
2009-06-18 13:03:51 -07:00
2009-06-16 19:47:49 -07:00
2009-06-09 22:30:27 +09:30
2009-06-18 13:03:40 -07:00
2009-01-16 14:06:04 +01:00
2009-04-02 19:05:11 -07:00
2008-12-25 11:44:43 +01:00
2009-03-30 22:05:17 +10:30
2009-01-21 16:37:27 +01:00
2009-06-16 19:47:48 -07:00
2009-02-01 01:04:33 -08:00
2009-06-16 19:50:13 -07:00
2009-01-01 10:12:28 +10:30
2009-01-06 15:59:20 -08:00
2009-01-14 14:15:18 +01:00
2009-06-15 10:06:19 -07:00
2009-03-18 19:55:00 +01:00
2009-03-09 08:13:35 -07:00
2009-01-14 14:15:26 +01:00
2009-01-12 16:04:37 +01:00
2009-02-27 16:26:21 -08:00
2009-06-15 21:30:23 -07:00
2009-04-02 19:05:01 -07:00
2008-08-23 12:14:12 -07:00
2009-04-14 17:17:16 +02:00
2009-06-02 01:10:40 +02:00