Oleg Nesterov 4b105cbbaf ptrace: do not use task_lock() for attach
Remove the "Nasty, nasty" lock dance in ptrace_attach()/ptrace_traceme() -
from now task_lock() has nothing to do with ptrace at all.

With the recent changes nobody uses task_lock() to serialize with ptrace,
but in fact it was never needed and it was never used consistently.

However ptrace_attach() calls __ptrace_may_access() and needs task_lock()
to pin task->mm for get_dumpable().  But we can call __ptrace_may_access()
before we take tasklist_lock, ->cred_exec_mutex protects us against
do_execve() path which can change creds and MMF_DUMP* flags.

(ugly, but we can't use ptrace_may_access() because it hides the error
code, so we have to take task_lock() and use __ptrace_may_access()).

NOTE: this change assumes that LSM hooks, security_ptrace_may_access() and
security_ptrace_traceme(), can be called without task_lock() held.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Chris Wright <chrisw@sous-sol.org>
Acked-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-06-18 13:03:51 -07:00
..
2008-10-16 11:21:30 -07:00
2009-06-15 12:40:03 +02:00
2009-05-20 10:34:32 +02:00
2009-06-16 19:47:48 -07:00
2008-07-28 14:37:38 +02:00
2009-05-15 07:56:24 -05:00
2009-06-16 19:47:48 -07:00
2009-01-14 18:09:02 +01:00
2008-09-02 19:21:40 -07:00
2009-03-30 22:05:16 +10:30
2009-06-16 19:47:48 -07:00
2009-06-16 19:50:13 -07:00
2009-06-15 21:30:23 -07:00
2009-04-14 17:17:16 +02:00