linux/drivers
Anatolij Gustschin b2639b5f1d drivers/video: fsl-diu-fb: fix bugs in interrupt handling
Since commit f74de500 "drivers/video: fsl-diu-fb: streamline
enabling of interrupts" the interrupt handling in the driver
is broken. Enabling diu interrupt causes an interrupt storm and
results in system lockup.

The cookie for the interrupt handler function passed to request_irq()
is wrong (it must be a pointer to the diu struct, and not the address
of the pointer to the diu struct). As a result the interrupt handler
can not read diu registers and acknowledge the interrupt. Fix cookie
arguments for request_irq() and free_irq().

Registering the diu interrupt handler in probe() must happen before
install_fb() calls since this function registers framebuffer devices
and if fbcon tries to take over framebuffer after registering a frame
buffer device, it will call fb_open of the diu driver and enable the
interrupts. At this time the diu interrupt handler must be registered
already.

Disabling the interrupts in fsl_diu_release() must happen only if all
other AOIs are closed. Otherwise closing an overlay plane will disable
the interrupts even if the primary frame buffer plane is opened. Add
an appropriate check in the release function.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
Cc: Timur Tabi <timur@tabi.org>
Cc: stable@vger.kernel.org
2013-01-29 08:29:57 +00:00
..
accessibility
acpi
amba
ata powerpc, dma: move bestcomm driver from arch/powerpc/sysdev to drivers/dma 2013-01-03 15:41:20 +01:00
atm
auxdisplay
base
bcma
block
bluetooth
bus
cdrom
char
clk
clocksource
connector
cpufreq
cpuidle
crypto
dca
devfreq
dio
dma powerpc, dma: move bestcomm driver from arch/powerpc/sysdev to drivers/dma 2013-01-03 15:41:20 +01:00
edac
eisa
extcon
firewire
firmware
gpio
gpu
hid
hsi
hv
hwmon
hwspinlock
i2c
ide
idle
iio
infiniband
input
iommu
ipack
irqchip
isdn
leds
lguest
macintosh
md
media
memory
memstick
message
mfd
misc
mmc
mtd
net powerpc, dma: move bestcomm driver from arch/powerpc/sysdev to drivers/dma 2013-01-03 15:41:20 +01:00
nfc
nubus
of
oprofile
parisc
parport
pci
pcmcia
pinctrl
platform
pnp
power
pps
ps3
ptp
pwm
rapidio
regulator
remoteproc
rpmsg
rtc
s390
sbus
scsi
sfi
sh
sn
spi
ssb
staging
target
tc
thermal
tty
uio
usb
uwb
vfio
vhost
video drivers/video: fsl-diu-fb: fix bugs in interrupt handling 2013-01-29 08:29:57 +00:00
virt
virtio
vlynq
vme
w1
watchdog
xen
zorro
Kconfig
Makefile powerpc, dma: move bestcomm driver from arch/powerpc/sysdev to drivers/dma 2013-01-03 15:41:20 +01:00