mirror of
https://github.com/FEX-Emu/linux.git
synced 2024-12-16 22:10:24 +00:00
0f940cb7d9
Both python_scripting_ops and perl_scripting_ops have two global definitions. One in trace-event-scripting.c and one in their respective scripting-engine modules. The issue is that depending on the linker order one definition or the other is chosen. One is uninitialized (bss), while the other is initialized. If the uninitialized version is chosen, then perf does not function properly. This patch fixes this by adding the extern prefix to the definitions in trace-event-scripting.c. Cc: David S. Miller <davem@davemloft.net> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Robert Richter <robert.richter@amd.com> LKML-Reference: <4c97e41a.078fd80a.7a8b.3cc9@mx.google.com> Signed-off-by: Stephane Eranian <eranian@google.com> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
168 lines
4.2 KiB
C
168 lines
4.2 KiB
C
/*
|
|
* trace-event-scripting. Scripting engine common and initialization code.
|
|
*
|
|
* Copyright (C) 2009-2010 Tom Zanussi <tzanussi@gmail.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <ctype.h>
|
|
#include <errno.h>
|
|
|
|
#include "../perf.h"
|
|
#include "util.h"
|
|
#include "trace-event.h"
|
|
|
|
struct scripting_context *scripting_context;
|
|
|
|
static int stop_script_unsupported(void)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static void process_event_unsupported(int cpu __unused,
|
|
void *data __unused,
|
|
int size __unused,
|
|
unsigned long long nsecs __unused,
|
|
char *comm __unused)
|
|
{
|
|
}
|
|
|
|
static void print_python_unsupported_msg(void)
|
|
{
|
|
fprintf(stderr, "Python scripting not supported."
|
|
" Install libpython and rebuild perf to enable it.\n"
|
|
"For example:\n # apt-get install python-dev (ubuntu)"
|
|
"\n # yum install python-devel (Fedora)"
|
|
"\n etc.\n");
|
|
}
|
|
|
|
static int python_start_script_unsupported(const char *script __unused,
|
|
int argc __unused,
|
|
const char **argv __unused)
|
|
{
|
|
print_python_unsupported_msg();
|
|
|
|
return -1;
|
|
}
|
|
|
|
static int python_generate_script_unsupported(const char *outfile __unused)
|
|
{
|
|
print_python_unsupported_msg();
|
|
|
|
return -1;
|
|
}
|
|
|
|
struct scripting_ops python_scripting_unsupported_ops = {
|
|
.name = "Python",
|
|
.start_script = python_start_script_unsupported,
|
|
.stop_script = stop_script_unsupported,
|
|
.process_event = process_event_unsupported,
|
|
.generate_script = python_generate_script_unsupported,
|
|
};
|
|
|
|
static void register_python_scripting(struct scripting_ops *scripting_ops)
|
|
{
|
|
int err;
|
|
err = script_spec_register("Python", scripting_ops);
|
|
if (err)
|
|
die("error registering Python script extension");
|
|
|
|
err = script_spec_register("py", scripting_ops);
|
|
if (err)
|
|
die("error registering py script extension");
|
|
|
|
scripting_context = malloc(sizeof(struct scripting_context));
|
|
}
|
|
|
|
#ifdef NO_LIBPYTHON
|
|
void setup_python_scripting(void)
|
|
{
|
|
register_python_scripting(&python_scripting_unsupported_ops);
|
|
}
|
|
#else
|
|
extern struct scripting_ops python_scripting_ops;
|
|
|
|
void setup_python_scripting(void)
|
|
{
|
|
register_python_scripting(&python_scripting_ops);
|
|
}
|
|
#endif
|
|
|
|
static void print_perl_unsupported_msg(void)
|
|
{
|
|
fprintf(stderr, "Perl scripting not supported."
|
|
" Install libperl and rebuild perf to enable it.\n"
|
|
"For example:\n # apt-get install libperl-dev (ubuntu)"
|
|
"\n # yum install 'perl(ExtUtils::Embed)' (Fedora)"
|
|
"\n etc.\n");
|
|
}
|
|
|
|
static int perl_start_script_unsupported(const char *script __unused,
|
|
int argc __unused,
|
|
const char **argv __unused)
|
|
{
|
|
print_perl_unsupported_msg();
|
|
|
|
return -1;
|
|
}
|
|
|
|
static int perl_generate_script_unsupported(const char *outfile __unused)
|
|
{
|
|
print_perl_unsupported_msg();
|
|
|
|
return -1;
|
|
}
|
|
|
|
struct scripting_ops perl_scripting_unsupported_ops = {
|
|
.name = "Perl",
|
|
.start_script = perl_start_script_unsupported,
|
|
.stop_script = stop_script_unsupported,
|
|
.process_event = process_event_unsupported,
|
|
.generate_script = perl_generate_script_unsupported,
|
|
};
|
|
|
|
static void register_perl_scripting(struct scripting_ops *scripting_ops)
|
|
{
|
|
int err;
|
|
err = script_spec_register("Perl", scripting_ops);
|
|
if (err)
|
|
die("error registering Perl script extension");
|
|
|
|
err = script_spec_register("pl", scripting_ops);
|
|
if (err)
|
|
die("error registering pl script extension");
|
|
|
|
scripting_context = malloc(sizeof(struct scripting_context));
|
|
}
|
|
|
|
#ifdef NO_LIBPERL
|
|
void setup_perl_scripting(void)
|
|
{
|
|
register_perl_scripting(&perl_scripting_unsupported_ops);
|
|
}
|
|
#else
|
|
extern struct scripting_ops perl_scripting_ops;
|
|
|
|
void setup_perl_scripting(void)
|
|
{
|
|
register_perl_scripting(&perl_scripting_ops);
|
|
}
|
|
#endif
|