Dan Williams 5f1a38952b serial/8250_pci: fix suspend/resume vs init/exit quirks ... Commit e86ff4a6 "serial/8250_pci: init-quirk msi support for kt serial controller" introduced a regression in suspend/resume by causing msi's to be enabled twice without an intervening disable. 00:16.3 Serial controller: Intel Corporation Patsburg KT Controller (rev 05) (prog-if 02 [16550]) Subsystem: Intel Corporation Device 7270 Flags: bus master, 66MHz, fast devsel, latency 0, IRQ 72 I/O ports at 4080 [size=8] Memory at d1c30000 (32-bit, non-prefetchable) [size=4K] Capabilities: [c8] Power Management version 3 Capabilities: [d0] MSI: Enable+ Count=1/1 Maskable- 64bit+ Kernel driver in use: serial [ 365.250523] sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:16.3/msi_irqs' [ 365.250525] Modules linked in: nls_utf8 ipv6 uinput sg iTCO_wdt iTCO_vendor_support ioatdma dca i2c_i801 i2c_core wmi sd_mod ahci libahci isci libsas libata scsi_transport_sas [last unloaded: scsi_wait_scan] [ 365.250540] Pid: 9030, comm: kworker/u:1 Tainted: G W 3.3.0-isci-3.0.213+ #1 [ 365.250542] Call Trace: [ 365.250545] [<ffffffff8115e955>] ? sysfs_add_one+0x99/0xad [ 365.250548] [<ffffffff8102db8b>] warn_slowpath_common+0x85/0x9e [ 365.250551] [<ffffffff8102dc96>] warn_slowpath_fmt+0x6e/0x70 [ 365.250555] [<ffffffff8115e8fa>] ? sysfs_add_one+0x3e/0xad [ 365.250558] [<ffffffff8115e8b4>] ? sysfs_pathname+0x3c/0x44 [ 365.250561] [<ffffffff8115e8b4>] ? sysfs_pathname+0x3c/0x44 [ 365.250564] [<ffffffff8115e8b4>] ? sysfs_pathname+0x3c/0x44 [ 365.250567] [<ffffffff8115e8b4>] ? sysfs_pathname+0x3c/0x44 [ 365.250570] [<ffffffff8115e955>] sysfs_add_one+0x99/0xad [ 365.250573] [<ffffffff8115f031>] create_dir+0x72/0xa5 [ 365.250577] [<ffffffff8115f194>] sysfs_create_dir+0xa2/0xbe [ 365.250581] [<ffffffff81262463>] kobject_add_internal+0x126/0x1f8 [ 365.250585] [<ffffffff8126255b>] kset_register+0x26/0x3f [ 365.250588] [<ffffffff8126275a>] kset_create_and_add+0x62/0x7c [ 365.250592] [<ffffffff81293619>] populate_msi_sysfs+0x34/0x103 [ 365.250595] [<ffffffff81293e1c>] pci_enable_msi_block+0x1b3/0x216 [ 365.250599] [<ffffffff81303f7c>] try_enable_msi+0x13/0x17 [ 365.250603] [<ffffffff81303fb3>] pciserial_resume_ports+0x21/0x42 [ 365.250607] [<ffffffff81304041>] pciserial_resume_one+0x50/0x57 [ 365.250610] [<ffffffff81283e1a>] pci_legacy_resume+0x38/0x47 [ 365.250613] [<ffffffff81283e7d>] pci_pm_restore+0x54/0x87 [ 365.250616] [<ffffffff81283e29>] ? pci_legacy_resume+0x47/0x47 [ 365.250619] [<ffffffff8131e9e8>] dpm_run_callback+0x48/0x7b [ 365.250623] [<ffffffff8131f39a>] device_resume+0x342/0x394 [ 365.250626] [<ffffffff8131f5b7>] async_resume+0x21/0x49 That patch has since been reverted, but by inspection it seems that pciserial_suspend_ports() should be invoking .exit() quirks to release resources acquired during .init(). Acked-by: Alan Cox <alan@linux.intel.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2012-04-18 16:26:46 -07:00
..
hvc	TTY: hvc, fix TTY refcounting	2012-04-13 10:54:43 -07:00
ipwireless	TTY: ipwireless, use tty from tty_port	2012-04-09 11:30:39 -07:00
serial	serial/8250_pci: fix suspend/resume vs init/exit quirks	2012-04-18 16:26:46 -07:00
vt	Merge 3.4-rc3 into tty-next	2012-04-18 15:57:31 -07:00
amiserial.c	Remove all #inclusions of asm/system.h	2012-03-28 18:30:03 +01:00
bfin_jtag_comm.c	TTY: bfin_jtag_comm, use tty from tty_port	2012-04-09 11:28:18 -07:00
cyclades.c	TTY: remove unneeded tty->index checks	2012-03-08 11:42:21 -08:00
ehv_bytechan.c	TTY: remove re-assignments to tty_driver members	2012-03-08 11:37:58 -08:00
isicom.c	Documentation: remove references to /etc/modprobe.conf	2012-03-30 16:03:15 -07:00
Kconfig	tty/powerpc: early udbg consoles can't be modules	2012-02-24 16:11:50 -08:00
Makefile	tty/powerpc: introduce the ePAPR embedded hypervisor byte channel driver	2011-08-23 10:32:56 -07:00
moxa.c	Remove all #inclusions of asm/system.h	2012-03-28 18:30:03 +01:00
moxa.h	tty: move a number of tty drivers from drivers/char/ to drivers/tty/	2011-02-22 16:14:56 -08:00
mxser.c	Remove all #inclusions of asm/system.h	2012-03-28 18:30:03 +01:00
mxser.h	Fix common misspellings	2011-03-31 11:26:23 -03:00
n_gsm.c	TTY: remove re-assignments to tty_driver members	2012-03-08 11:37:58 -08:00
n_hdlc.c	Remove all #inclusions of asm/system.h	2012-03-28 18:30:03 +01:00
n_r3964.c	Revert "tty: make receive_buf() return the amout of bytes received"	2011-06-04 06:33:24 +09:00
n_tracerouter.c	n_tracerouter and n_tracesink ldisc additions.	2011-05-13 16:31:00 -07:00
n_tracesink.c	n_tracerouter and n_tracesink ldisc additions.	2011-05-13 16:31:00 -07:00
n_tracesink.h	n_tracerouter and n_tracesink ldisc additions.	2011-05-13 16:31:00 -07:00
n_tty.c	Remove all #inclusions of asm/system.h	2012-03-28 18:30:03 +01:00
nozomi.c	TTY: remove re-assignments to tty_driver members	2012-03-08 11:37:58 -08:00
pty.c	Remove all #inclusions of asm/system.h	2012-03-28 18:30:03 +01:00
rocket_int.h	tty: move a number of tty drivers from drivers/char/ to drivers/tty/	2011-02-22 16:14:56 -08:00
rocket.c	TTY: remove unneeded tty->index checks	2012-03-08 11:42:21 -08:00
rocket.h	tty: move a number of tty drivers from drivers/char/ to drivers/tty/	2011-02-22 16:14:56 -08:00
synclink_gt.c	Remove all #inclusions of asm/system.h	2012-03-28 18:30:03 +01:00
synclink.c	Remove all #inclusions of asm/system.h	2012-03-28 18:30:03 +01:00
synclinkmp.c	Remove all #inclusions of asm/system.h	2012-03-28 18:30:03 +01:00
sysrq.c	sysrq: use SEND_SIG_FORCED instead of force_sig()	2012-04-05 15:25:50 -07:00
tty_audit.c	tty_audit: fix tty_audit_add_data live lock on audit disabled	2011-03-07 12:04:50 -08:00
tty_buffer.c	tty: hold lock across tty buffer finding and buffer filling	2012-04-09 12:12:45 -07:00
tty_io.c	Remove all #inclusions of asm/system.h	2012-03-28 18:30:03 +01:00
tty_ioctl.c	Remove all #inclusions of asm/system.h	2012-03-28 18:30:03 +01:00
tty_ldisc.c	Merge 3.2-rc3 into tty-next to handle merge conflict in tty_ldisc.c	2011-11-26 20:07:25 -08:00
tty_mutex.c	TTY: remove tty_locked	2011-08-23 10:34:07 -07:00
tty_port.c	TTY: fix UV serial console regression	2012-01-24 12:55:37 -08:00