Glauber Costa
61065a30af
fs/buffer.c: remove BUG() in possible but rare condition ...
While stressing the kernel with with failing allocations today, I hit the
following chain of events:
alloc_page_buffers():
bh = alloc_buffer_head(GFP_NOFS);
if (!bh)
goto no_grow; <= path taken
grow_dev_page():
bh = alloc_page_buffers(page, size, 0);
if (!bh)
goto failed; <= taken, consequence of the above
and then the failed path BUG()s the kernel.
The failure is inserted a litte bit artificially, but even then, I see no
reason why it should be deemed impossible in a real box.
Even though this is not a condition that we expect to see around every
time, failed allocations are expected to be handled, and BUG() sounds just
too much. As a matter of fact, grow_dev_page() can return NULL just fine
in other circumstances, so I propose we just remove it, then.
Signed-off-by: Glauber Costa <glommer@parallels.com>
Cc: Michal Hocko <mhocko@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2012-04-25 21:26:33 -07:00
2012-03-28 09:58:38 -07:00
2012-03-20 21:29:35 -04:00
2012-03-20 21:29:35 -04:00
2012-03-21 13:36:41 -07:00
2012-03-29 18:12:23 -07:00
2012-03-20 21:29:35 -04:00
2012-03-20 21:29:35 -04:00
2012-04-17 13:21:50 -07:00
2012-03-20 21:29:41 -04:00
2012-03-28 10:01:29 -07:00
2012-04-13 10:03:29 -05:00
2012-03-28 18:30:03 +01:00
2012-03-20 21:29:48 -04:00
2012-03-21 13:36:41 -07:00
2012-04-05 15:25:50 -07:00
2012-03-21 13:36:41 -07:00
2012-04-05 15:25:50 -07:00
2012-03-20 21:29:49 -04:00
2012-03-20 21:29:35 -04:00
2012-03-28 20:04:27 -07:00
2012-03-31 16:03:16 -04:00
2012-03-31 16:03:16 -04:00
2012-04-17 13:30:34 -07:00
2012-03-23 16:58:40 -07:00
2012-03-20 21:29:35 -04:00
2012-04-18 17:29:05 -07:00
2012-04-11 11:04:45 -07:00
2012-03-20 21:29:35 -04:00
2012-03-20 21:29:53 -04:00
2012-03-27 18:29:53 -07:00
2012-03-20 21:29:35 -04:00
2012-03-20 21:29:35 -04:00
2012-04-05 15:25:50 -07:00
2012-03-20 21:29:35 -04:00
2012-03-21 10:15:51 -07:00
2012-03-28 15:58:21 -07:00
2012-03-30 17:31:56 -07:00
2012-03-20 21:29:48 -04:00
2012-04-13 13:50:52 -04:00
2012-03-21 13:36:41 -07:00
2012-03-21 13:36:41 -07:00
2012-03-28 18:30:03 +01:00
2012-03-28 19:02:35 -07:00
2012-04-19 14:54:52 -07:00
2012-03-21 13:36:41 -07:00
2012-03-23 16:58:31 -07:00
2012-03-21 13:36:41 -07:00
2012-04-13 12:31:43 -04:00
2012-03-20 21:29:35 -04:00
2012-03-20 21:29:35 -04:00
2012-04-12 15:16:26 -07:00
2012-04-05 15:30:34 -07:00
2012-03-20 21:29:52 -04:00
2012-03-20 21:29:38 -04:00
2012-03-28 10:00:14 -07:00
2012-03-20 21:29:37 -04:00
2012-03-28 15:58:21 -07:00
2012-03-30 17:31:56 -07:00
2012-03-28 18:05:54 -07:00
2012-04-10 14:48:51 -07:00
2012-03-20 21:29:35 -04:00
2012-03-23 09:27:40 -07:00
2012-03-28 10:00:14 -07:00
2012-03-28 18:30:03 +01:00
2012-03-28 15:58:21 -07:00
2012-04-21 01:58:20 -04:00
2012-03-20 21:29:45 -04:00
2012-02-28 19:31:58 -05:00
2012-02-28 19:31:58 -05:00
2012-04-20 17:29:13 -07:00
2012-04-20 17:29:13 -07:00
2012-04-20 17:29:13 -07:00
2012-03-20 21:29:46 -04:00
2012-04-20 17:29:13 -07:00
2012-03-23 16:58:31 -07:00
2012-03-20 21:29:46 -04:00
2012-04-20 17:29:13 -07:00
2012-03-20 21:48:21 +08:00
2012-02-28 19:31:58 -05:00
2012-03-23 16:58:31 -07:00
2012-04-25 21:26:33 -07:00
2012-03-24 10:24:31 -07:00
2012-03-29 18:12:23 -07:00
2012-03-28 09:54:34 -07:00
2012-02-28 19:31:58 -05:00
2012-02-23 15:56:21 -08:00
2012-02-28 19:31:58 -05:00
2012-04-25 21:26:33 -07:00
2012-04-04 10:04:42 -07:00
2012-02-19 10:30:52 -08:00
2012-01-06 23:16:53 -05:00
2012-03-20 21:29:32 -04:00
2012-03-29 18:12:23 -07:00
2012-03-24 10:24:31 -07:00
2012-03-28 10:07:27 -07:00
2012-03-20 21:29:51 -04:00
2012-01-06 23:20:12 -05:00
2012-02-28 19:31:58 -05:00
2012-02-07 07:51:30 +01:00
2012-03-21 13:36:41 -07:00
2012-01-10 16:30:51 -08:00
2012-04-09 01:39:22 -04:00
2012-04-01 13:54:27 -05:00
2012-03-20 21:29:38 -04:00
2012-01-06 23:20:12 -05:00
2012-02-28 19:31:58 -05:00
2012-04-06 13:54:56 -07:00
2012-01-08 13:21:22 -08:00
2012-02-19 10:30:52 -08:00
2012-03-23 16:58:31 -07:00
2012-02-28 19:31:58 -05:00
2012-01-06 23:19:54 -05:00
2012-02-28 19:31:58 -05:00
2012-02-28 19:31:58 -05:00
2012-03-29 18:12:23 -07:00
2012-03-24 10:24:31 -07:00
2012-02-24 11:42:50 -08:00
2012-04-05 19:04:27 -04:00
2012-02-28 19:31:58 -05:00
2012-03-24 10:24:31 -07:00
2012-02-28 19:31:58 -05:00
2012-03-24 10:24:31 -07:00
2012-02-28 19:31:58 -05:00
2012-02-28 19:31:58 -05:00
2012-04-05 15:25:50 -07:00
61065a30af