James Bottomley
64976a0387
[SCSI] aha152x: Fix oops on module removal
Reported-by: Frank de Jong <frapex@xs4all.nl>
> after trying to unload the module:
> BUG: unable to handle kernel paging request at 00100100
> IP: [<fb9ff667>] :aha152x:aha152x_exit+0x47/0x6a
> *pde = 00000000
> Oops: 0000 [#1] PREEMPT SMP
> Modules linked in: aha152x(-) w83781d hwmon_vid tun ne 8390 bonding
> usb_storage snd_usb_audio snd_usb_lib snd_rawmidi pwc snd_seq_device
> compat_ioctl32 snd_hwdep videodev v4l1_compat 3c59x mii intel_agp
> agpgart snd_pcm_oss snd_pcm snd_timer snd_page_alloc snd_mixer_oss snd
>
> Pid: 2837, comm: rmmod Not tainted (2.6.25.3 #1)
> EIP: 0060:[<fb9ff667>] EFLAGS: 00210212 CPU: 0
> EIP is at aha152x_exit+0x47/0x6a [aha152x]
> EAX: 00000001 EBX: 000ffdc4 ECX: f7c517a8 EDX: 00000001
> ESI: 00000000 EDI: 00000003 EBP: e7880000 ESP: e7881f58
> DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
> Process rmmod (pid: 2837, ti=e7880000 task=f27eb580 task.ti=e7880000)
> Stack: fba03700 c01419d2 31616861 00783235 e795ee70 c0157709 b7f24000 e79ae000
> c0158271 ffffffff b7f25000 e79ae004 e795e370 b7f25000 e795e37c e795e370
> 009ae000 fba03700 00000880 e7881fa8 00000000 bf93ec20 bf93ec20 c0102faa
> Call Trace:
> [<c01419d2>] sys_delete_module+0x112/0x1a0
> [<c0157709>] remove_vma+0x39/0x50
> [<c0158271>] do_munmap+0x181/0x1f0
> [<c0102faa>] sysenter_past_esp+0x5f/0x85
> [<c0490000>] rsc_parse+0x0/0x3c0
The problem is that the driver calls aha152x_release() under a
list_for_each_entry(). Unfortunately, aha152x_release() deletes from
the list in question. Fix this by using list_for_each_entry_safe().
Cc: Stable Tree <stable@kernel.org>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
2008-05-11 08:36:44 -05:00
..
2008-05-02 13:06:44 -05:00
2008-04-28 17:31:13 -07:00
2008-05-02 13:26:46 -05:00
2008-04-19 19:10:33 -07:00
2008-04-07 12:15:40 -05:00
2008-05-02 13:17:01 -05:00
2008-05-02 10:18:22 -05:00
2008-04-18 11:25:31 -07:00
2008-04-22 15:16:30 -05:00
2008-05-02 13:07:56 -05:00
2008-04-19 19:10:33 -07:00
2008-04-27 12:19:59 -05:00
2008-04-07 12:19:00 -05:00
2008-04-28 17:31:13 -07:00
2008-01-11 18:22:30 -06:00
2008-04-19 19:10:33 -07:00
2007-07-21 08:57:40 -05:00
2008-04-19 19:10:33 -07:00
2008-05-02 10:18:22 -05:00
2007-06-17 16:15:56 -05:00
2008-05-02 10:18:22 -05:00
2007-06-17 16:09:29 -05:00
2008-04-07 12:19:07 -05:00
2008-04-07 12:19:01 -05:00
2007-10-12 14:41:00 -04:00
2008-03-07 10:05:43 -06:00
2008-05-11 08:36:44 -05:00
2007-08-04 09:11:06 -05:00
2008-04-27 12:19:55 -05:00
2008-01-30 13:14:02 -06:00
2008-02-06 10:41:01 -08:00
2008-01-11 18:28:57 -06:00
2007-11-25 12:19:26 +02:00
2007-05-04 17:59:05 -07:00
2008-01-11 18:22:38 -06:00
2008-04-07 12:15:44 -05:00
2008-04-07 12:15:44 -05:00
2007-10-12 14:41:00 -04:00
2008-04-19 19:10:33 -07:00
2008-05-02 11:33:25 -05:00
2008-04-07 12:15:40 -05:00
2008-05-02 13:52:35 -07:00
2008-05-02 13:17:01 -05:00
2007-11-25 12:19:26 +02:00
2007-03-20 11:27:03 -05:00
2008-04-07 12:15:40 -05:00
2008-04-25 09:52:30 -05:00
2008-04-27 12:19:57 -05:00
2008-04-27 12:19:57 -05:00
2008-01-11 18:22:35 -06:00
2008-04-28 17:31:13 -07:00
2008-04-27 12:19:55 -05:00
2007-11-25 12:19:26 +02:00
2008-02-18 09:02:25 -06:00
2007-10-12 14:55:46 -04:00
2008-05-08 10:01:53 -05:00
2008-04-07 12:15:36 -05:00
2008-04-07 12:19:07 -05:00
2008-04-27 12:19:54 -05:00
2008-05-02 10:18:22 -05:00
2008-01-11 18:28:06 -06:00
2008-01-30 13:14:02 -06:00
2008-04-28 23:44:41 +02:00
2008-01-11 18:22:41 -06:00
2008-01-11 18:22:36 -06:00
2008-05-02 10:18:22 -05:00
2007-05-22 11:08:56 -05:00
2008-04-29 19:34:07 -05:00
2007-05-08 11:54:40 -05:00
2008-04-07 12:19:11 -05:00
2008-01-11 18:27:59 -06:00
2008-04-18 11:53:24 -05:00
2008-01-11 18:28:48 -06:00
2008-04-27 12:33:04 -05:00
2008-05-05 12:38:50 -07:00
2007-07-19 10:04:50 -07:00
2008-05-08 20:38:57 -05:00
2008-01-30 13:03:40 -06:00
2008-01-30 13:14:02 -06:00
2008-04-27 12:19:57 -05:00
2008-04-07 12:15:40 -05:00
2008-04-27 12:19:57 -05:00
2008-04-29 08:06:18 -07:00
2007-05-08 11:15:08 -05:00
2008-02-23 10:40:04 -08:00
2007-10-12 14:41:00 -04:00
2008-04-07 12:19:07 -05:00
2008-05-01 08:04:03 -07:00
2008-05-01 08:04:02 -07:00
2007-10-12 14:51:18 -04:00
2008-01-30 13:14:02 -06:00
2008-01-23 13:44:31 -06:00
2007-10-12 14:55:07 -04:00
2007-10-12 14:41:00 -04:00
2007-07-19 10:04:50 -07:00
2008-01-30 13:14:02 -06:00
2007-10-19 11:53:42 -07:00
2008-04-19 19:10:33 -07:00
2007-10-12 14:50:55 -04:00
2007-11-25 12:19:26 +02:00
2008-01-11 18:22:41 -06:00
2008-04-07 12:19:02 -05:00
2008-05-02 10:18:22 -05:00
2007-10-23 12:35:35 -04:00
2007-10-22 21:19:53 +02:00
2008-01-30 13:14:02 -06:00
2008-02-23 09:07:32 -06:00
2007-10-12 14:52:38 -04:00
2008-04-19 19:10:33 -07:00
2008-04-29 14:48:33 +02:00
2008-04-29 08:06:19 -07:00
2008-05-02 13:52:35 -07:00
2008-01-11 18:22:50 -06:00
2007-07-14 19:28:10 -05:00
2008-05-02 13:52:35 -07:00
2008-01-28 15:08:07 -08:00
2008-04-22 15:16:31 -05:00
2008-04-29 08:06:21 -07:00
2008-04-19 19:10:33 -07:00
2008-04-29 08:06:25 -07:00
2007-07-18 11:16:32 -05:00
2008-04-22 15:16:32 -05:00
2008-01-11 18:22:30 -06:00
2008-05-02 10:18:22 -05:00
2007-10-12 14:37:50 -04:00
2007-10-12 14:46:58 -04:00
2008-04-27 12:19:56 -05:00
2008-04-19 19:10:33 -07:00
2008-04-29 14:48:33 +02:00
2008-04-27 12:19:55 -05:00
2007-10-12 14:38:09 -04:00
2008-04-19 19:10:33 -07:00
2008-05-02 11:33:25 -05:00
2008-01-11 18:22:40 -06:00
2008-04-29 14:48:54 +02:00
2008-04-19 19:10:33 -07:00
2008-04-29 08:06:21 -07:00
2008-04-27 12:33:04 -05:00
2007-07-22 11:36:49 -07:00
2008-04-27 12:33:04 -05:00
2008-02-07 18:02:44 -06:00
2008-03-19 11:28:56 -05:00
2008-02-07 18:02:44 -06:00
2008-04-07 12:15:39 -05:00
2008-04-22 15:16:29 -05:00
2008-04-07 12:15:39 -05:00
2008-04-07 12:19:02 -05:00
2008-01-11 18:28:57 -06:00
2008-04-16 09:28:11 -05:00
2007-11-25 12:19:26 +02:00
2008-04-27 12:33:04 -05:00
2007-05-31 17:30:04 -04:00
2008-02-12 15:24:58 -06:00
2007-11-25 12:19:26 +02:00
2008-01-23 11:29:27 -06:00
2007-07-14 18:56:33 -05:00
2008-05-02 13:18:06 -05:00
2008-04-28 17:31:13 -07:00
2008-04-07 12:19:01 -05:00
2007-10-19 23:22:55 +02:00
2008-01-30 13:14:02 -06:00
2007-11-29 09:24:52 -08:00